[Testimony-devel] Re: CheckStyle and build.xml

[Petter W. <pet...@ya...>]

Hi Carlos,

--- Carlos Tasada <ct...@te...> wrote:
> Hi Peter,
> 
> I've just done a big commit (near 1,000 CheckStyle
> fixings). I've added a
> new target to the build.xml to do the checking, so
> you should be able to use
> it without problems.

Maybe you could add a comment to the build file about
where to obtain the program and where it should be
installed? I guess a libdir has to be created and a
jar file downloaded and put there. Since I'm not doing
any coding at the moment, I guess I won't use this
target. But I agree that's it's a very good idea,
especially if the checking tool is good. What kind of
errors are detected by checkstyle?

> On the other hand I have a couple of questions about
> the ant file:
> - Why have you changed some action names? I mean
> compile -> -compile, ....
> - The -compile action is working? I cannot execute
> it, but the build action
> works fine ????

The reason for that was to distinguish intermediate,
internal tasks from tasks that are intended to be run
from the command line. I read in the Ant manual that
prefixing tasks with a - is one way of making such a
distinction, and I was hoping that an intelligent IDE
would present such tasks in a different way. The goal
was to make it easier for the developer.

However, such tasks can not be run from the command
line because Ant interprets it as an option instead of
a task. Maybe it was stupid to change the name,
sometimes one wants to run the compile task... I think
maybe a good idea would be to change the name back and
write better documentation instead.

> 
> I'll continue with the fixings.
> 
> One last thing. Is the code reestructuration
> finished?

Yes, most of it. The part that is left is to break up
the huge classes into smaller parts. The IDE I'm using
can do it quite easily, so I was planning on doing it.
But if you're in a hurry, feel free to do it yourself,
because I don't know when I can get around to it.

Also, I wanted to improve the build file and add
targets for building, signing and uploading the
distribution, uploading the HTML content, etc. That is
not done yet either.

But the basic moving around of files is done.

Regards,
Petter



		
__________________________________
Do you Yahoo!?
Take Yahoo! Mail with you! Get it on your mobile phone.
http://mobile.yahoo.com/maildemo