Menu ▾ ▴

#488 Add @points to att.coordinated

GREEN
closed-fixed
Martin Holmes
None
5(default)
2014-07-01
2013-12-13
Martin de la Iglesia
No

The <surface> element currently defines rectangles only. Adding @points to att.coordinated will allow the definition of non-rectangular surfaces. This was already proposed in Feature Request #218 "Add @svg:points to att.coordinated" (https://sourceforge.net/p/tei/feature-requests/218/) but for some reason not implemented yet.
See also TEI-L: http://listserv.brown.edu/archives/cgi-bin/wa?A1=ind1312&L=TEI-L#19

Discussion

  • Martin Holmes

    Martin Holmes - 2013-12-13
    • summary: Add @points to att.coordinated --> Add <surface> to att.coordinated
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,2 +1,2 @@
-The &lt;surface&gt; element currently defines rectangles only. Adding @points to att.coordinated will allow the definition of non-rectangular surfaces. This was already proposed in Feature Request #218 "Add @svg:points to att.coordinated" (<https://sourceforge.net/p/tei/feature-requests/218/>) but for some reason not implemented yet.
+The &lt;surface&gt; element currently defines rectangles only. Adding `<surface>` to att.coordinated will allow the definition of non-rectangular surfaces. This was already proposed in Feature Request #218 "Add @svg:points to att.coordinated" (<https://sourceforge.net/p/tei/feature-requests/218/>) but for some reason not implemented yet.
 See also TEI-L: http://listserv.brown.edu/archives/cgi-bin/wa?A1=ind1312&L=TEI-L#19
     

  • Martin Holmes

    Martin Holmes - 2013-12-13
    • summary: Add <surface> to att.coordinated --> Add @points to att.coordinated
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,2 +1,2 @@
-The &lt;surface&gt; element currently defines rectangles only. Adding `<surface>` to att.coordinated will allow the definition of non-rectangular surfaces. This was already proposed in Feature Request #218 "Add @svg:points to att.coordinated" (<https://sourceforge.net/p/tei/feature-requests/218/>) but for some reason not implemented yet.
+The &lt;surface&gt; element currently defines rectangles only. Adding @points to att.coordinated will allow the definition of non-rectangular surfaces. This was already proposed in Feature Request #218 "Add @svg:points to att.coordinated" (<https://sourceforge.net/p/tei/feature-requests/218/>) but for some reason not implemented yet.
 See also TEI-L: http://listserv.brown.edu/archives/cgi-bin/wa?A1=ind1312&L=TEI-L#19
     

  • Martin Holmes

    Martin Holmes - 2013-12-13

    This seems to me to be a simple corrigible error in the original implementation of @points, which should have been added to att.coordinated rather than specified directly on <zone>. A side-effect of moving it to att.coordinated would be that <line> and <surfaceGrp> would also inherit it; for <line> that makes perfect sense -- anything that can be outlined using a rectangle can presumably also be outlined using a polygon -- but <surfaceGrp> is rather an odd case; I'm not sure it needs to be in att.coordinated at all. It's simply a grouping element for <surface> elements, used (for instance, from one of the Glines examples) to group all the leafs of a quire. None of our example show the use of dimensions on <surfaceGrp>. That said, it seems harmless for it to have those attributes, and perhaps someone wants to group surfaces (or surface groups) on a single plane, and specify their coordinates.

     

  • James Cummings

    James Cummings - 2014-05-19
    • assigned_to: Martin Holmes
     

  • James Cummings

    James Cummings - 2014-05-19

    Assigning to Martin Holmes to triage and report to council.

     

  • Martin Holmes

    Martin Holmes - 2014-07-01

    Council discussion 2014-07-01: This is a corrigible error and should just be fixed. Make green and assign. (Another ticket might be raised for the surfaceGrp issue mentioned in the discussion.)

     

  • Martin Holmes

    Martin Holmes - 2014-07-01
    • Group: AMBER --> GREEN
     

  • Martin Holmes

    Martin Holmes - 2014-07-01

    Fixed in [r12931].

     

    Related

    Commit: [r12931]

  • Martin Holmes

    Martin Holmes - 2014-07-01
    • status: open --> closed-fixed