Menu

#461 Two small improvements to `<recording>`

GREEN
closed
None
5(default)
2013-11-13
2013-06-18
Lou Burnard
No
  1. The content model is currently ( (model.pLike)+ | (model.recordingPart)* )
    which seems bizarre. It's possibly defensible to allow either model.pLike elements or model.recordingPart elements, but not both. But why not isn't it "oneOrMore" on both sides of the alternation?

  2. A very common requirement is to be able to specify a location for the audio or video file concerned. Now that we have a <media> element, should this not be made a member of model.recordingPart ?

Discussion

  • Lou Burnard

    Lou Burnard - 2013-06-18
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,11 +1,4 @@
    -1. The content model is currently  <choice xmlns="http://relaxng.org/ns/structure/1.0">
    -      <oneOrMore>
    -        <ref name="model.pLike"/>
    -      </oneOrMore>
    -      <zeroOrMore>
    -        <ref name="model.recordingPart"/>
    -      </zeroOrMore>
    -    </choice>
    +1. The content model is currently ( (model.pLike)+ | (model.recordingPart)* )
     which seems bizarre. It's possibly defensible to allow either model.pLike elements or model.recordingPart elements, but not both. But why not isn't it "oneOrMore" on both sides of the alternation?
    
     2. A very common requirement is to be able to specify a location for the audio or video file concerned. Now that we have a `<media>` element, should this not be made a member of model.recordingPart ?
    
     
  • Lou Burnard

    Lou Burnard - 2013-06-18
     
  • Lou Burnard

    Lou Burnard - 2013-06-18

    So, my proposed changes are

    a) add <media> to model.recordingPart
    b) change content of <recording> to (model.pLike|model.recordingPart)*

     
  • James Cummings

    James Cummings - 2013-11-09
    • assigned_to: Lou Burnard
     
  • James Cummings

    James Cummings - 2013-11-09

    I agree with this; Seems straightforward and uncontroversial; Leaving as green and assigning to Lou to double-check with Council before implementing.

     
  • Lou Burnard

    Lou Burnard - 2013-11-13
    • status: open --> closed
     
  • Lou Burnard

    Lou Burnard - 2013-11-13

    Implemented at rev 12614