[Teem-commit] SF.net SVN: teem:[7158] teem/trunk/src/nrrd/arraysNrrd.c

[<kin...@us...>]

Revision: 7158
          http://sourceforge.net/p/teem/code/7158
Author:   kindlmann
Date:     2023-09-11 10:12:18 +0000 (Mon, 11 Sep 2023)
Log Message:
-----------
nrrdTypeIsIntegral[nrrdTypeBlock] is no longer true; this was asserted in ~2002 but never made sense

Modified Paths:
--------------
    teem/trunk/src/nrrd/arraysNrrd.c

Modified: teem/trunk/src/nrrd/arraysNrrd.c
===================================================================
--- teem/trunk/src/nrrd/arraysNrrd.c	2023-09-10 23:17:04 UTC (rev 7157)
+++ teem/trunk/src/nrrd/arraysNrrd.c	2023-09-11 10:12:18 UTC (rev 7158)
@@ -72,7 +72,11 @@
   1, /* nrrdTypeULLong: unsigned long long */
   0, /* nrrdTypeFloat: float */
   0, /* nrrdTypeDouble: double */
-  1  /* nrrdTypeBlock: for some reason we pretend that blocks are integers */
+  0  /* nrrdTypeBlock: "for some reason we pretend that blocks are integers" is what this
+     used to say since ~2002 when this array was created (under the  name
+     nrrdTypeIsFixedPoint), but that was never justified or necessary (afaik).  For 2023
+     Teem v2 hacking, GLK got annoyed that CC code in cc.c didn't immediately  complain
+     that nrrdTypeBloack was a useless type for output CC IDs. */
 };
 
 const int nrrdTypeIsUnsigned[NRRD_TYPE_MAX + 1] = {
@@ -87,7 +91,10 @@
   1, /* nrrdTypeULLong: unsigned long long */
   0, /* nrrdTypeFloat: float */
   0, /* nrrdTypeDouble: double */
-  0  /* nrrdTypeBlock: for some reason we pretend that blocks are signed */
+  0  /* nrrdTypeBlock: "for some reason we pretend that blocks are signed" See note about
+  nrrdTypeIsIntegral[nrrdTypeBlock] above. While the value of
+  nrrdTypeIsUnsigned[nrrdTypeBlock] has not changed; we don't pretend that nrrdTypeBlock
+  is any kind of number. */
 };
 
 /*

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.