[Td2jira-commits] SF.net SVN: td2jira: [27] trunk/td2jira/src/td2jira/Config.java

[<lac...@us...>]

Revision: 27
          http://td2jira.svn.sourceforge.net/td2jira/?rev=27&view=rev
Author:   lacostej
Date:     2007-10-04 02:01:03 -0700 (Thu, 04 Oct 2007)

Log Message:
-----------
Cleanup code + use foreach

Modified Paths:
--------------
    trunk/td2jira/src/td2jira/Config.java

Modified: trunk/td2jira/src/td2jira/Config.java
===================================================================
--- trunk/td2jira/src/td2jira/Config.java	2007-10-04 08:58:24 UTC (rev 26)
+++ trunk/td2jira/src/td2jira/Config.java	2007-10-04 09:01:03 UTC (rev 27)
@@ -1,20 +1,16 @@
 package td2jira;
 
-import java.io.FileInputStream;
 import java.io.InputStream;
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
 import java.util.HashMap;
 import java.util.HashSet;
-import java.util.Iterator;
 import java.util.Map;
 import java.util.Properties;
 import java.util.Set;
 
 import org.apache.log4j.Logger;
 
-import td2jira.td.ITDConnector;
-
 public class Config {
   public static Logger logger = Logger.getLogger(Config.class);
 
@@ -60,9 +56,10 @@
   private static InputStream getResourceInputStream(String resource) {
     return Thread.currentThread().getContextClassLoader().getResourceAsStream(resource);
   }
-  
+
   public static void load() throws Exception {
-    if (props.size() != 0) return;
+    if (props.size() != 0)
+      return;
     props.load(getResourceInputStream("td2jira.properties"));
 
     Field[] fields = Config.class.getDeclaredFields();
@@ -74,7 +71,7 @@
       String val = (String) field.get(null);
 
       int eqSign = val.indexOf('=');
-      String propertyName = null;
+      String propertyName;
       String propertyDefaultValue = null;
       if (eqSign > 0) {
         propertyName = val.substring(0, eqSign);
@@ -117,9 +114,7 @@
 
   public static Set<String> getDevelopersInJIRA() {
     Set<String> ret = new HashSet<String>();
-    Iterator<String> it = tdDevelopersToJiraDevelopers.keySet().iterator();
-    while (it.hasNext()) {
-      String td = it.next();
+    for (String td : tdDevelopersToJiraDevelopers.keySet()) {
       String jira = tdDevelopersToJiraDevelopers.get(td);
       if (jira != null) ret.add(jira);
     }
@@ -128,9 +123,7 @@
 
   public static Set<String> getDevelopersNamesInTD() {
     Set<String> ret = new HashSet<String>();
-    Iterator<String> it = tdDevelopersToJiraDevelopers.keySet().iterator();
-    while (it.hasNext()) {
-      String td = it.next();
+    for (String td : tdDevelopersToJiraDevelopers.keySet()) {
       ret.add(td);
     }
     return ret;
@@ -148,10 +141,9 @@
 //	}
 
   public static String getTDDeveloperForJIRADeveloper(String assignedInJIRA) {
-    Iterator<String> it = tdDevelopersToJiraDevelopers.keySet().iterator();
-    while (it.hasNext()) {
-      String td = it.next();
-      if (tdDevelopersToJiraDevelopers.get(td).equals(assignedInJIRA)) return td;
+    for (String td : tdDevelopersToJiraDevelopers.keySet()) {
+      if (tdDevelopersToJiraDevelopers.get(td).equals(assignedInJIRA))
+        return td;
     }
     return null;
   }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.