Menu

#94 TRDP_REDUNDANT flag never evaluated

1.3.0.0
closed
1437 (1)
2015-10-05
2015-08-17
Kalle Ranki
No

In trdp_pdcom.c https://sourceforge.net/p/tcnopen/trdp/HEAD/tree/trunk/trdp/src/common/trdp_pdcom.c#l259
trdp_pdSendQueued() always sends process data marked with TRDP_REDUNDANT. Complex logical expression used to determine redundant uses uninitialized value appHandle->beQuiet, which will always evaluate to true, so the flag is never used.

Is beQuiet going to be useful at all or should it be removed completely? Currently it is just never used.
Should we return an error if socketIdx == -1 ?

Also same issue is found in trdp_mdcom.c

My patch is incomplete, so the error handling and logging should be added still.

1 Attachments

Discussion

  • Bernd Löhr

    Bernd Löhr - 2015-08-31
    • status: open --> accepted
     
  • Bernd Löhr

    Bernd Löhr - 2015-08-31

    Artifact beQuiet removed, invalid socketIdx handled

     
  • Bernd Löhr

    Bernd Löhr - 2015-08-31
    • status: accepted --> pending
     
  • Armin-Hagen Weiss

    • labels: --> 1437
    • status: pending --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB