The mdcom module needs overhaul in aspects of readability and error handling. Furthermor static analysis revealed potential flaws, which may lead to sporadic issues during runtime.
Changeset [r1337] contains a major overhaul of numerous functions to get compexity lower and readability higher.
Broke up several functions into subfunctions (for example trdp_mdRecvPacket) to get better modularization.
Still a lot is open, notably the common send routine is still very long. After having [#48] another sweep might be conducted for this ticket.
Closing this ticket for this step.
In a later reworking session the function trdp_mdCommonSend should get split up into use case specific functions for calling/replying/confirm.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Most obvious error causing potential overflow fixed in [r1326] - more to come
Related
Commit: [r1326]
Changeset [r1337] contains a major overhaul of numerous functions to get compexity lower and readability higher.
Broke up several functions into subfunctions (for example trdp_mdRecvPacket) to get better modularization.
Still a lot is open, notably the common send routine is still very long. After having [#48] another sweep might be conducted for this ticket.
Related
Tickets:
#48Commit: [r1337]
introduced static for all functions not used elsewhere in libtrdp (trdp_mdcom.c/h) in [r1345]
Related
Commit: [r1345]
Closing this ticket for this step.
In a later reworking session the function trdp_mdCommonSend should get split up into use case specific functions for calling/replying/confirm.