Menu

#367 Cashed DNS only invalid if both etbTopoCnt and opTrnTopoCnt is changed

2.1.0.0
closed
2235 (1)
2021-08-11
2021-04-13
No

When checking a cashed DNS entry it is accepted as valid if ether cashed
etbTopoCnt == appHandle->etbTopoCnt
or
opTrnTopoCnt == appHandle->opTrnTopoCnt
is true.

My expectation is that if any is changed the cashed DNS entry is invalid.

In tau_uri2Addr
Old sources:
if ((pTemp != NULL) &&
((pTemp->fixedEntry == TRUE) ||
(pTemp->etbTopoCnt == appHandle->etbTopoCnt) || / Do the topocounts match? /
(pTemp->opTrnTopoCnt == appHandle->opTrnTopoCnt) ||
((appHandle->etbTopoCnt == 0u) && (appHandle->opTrnTopoCnt == 0u))) && / Or do we not care? /
(pTemp->ipAddr != 0)) / 0 is only a placeholder /

Expected:
if ((pTemp != NULL) &&
((pTemp->fixedEntry == TRUE) ||
((pTemp->etbTopoCnt == appHandle->etbTopoCnt) && / Do the topocounts match? /
(pTemp->opTrnTopoCnt == appHandle->opTrnTopoCnt) ) ||
((appHandle->etbTopoCnt == 0u) && (appHandle->opTrnTopoCnt == 0u))) && / Or do we not care? /
(pTemp->ipAddr != 0)) /* 0 is only a placeholder *

Discussion

  • Armin-Hagen Weiss

    • labels: --> 2235
    • status: open --> pending
    • assigned_to: Iris Bosse
     
  • Armin-Hagen Weiss

     
  • Armin-Hagen Weiss

    Changed accordingly. To be tested.

     
  • Stefan Bender

    Stefan Bender - 2021-08-11
     
  • Stefan Bender

    Stefan Bender - 2021-08-11

    Tested in api_test_4.c test2

     
  • Stefan Bender

    Stefan Bender - 2021-08-11
    • status: pending --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB