TCNOpen / Tickets / #364 All vehicle, closed train, ETB info in Consist info is stored at index 0

Components for IEC61375 standardised communication

#364 All vehicle, closed train, ETB info in Consist info is stored at index 0

Milestone: 2.1.0.0

Status: closed

Owner: Iris Bosse

Labels: 2238 (1)

Updated: 2021-08-11

Created: 2021-04-06

Creator: Anders Öberg

Private: No

In function ttiCreateCstInfoEntry when coping vehicle info, closed train info, ETB info from telegram to TTDB the index is not used so it store the data at index 0 for all cars.

Old sources:
/ copy the vehicle list /
for (idx = 0u; idx < pDest->vehCnt; idx++)
{
memcpy(pDest->pVehInfoList->vehId, pData, sizeof(TRDP_NET_LABEL_T));
pData += sizeof(TRDP_NET_LABEL_T);
memcpy(pDest->pVehInfoList->vehType, pData, sizeof(TRDP_NET_LABEL_T));
pData += sizeof(TRDP_NET_LABEL_T);
pDest->pVehInfoList->vehOrient = *pData++;
....
....

Expected sources:
/ copy the vehicle list /
for (idx = 0u; idx < pDest->vehCnt; idx++)
{
memcpy(pDest->pVehInfoList[idx].vehId, pData, sizeof(TRDP_NET_LABEL_T));
...
....

Discussion

Armin-Hagen Weiss - 2021-04-13

labels: --> 2238

status: open --> pending

assigned_to: Iris Bosse
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Armin-Hagen Weiss - 2021-04-13

Changed accordingly. To be tested.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

summary: All vehicle info in Consist info is stored at index 0 --> All vehicle, closed train, ETB info in Consist info is stored at index 0
Description has changed:

Diff:

--- old
+++ new
@@ -1,4 +1,4 @@
-In function ttiCreateCstInfoEntry when coping vehicle info from telegram to TTDB the index is not used so it store the data at index 0 for all cars.
+In function ttiCreateCstInfoEntry when coping vehicle info, closed train info,  ETB info from telegram to TTDB the index is not used so it store the data at index 0 for all cars.

 Old sources:
 /* copy the vehicle list */

Armin-Hagen Weiss - 2021-04-13

Changed accordingly. To be tested.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Bender - 2021-08-11

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Bender - 2021-08-11

Tested in api_test_4.c test3

Last edit: Stefan Bender 2021-08-11

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Bender - 2021-08-11

status: pending --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

All vehicle, closed train, ETB info in Consist info is stored at index 0

Components for IEC61375 standardised communication

Milestone

Searches

Help

#364 All vehicle, closed train, ETB info in Consist info is stored at index 0

Discussion