#350 SPY: BITSET8 visualized as BOOL

[Armin-Hagen Weiss]

BITSET8 is visualised as BOOL instead of HEX

XML:

<data-set id="user-content-4001" name="TCU1_STATUS">
<element type="UINT8" name="StatoMar_TCU">
<element type="BITSET8" name="byte_01">
<element type="UINT8" name="spare_02">
<element type="UINT8" name="spare_03">
<element type="UINT8" name="spare_04">
<element type="UINT8" name="spare_05">
<element type="UINT16" name="ED_Target" offset="0" scale="0.001" unit="kN">
<element type="UINT16" name="SforAtt" offset="0" scale="0.001" unit="kN">
<element name="array_spare" type="UINT8" array-size="117">
<element type="UINT16" name="Life">
</element></element></element></element></element></element></element></element></element></element></data-set>

VISU:

    TCU1_STATUS   (4001)
          StatoMar_TCU:   33
          byte_01:   False   <---------------------------------------------------
          spare_02:   2
          spare_03:   3
          spare_04:   4
          spare_05:   5
          ED_Target:   27,5 KN  (raw=27500)
          SforAtt:   25,2 KN  (raw=25200)
     > UINT8  (8): array_spare[117]
           Life:   3212
           padding:   padding

[Thorsten]

Hi Armin,
I remember this puzzling me, how and where the three pseudo-types make a difference. I.e., ANTIVALENT8 and BITSET8 do not have an own fixed dataset-id.
I mean, it would also be nice to have the ANTIVALENT shown correctly / verified for bad values. However, without a concise mapping between name and id this will need some tricking. I will have a look if an easy hack is doable.

Thorsten

[Thorsten]

soo,
I think I can provide a patch here for the issue - it works for me. For the problem mentioned above, if the trdp-type is given as a number in the xml, one can select a default interpretation for this in the protocol preferences. Otherwise, Antivalent and Bool are shown as Boolean (and can be filtered for like that). Invalid values in Antivalents issue a warning. Bitsets are shown as hex and binary for ease of reading.
I wrapped all my latest changes to the spy-plugin in the patch. This results in a bit of "noise" due to an updated Doxygen file.
See commits leading to this: https://github.com/T12z/TCNopen/commits/master/trdp/spy/src
I also updated the the Linux-plugin-binary for 3.4 (see https://github.com/T12z/TCNopen/tree/master/trdp/spy/plugins/3.4/epan not included in the patch). I cannot/will not update older versions. As my Windows-Box is out of reach, I also cannot update the Windows binary.

Despite that, I believe the plugin is also lacking support for SDT (I have no working example) and TSN packets. I may be able to look into this in 2021.