Menu

#238 VOS: Public API headers include private header file

1.4.2.0
closed
None
2019-06-14
2019-02-14
No

Several of the header files in the public VOS API include vos_private.h.
Either these dependencies should be removed or vos_private.h should be come part of the API.

Discussion

  • Bernd Löhr

    Bernd Löhr - 2019-02-14
     
  • Bernd Löhr

    Bernd Löhr - 2019-02-14

    This is mainly the case for the vxWorks code and the vos_shared_mem.h file. If you can build for vxWorks, could you take over this ticket? I cannot...

     
  • Bernd Löhr

    Bernd Löhr - 2019-02-14
    • assigned_to: Bernd Brandstetter
     
  • Bernd Brandstetter

    At least after a quick look through the files, I don't see that including vos_private.h would be necessary in any of the API header files; I don't know why these inclusions exist at all.

    vos_private.h mainly specifies platform-dependent structure definitions of the types VOS_SEMA, VOS_MUTEX and VOS_SHRD.

    But since the VOS API uses hidden definitions it is not necessary that the structure definitions are actually known in the header files.

     
  • Bernd Löhr

    Bernd Löhr - 2019-06-12
    • status: open --> accepted
     
  • Bernd Löhr

    Bernd Löhr - 2019-06-12
    • status: accepted --> pending
    • assigned_to: Bernd Brandstetter --> Bernd Löhr
     
  • Bernd Löhr

    Bernd Löhr - 2019-06-14
    • Status: pending --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB