#166 Bug in trdp_pdReceive for "if data has changed"

[William Aeby]

In src/common/trdp_pdcom.c there is a bug in function trdp_pdReceive. Namely the line

informUser = memcmp(appHandle->pNewFrame->data,
pExistingElement->pFrame->data,
pExistingElement->dataSize);
should be:

informUser = memcmp(appHandle->pNewFrame->data,
pExistingElement->pFrame->data,
pExistingElement->dataSize) == 0 ? FALSE : TRUE;

Because TRUE is "1" and memcmp will not necessarily return 1 in the case it is not false. See memcmp documentation

[Bernd Löhr]

Yep, unfortunately too late for 1.3.3. Will be fixed in trunk...