Menu

#164 tlp_request: EXOR used to clear a bit

1.3.3.0
closed
None
2017-07-14
2017-07-12
No

Code taken from v1.3.2.0

 pSubPD->privFlags ^= (unsigned)~TRDP_TIMED_OUT;   /* Reset time out flag (#151) */

This operation has side effects other bits. I'd expect the use of an BITAND

 pSubPD->privFlags &= (unsigned)~TRDP_TIMED_OUT;

Discussion

  • Bernd Löhr

    Bernd Löhr - 2017-07-12
    • assigned_to: Bernd Löhr
    • Milestone: 1.4.0.0 --> 1.3.3.0
     
  • Bernd Löhr

    Bernd Löhr - 2017-07-12

    Yep: Last minute bug ;-(
    Will go into release 1.3.3

     
  • Bernd Löhr

    Bernd Löhr - 2017-07-14
    • status: open --> closed
     
  • Bernd Löhr

    Bernd Löhr - 2017-07-14

    Fixed both in 1.3.2 (as patch) and 1.3.3

     

Log in to post a comment.

MongoDB Logo MongoDB