Menu

#20 patch and tests for -final 0 option in tclparser

open
TclXML (14)
5
2008-02-13
2008-02-13
Pat Thoyts
No

The -final 0 option is broken in all versions of the tclparser since 2.6 and so cannot be used to parse jabber/xmpp streams. It seems that the patch provided in #596959 (sgml parser loses #pcdata in tokenise) clashed with a later change in the caller of the tokenize function in tclparser.tcl and this breaks the token stream by introducing an extra empty element which pushes the stream out of phase.
The attached patch removes this rogue code and includes a number of tests that check that the xml stream processing works ok including split parsing within element tags and within pcdata (the original complaint in #596959.
With this patch in place I am able to successfully work with jabber streams using the jabberlib package and tcxml 3.1
See also bug #413341 which concerns the -final processing.

Discussion

  • Pat Thoyts

    Pat Thoyts - 2008-02-13

    windows line ending cvs diff

     
  • Pat Thoyts

    Pat Thoyts - 2008-02-13
    • assigned_to: nobody --> matben
     
  • Mats Bengtsson

    Mats Bengtsson - 2008-02-13
    • assigned_to: matben --> balls
     
  • Mats Bengtsson

    Mats Bengtsson - 2008-02-13

    Logged In: YES
    user_id=108900
    Originator: NO

    It is better that the original author takes responsibility for this patch so that it will be correctly applied.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.