tclxml-users

[Tclxml-users] bugs -errorcommand ?

[Mats B. <ma...@pr...>]

The docs for TclXML specify the -errorcommand proc to take two parameters,
'tclProc errorcode errormessage', but browsing through the 'sgmlparser.tcl'
file, the error proc is usually called as:

uplevel #0 $options(-errorcommand) "$attr around line $state(line)"

and in some places as:

uplevel #0 $options(-errorcommand) [list $attr around line $state(line)]

The uplevel command concatenates all its arguments which breaks the 
list structure above. I guess that a number of [list [list ....] ...]
commands are needed here to build the proper list structure.

There are many 'uplevel #0 $options(-errorcommand)' statements to fix.

Am I right here?

/Mats

code------

set data2 {<stream:error>Invalid XML</stream:error>}
proc HandleError {errcode errmsg} {
    puts "Error ==> errcode=$errcode, errmsg=$errmsg"
}
...
set myParser [xml::parser]
$myParser configure -elementstartcommand HandleStart  \
  -elementendcommand HandleEnd -characterdatacommand HandleText \
  -final 0 -errorcommand HandleError
$myParser parse $data2
> called "HandleError" with too many arguments

Re: [Tclxml-users] bugs -errorcommand ?

[<Ste...@zv...>]

Mats Bengtsson wrote:
> 
> The docs for TclXML specify the -errorcommand proc to take two parameters,
> 'tclProc errorcode errormessage', but browsing through the 'sgmlparser.tcl'
> file, the error proc is usually called as:
> 
> uplevel #0 $options(-errorcommand) "$attr around line $state(line)"
> 
> and in some places as:
> 
> uplevel #0 $options(-errorcommand) [list $attr around line $state(line)]
> 
> The uplevel command concatenates all its arguments which breaks the
> list structure above. I guess that a number of [list [list ....] ...]
> commands are needed here to build the proper list structure.
> 
> There are many 'uplevel #0 $options(-errorcommand)' statements to fix.
> 
> Am I right here?

Hmmm... yes I'd say so.  The Error procedure in sgml-8.[01].tcl simply
uses 'args'.  Sorry about that!  Would you care to submit a patch? ;-)

Cheers,
Steve Ball

-- 
Steve Ball            |   XSLT Standard Library   | Training & Seminars
Zveno Pty Ltd         |     Web Tcl Complete      |   XML XSL Schemas
http://www.zveno.com/ |      TclXML TclDOM        | Tcl, Web Development
Ste...@zv...  +---------------------------+---------------------
Ph. +61 2 6242 4099   |   Mobile (0413) 594 462   | Fax +61 2 6242 4099