Re: [tclwebtest] do_link -nocomplain doesn't behave as documented

[Grzegorz A. H. <gr...@ef...>]

On Fri, Jan 24, 2003 at 02:29:04PM +0000, Tilmann Singer wrote:
> This might be an error introduced with the ad_proc rewrite (damn, we
> need better self tests). Try to replace $nocomplain with $nocomplain_p
> within the do_request proc and tell me if that works.

It works. I generated this patch against my own CVS because the
one at SF still doesn't have my previous one. The function still
fails if you try to connect to a non-existant server.

Index: tclwebtest.tcl
===================================================================
RCS file: /home/maincvs/efintranet/www/tclwebtest/prog/tclwebtest.tcl,v
retrieving revision 1.4
diff -u -r1.4 tclwebtest.tcl
--- tclwebtest.tcl      22 Jan 2003 18:11:54 -0000      1.4
+++ tclwebtest.tcl      27 Jan 2003 14:58:28 -0000
@@ -1672,7 +1672,7 @@
 } {
     link_variables regexp_defs
     
-    if $nocomplain {
+    if $nocomplain_p {
         set nocomplain_option "-nocomplain"
     } else {
         set nocomplain_option ""
@@ -1782,9 +1782,11 @@
         eval "do_request $nocomplain_option $followequiv_option $location"
         
     } elseif { $http_status != "200" } {
-        debug -lib "$nocomplain"
-        if { !$nocomplain } {
+        debug -lib "$nocomplain_p"
+        if { !$nocomplain_p } {
             assertion_failed "do_request did not return a page. HTTP status is $http_status"
+        } else {
+            log "Bad http answer ignored due to -nocomplain"
         }
     }

-- 
 Grzegorz Adam Hankiewicz, gr...@ef.... Tel: +34-94-472 35 89.
 eFaber SL, Maria Diaz de Haro, 68, 2         http://www.efaber.net/
 48920 Portugalete, Bizkaia (SPAIN)