tcltk-perl

RE: [tcltk-perl] Makefile.PL cleanup [PATCH]

[Konovalov, V. <vko...@sp...>]

Will apply this patch and a patch that you sent few letters ago :)

BTW once CVS will be working on "tcltk" project of SF site, you will have
write access and apply reasonable changes by your own?


> 
> 
> Suggested cleanup patch for Tcl's Makefile.PL. It gets rid of badly
> handcoded option parsing and replace it with Getopt::Long. Similar
> patch also makes sense for the Tcl-Tk one.
> 
> --Gisle
> 
> Index: Makefile.PL
> ===================================================================
> RCS file: /cvsroot/tcltkce/Tcl/Makefile.PL,v
> retrieving revision 1.3
> diff -u -p -u -r1.3 Makefile.PL
> --- Makefile.PL	9 Apr 2004 19:05:23 -0000	1.3
> +++ Makefile.PL	14 Apr 2004 08:52:43 -0000
> @@ -1,33 +1,24 @@
> +#!/usr/bin/perl -w
> +
>  # before running this script make sure you have 'tclsh' in 
> your path, 
>  # and this 'tcl' distribution is required one.
>  # FreeBSD users may want to modify name of tcl interpreter (this is
>  # $tclsh variable below) as long as 'tclsh' does not work in 
> their case
>  
> +use strict;
> +use Getopt::Long qw(GetOptions);
> +
>  my $tclsh = 'tclsh';
>  my $tclconfig;
>  my $buildspec;
>  my $libpath;
>  my $incpath;
>  
> -while (1) {
> -    # Handle any --options
> -    last unless @ARGV[0] =~ /^--/;
> -    my $opt = shift @ARGV;
> -    my $val = shift @ARGV;
> -    if ($opt eq "--tclsh") {
> -	$tclsh = $val;
> -    }
> -    elsif ($opt eq "--tclconfig") {
> -	$tclconfig = $val;
> -    }
> -    elsif ($opt eq "--buildspec") {
> -	$buildspec = 1;
> -    }
> -    else {
> -	die "unknown option '$opt', must be --tclsh, 
> --tclconfig or --buildspec\n";
> -    }
> -}
> -
> +GetOptions("tclsh=s", \$tclsh,
> +	   "tclconfig=s", \$tclconfig,
> +	   "buildspec", \$buildspec)
> +    || die "Usage: perl Makefile.PL [--tclsh <path>] 
> [--tclconfig <path>] " .
> +                                   "[--buildspec] 
> [<makemaker opts>...]\n";
>  
>  if ($tclconfig) {
>      die "Tcl config file '$tclconfig' not found\n" unless 
> (-f $tclconfig);
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> Tcltk-perl mailing list
> Tcl...@li...
> https://lists.sourceforge.net/lists/listinfo/tcltk-perl
> 

RE: [tcltk-perl] Makefile.PL cleanup [PATCH]

[Konovalov, V. <vko...@sp...>]

> > BTW once CVS will be working on "tcltk" project of SF site, 
> you will have
> > write access and apply reasonable changes by your own?
> 
> Thanks.  I'm known as 'gisle' at sourceforge if you want to add me as
> a maintainer.  Please tell me if you think patches are inappropriate
> for the list until then.  At least they create some traffic :-)
> 
> I think discussing patches on the list is the best way to reach
> consensus on the approach to take.  Trivial stuff which nobody is
> likely to disagree with (like my Tcl::Ev patch) is best checked in
> directly without telling the list.


I am very agree with you.

But "tcltk" does not have CVS yet, and I do not have rights to include you
anyway for that project.

Currently CVS from "tcltkce" project is used, now I've included you so you
should be able to do commits.
But anyway development is moving to "tcltk" project, and I am sure Jeff will
manage things correctly to include those who can help us developing module.

I hope Jeff will help us and inform more exact dates of CVS moving.

Best regards,
Vadim.

[tcltk-perl] ChangeLog

[Gisle A. <gi...@Ac...>]

How is the ChangeLog maintained?  Is it some script that adds to it or
is it manually updated?

--Gisle

Re: [tcltk-perl] ChangeLog

[Jeff H. <je...@Ac...>]

Gisle Aas wrote:
> How is the ChangeLog maintained?  Is it some script that adds to it or
> is it manually updated?

It is manually updated, but I use emacs, which has a lot of
"ChangeLog" knowledge built in.  ^x-4-a in a function will
go up the dir tree looking for a ChangeLog.  If none is found,
it creates a new one in the current directory.  It creates
the ChangeLog entry, auto-inserting a lot of the information
(for example, if you are in a perl sub or C function, it knows
they func name and adds that to the file part).

My ChangeLog habits are based on this and other conventions
used by the Tcl core team to manage change information over
time in CVS (p4 or bk would be better, but we are on CVS for
now).

Jeff

Re: [tcltk-perl] Makefile.PL cleanup [PATCH]

[Gisle A. <gi...@Ac...>]

"Konovalov, Vadim" <vko...@sp...> writes:

> BTW once CVS will be working on "tcltk" project of SF site, you will have
> write access and apply reasonable changes by your own?

Thanks.  I'm known as 'gisle' at sourceforge if you want to add me as
a maintainer.  Please tell me if you think patches are inappropriate
for the list until then.  At least they create some traffic :-)

I think discussing patches on the list is the best way to reach
consensus on the approach to take.  Trivial stuff which nobody is
likely to disagree with (like my Tcl::Ev patch) is best checked in
directly without telling the list.

--Gisle

RE: [tcltk-perl] Makefile.PL cleanup [PATCH]

[Jeff H. <je...@Ac...>]

Gisle Aas wrote:
> "Konovalov, Vadim" <vko...@sp...> writes:
> 
> > BTW once CVS will be working on "tcltk" project of SF site, you will 
> > have write access and apply reasonable changes by your own?
> 
> Thanks.  I'm known as 'gisle' at sourceforge if you want to 
> add me as a maintainer.  Please tell me if you think patches 
> are inappropriate for the list until then.  At least they 
> create some traffic :-)

I've added you to 'tcltk', I will announce on this list when we
get the CVS moved.

> I think discussing patches on the list is the best way to 
> reach consensus on the approach to take.  Trivial stuff which 
> nobody is likely to disagree with (like my Tcl::Ev patch) is 
> best checked in directly without telling the list.

Agreed.

Jeff