RE: [tcltk-perl] What version of perl is required?

[Konovalov, V. <vko...@sp...>]

> This patch is needed to get Tcl to build and have a clean 'make test'
> on perl5.005_04-RC1:


Thank you a lot.
Will insert those to next CPAN release.

But did you used latest CVS version, where Jeff made many improvements?

Best regards,
Vadim.

> 
> ==== //depot/users/gisle/hacks/Tcl/Tcl.xs#3 - 
> /home/gisle/hacks/Tcl/Tcl.xs ====
> Index: users/gisle/hacks/Tcl/Tcl.xs
> --- users/gisle/hacks/Tcl/Tcl.xs.~1~	Wed Apr 14 11:58:30 2004
> +++ users/gisle/hacks/Tcl/Tcl.xs	Wed Apr 14 11:58:30 2004
> @@ -15,6 +15,17 @@
>  #include "perl.h"
>  #include "XSUB.h"
>  
> +#ifndef dTHX
> +   #define dTHX ;
> +   #define pTHX_
> +   #define aTHX_
> +#endif
> +
> +#ifndef SvPV_nolen
> +    STRLEN my_na;
> +    #define SvPV_nolen(str) SvPV(str, my_na)
> +#endif
> +
>  #ifndef DEBUG_REFCOUNTS
>  #define DEBUG_REFCOUNTS 0
>  #endif
> @@ -136,9 +147,11 @@
>  	str = Tcl_GetStringFromObj(objPtr, &len);
>  	sv = newSVpvn(str, len);
>  	/* should turn on, but let's check this first for efficiency */
> +#ifdef SvUTF8_on
>  	if (len && has_highbit(str, len)) {
>  	    SvUTF8_on(sv);
>  	}
> +#endif
>      }
>      return sv;
>  }
> ==== //depot/users/gisle/hacks/Tcl/t/var.t#2 - 
> /home/gisle/hacks/Tcl/t/var.t ====
> Index: users/gisle/hacks/Tcl/t/var.t
> --- users/gisle/hacks/Tcl/t/var.t.~1~	Wed Apr 14 11:58:30 2004
> +++ users/gisle/hacks/Tcl/t/var.t	Wed Apr 14 11:58:30 2004
> @@ -41,6 +41,7 @@
>  
>  # some Unicode tests
>  if ($]>=5.006 && $i->GetVar("tcl_version")>=8.1) {
> +eval <<'EOT';  die $@ if $@;
>      $i->SetVar("univar","\x{abcd}\x{1234}");
>      if ($i->GetVar("univar") ne "\x{abcd}\x{1234}") {
>  	print "not ";
> @@ -55,6 +56,7 @@
>      print "ok 8 # Unicode persistence for tied variable\n";
>      binmode(STDOUT, ":utf8") if $] >= 5.008;
>      print "# $r\n";
> +EOT
>  }
>  else {
>      for (7..8) {print "ok $_  # skipped: not Unicode-aware 
> Perl or Tcl\n";}
> End of Patch.