From: Andreas K. <aku...@sh...> - 2019-08-21 06:47:48
|
I have started the work on Tcllib release 1.20. See https://core.tcl-lang.org/tcllib/timeline?r=tcllib-1-20-rc for the branch this work is happening on. It passed the testsuite for me: Platform: Linux amd64 Core: 8.4.20, 8.5.19, 8.6.9 With: tcllibc Please test this revision in your environments as well. My test controller: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #!/bin/bash set -x log=../ALL clear echo rm -rf modules/tcllibc rm -f ${log}.* ./sak.tcl critcl > ${log}.critcl time nice ./sak.tcl test run -l ${log} "$@" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- See you, Andreas Kupries <aku...@sh...> <http://core.tcl.tk/akupries/> Developer @ SUSE Software Canada ULC <and...@su...> Tcl'2019, Nov 5-8, Houston, TX, USA. http://www.tcl.tk/community/tcl2019/ ------------------------------------------------------------------------------- |
From: Pietro C. <ga...@ga...> - 2019-08-21 11:34:53
|
On Aug 21 2019, 06:32 UTC, Andreas Kupries <aku...@sh...> wrote: > >I have started the work on Tcllib release 1.20. > >See > https://core.tcl-lang.org/tcllib/timeline?r=tcllib-1-20-rc > >for the branch this work is happening on. > >It passed the testsuite for me: > > Platform: Linux amd64 > Core: 8.4.20, 8.5.19, 8.6.9 > With: tcllibc > >Please test this revision in your environments as well. Two "hook" and three "string" tests fail with 8.7 because of (I think) how it reports the name of namespaces ensemble commands. Everything else is fine with both 8.6 and 8.7. This is FreeBSD 12.0-RELEASE-p9 amd64. ---- errorcommand-1.2 start ==== errorcommand-1.2 error with -errorcommand set FAILED ==== Contents of test case: hook configure -errorcommand ErrorCommand hook bind S1 <H1> O1 {error "simulated error"} hook call S1 <H1> GetError ---- Result was: {{S1 <H1> {} O1} {simulated error} {-code 1 -level 0 -errorstack {INNER {error {simulated error}} UP 1 CALL {::hook::call S1 <H1>}} -errorcode NONE}} ---- Result should have been (exact matching): {{S1 <H1> {} O1} {simulated error} {-code 1 -level 0 -errorstack {INNER {error {simulated error}} UP 1 CALL {call S1 <H1>}} -errorcode NONE}} ==== errorcommand-1.2 FAILED ---- errorcommand-1.3 start ==== errorcommand-1.3 handled errors don't break sequence of calls FAILED ==== Contents of test case: hook configure -errorcommand ErrorCommand TestBind S1 <H1> O1 hook bind S1 <H1> O2 {error "simulated error"} TestBind S1 <H1> O3 hook call S1 <H1> list [GetCalls] [GetError] ---- Result was: {{S1 <H1> O1 {}} {S1 <H1> O3 {}}} {{{S1 <H1> {} O2} {simulated error} {-code 1 -level 0 -errorstack {INNER {error {simulated error}} UP 1 CALL {::hook::call S1 <H1>}} -errorcode NONE}}} ---- Result should have been (exact matching): {{S1 <H1> O1 {}} {S1 <H1> O3 {}}} {{{S1 <H1> {} O2} {simulated error} {-code 1 -level 0 -errorstack {INNER {error {simulated error}} UP 1 CALL {call S1 <H1>}} -errorcode NONE}}} ==== errorcommand-1.3 FAILED ---- string-token-shell-1.0 start ==== string-token-shell-1.0 string token shell, wrong#args, not enough FAILED ==== Contents of test case: string token shell ---- Result was: wrong # args: should be "::string::token::shell ?-indices? ?-partial? ?--? text" ---- Result should have been (exact matching): wrong # args: should be "shell ?-indices? ?-partial? ?--? text" ==== string-token-shell-1.0 FAILED ---- string-token-shell-1.1 start ==== string-token-shell-1.1 string token shell, wrong#args, too many FAILED ==== Contents of test case: string token shell T X ---- Result was: wrong # args: should be "::string::token::shell ?-indices? ?-partial? ?--? text" ---- Result should have been (exact matching): wrong # args: should be "shell ?-indices? ?-partial? ?--? text" ==== string-token-shell-1.1 FAILED ---- string-token-shell-1.2 start ++++ string-token-shell-1.2 PASSED ---- string-token-shell-1.3 start ==== string-token-shell-1.3 string token shell, wrong#args, too many FAILED ==== Contents of test case: string token shell -- T X ---- Result was: wrong # args: should be "::string::token::shell ?-indices? ?-partial? ?--? text" ---- Result should have been (exact matching): wrong # args: should be "shell ?-indices? ?-partial? ?--? text" ==== string-token-shell-1.3 FAILED -- Pietro Cerutti |
From: Andreas K. <AKu...@su...> - 2019-08-21 17:01:34
|
On Wed, 21 Aug 2019 11:17:07 +0000 "Pietro Cerutti" <ga...@ga...> wrote: > On Aug 21 2019, 06:32 UTC, Andreas Kupries <aku...@sh...> wrote: > > > >I have started the work on Tcllib release 1.20. > > > >See > > https://core.tcl-lang.org/tcllib/timeline?r=tcllib-1-20-rc > > > >for the branch this work is happening on. > >Please test this revision in your environments as well. > > Two "hook" and three "string" tests fail with 8.7 because of (I > think) how it reports the name of namespaces ensemble commands. > Everything else is fine with both 8.6 and 8.7. This is FreeBSD > 12.0-RELEASE-p9 amd64. Thanks. Looking at the results it certainly looks to be a core change in the reporting of ensembles (full command getting reported now). I guess I should add 8.7 into my lineup as well, despite being alpha still, I believe. That said, given the alpha-ness of 8.7 I am willing to let these issues slide. > ---- string-token-shell-1.0 start > ==== string-token-shell-1.0 string token shell, wrong#args, not > ---- Result was: > wrong # args: should be > "::string::token::shell ?-indices? ?-partial? ?--? text" > ---- Result should have been (exact matching): > wrong # args: should be > "shell ?-indices? ?-partial? ?--? text" ==== string-token-shell-1.0 > FAILED -- Andreas Kupries SUSE Software Canada ULC Tcl'2019, Nov 5-8, Houston, TX, USA. http://www.tcl.tk/community/tcl2019/ |