Menu
▾
▴
tcllib-devel
|
From: <ta...@jt...> - 2006-05-25 20:16:52
|
There is an error in the latest stable version of BWidget NoteBook's bindtabs function. It purports to append the page identifier to the script to be executed. Examining the source code, NoteBook makes a call to NoteBook::_get_page_name that returns the tab's name *sans* first two characters. Clearly something is amiss here. Question: If I were to modify _get_page_name, I could potentially break all sorts of programs that have depended upon this unusual behavior. Is the correct fix to deprecate bindtabs, introducing a new procedure without this behavior? -- Jason Tang / ta...@jt... / http://www.jtang.org/~tang |
|
From: Jeff H. <je...@ac...> - 2006-05-25 21:15:00
|
J. Tang wrote: > There is an error in the latest stable version of BWidget > NoteBook's bindtabs function. It purports to append the page > identifier to the script to be executed. Examining the > source code, NoteBook makes a call to > NoteBook::_get_page_name that returns the tab's name *sans* > first two characters. Clearly something is amiss here. > > Question: If I were to modify _get_page_name, I could > potentially break all sorts of programs that have depended > upon this unusual behavior. Is the correct fix to deprecate > bindtabs, introducing a new procedure without this behavior? I believe this is correct, and may relate to this old change: 2003-11-26 Jeff Hobbs <je...@Ac...> * notebook.tcl (NoteBook::bindtabs): correct tab name returned. (groth) When I do a test, I see that that the tag found is p:$realPageName, so it's appropriate to have the first 2 chars stripped. Jeff |
|
From: Damon C. <da...@tc...> - 2006-05-25 21:19:11
|
This actually was a bug. I'm not sure it's in CVS like that or not, but I don't think fixing it would break others who are expecting something wrong. I think you're better off fixing it. Damon Jeff Hobbs wrote: > J. Tang wrote: > >> There is an error in the latest stable version of BWidget >> NoteBook's bindtabs function. It purports to append the page >> identifier to the script to be executed. Examining the >> source code, NoteBook makes a call to >> NoteBook::_get_page_name that returns the tab's name *sans* >> first two characters. Clearly something is amiss here. >> >> Question: If I were to modify _get_page_name, I could >> potentially break all sorts of programs that have depended >> upon this unusual behavior. Is the correct fix to deprecate >> bindtabs, introducing a new procedure without this behavior? >> > > I believe this is correct, and may relate to this old change: > > 2003-11-26 Jeff Hobbs <je...@Ac...> > > * notebook.tcl (NoteBook::bindtabs): correct tab name returned. > (groth) > > When I do a test, I see that that the tag found is p:$realPageName, so it's > appropriate to have the first 2 chars stripped. > > Jeff > > > > ------------------------------------------------------- > All the advantages of Linux Managed Hosting--Without the Cost and Risk! > Fully trained technicians. The highest number of Red Hat certifications in > the hosting industry. Fanatical Support. Click to learn more > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > _______________________________________________ > Tcllib-devel mailing list > Tcl...@li... > https://lists.sourceforge.net/lists/listinfo/tcllib-devel > |
|
From: Jeff H. <je...@ac...> - 2006-05-25 21:23:07
|
What is the bug? I tested the bindtags operation, and it returned the "expected" behavior. Any modification would *introduce* a bug, IMO. = Please elaborate with a script. Jeff Hobbs, The Tcl Guy, http://www.ActiveState.com/=20 -----Original Message----- From: tcl...@li... [mailto:tcl...@li...] On Behalf Of Damon = Courtney This actually was a bug. I'm not sure it's in CVS like that or not, = but I don't think fixing it would break others who are expecting something = wrong. I think you're better off fixing it. Damon Jeff Hobbs wrote:=20 J. Tang wrote: =20 There is an error in the latest stable version of BWidget=20 NoteBook's bindtabs function. It purports to append the page=20 identifier to the script to be executed. Examining the=20 source code, NoteBook makes a call to=20 NoteBook::_get_page_name that returns the tab's name *sans*=20 first two characters. Clearly something is amiss here. Question: If I were to modify _get_page_name, I could=20 potentially break all sorts of programs that have depended=20 upon this unusual behavior. Is the correct fix to deprecate=20 bindtabs, introducing a new procedure without this behavior? =20 I believe this is correct, and may relate to this old change: 2003-11-26 Jeff Hobbs <mailto:je...@Ac...> <je...@Ac...> * notebook.tcl (NoteBook::bindtabs): correct tab name returned. (groth) When I do a test, I see that that the tag found is p:$realPageName, so = it's appropriate to have the first 2 chars stripped. Jeff |
|
From: Damon C. <da...@tc...> - 2006-05-25 21:27:10
|
I guess it got fixed somewhere along the way. I just test 1.7 in the latest ActiveTcl, and it works as expected. Not sure what version Jason is using. Damon Jeff Hobbs wrote: > What is the bug? I tested the bindtags operation, and it returned the > "expected" behavior. Any modification would *introduce* a bug, IMO. > Please elaborate with a script. > > Jeff Hobbs, The Tcl Guy, http://www.ActiveState.com/ > <http://www.activestate.com/> > > -----Original Message----- > *From:* tcl...@li... > [mailto:tcl...@li...] *On Behalf Of > *Damon Courtney > > This actually was a bug. I'm not sure it's in CVS like that > or not, but I don't think fixing it would break others who are > expecting something wrong. I think you're better off fixing it. > > Damon > > > Jeff Hobbs wrote: >> J. Tang wrote: >> >>> There is an error in the latest stable version of BWidget >>> NoteBook's bindtabs function. It purports to append the page >>> identifier to the script to be executed. Examining the >>> source code, NoteBook makes a call to >>> NoteBook::_get_page_name that returns the tab's name *sans* >>> first two characters. Clearly something is amiss here. >>> >>> Question: If I were to modify _get_page_name, I could >>> potentially break all sorts of programs that have depended >>> upon this unusual behavior. Is the correct fix to deprecate >>> bindtabs, introducing a new procedure without this behavior? >>> >> >> I believe this is correct, and may relate to this old change: >> >> 2003-11-26 Jeff Hobbs <je...@Ac...> >> >> * notebook.tcl (NoteBook::bindtabs): correct tab name returned. >> (groth) >> >> When I do a test, I see that that the tag found is p:$realPageName, so it's >> appropriate to have the first 2 chars stripped. >> >> Jeff > |
|
From: <ta...@jt...> - 2006-05-25 22:06:10
|
> From: Damon Courtney <da...@tc...> > Date: Thu, 25 May 2006 16:26:55 -0500 > > I guess it got fixed somewhere along the way. I just test 1.7 in > the latest ActiveTcl, and it works as expected. Not sure what version > Jason is using. Your suspicions are correct -- what I have installed is /not/ what is in CVS. My development machine, Debian/testing, has the package bwidget-1.7.0-1 and has an error in NoteBook::bindtabs. On the line that appends to script, it uses the index value of 2 instead of 1. As a test, I searched for the latest bwidget package for Fedora Core 5. The latest version found is bwidget-1.7.0-2.fc5 (http://tinyurl.com/gb4rs). This package also has the errant index value of 2 for [NoteBook::bindtabs]. -- Jason Tang / ta...@jt... / http://www.jtang.org/~tang |
|
From: Virden, L. W. <lv...@ca...> - 2006-05-26 10:54:07
|
Well, certainly 1.7.0 is what is available for download at tcllib.sf.net - and I seem to recall that many of the distribution projects expect to use code that's been "released" , rather than take chances on using the "latest" cvs version, which could have bugs introduced . --=20 <URL: http://wiki.tcl.tk/ > Even if explicitly stated to the contrary, nothing in this posting should be construed as representing my employer's opinions. <URL: mailto:lv...@gm... > <URL: http://www.purl.org/NET/lvirden/ > =20 -----Original Message----- From: tcl...@li... [mailto:tcl...@li...] On Behalf Of J. Tang Sent: Thursday, May 25, 2006 6:06 PM To: da...@tc... Cc: tcl...@li... Subject: Re: [Tcllib-devel] BWidget NoteBook bindtabs error (and RFC) > From: Damon Courtney <da...@tc...> > Date: Thu, 25 May 2006 16:26:55 -0500 > =20 > I guess it got fixed somewhere along the way. I just test 1.7 in > the latest ActiveTcl, and it works as expected. Not sure what version=20 > Jason is using. Your suspicions are correct -- what I have installed is /not/ what is in CVS. My development machine, Debian/testing, has the package bwidget-1.7.0-1 and has an error in NoteBook::bindtabs. On the line that appends to script, it uses the index value of 2 instead of 1. As a test, I searched for the latest bwidget package for Fedora Core 5. The latest version found is bwidget-1.7.0-2.fc5 (http://tinyurl.com/gb4rs). This package also has the errant index value of 2 for [NoteBook::bindtabs]. --=20 Jason Tang / ta...@jt... / http://www.jtang.org/~tang ------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D107521&bid=3D248729&dat=3D= 121642 _______________________________________________ Tcllib-devel mailing list Tcl...@li... https://lists.sourceforge.net/lists/listinfo/tcllib-devel |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X