Re: [Tcllib-devel] BWidget NoteBook bindtabs error (and RFC)

[Damon C. <da...@tc...>]

    I guess it got fixed somewhere along the way.  I just test 1.7 in 
the latest ActiveTcl, and it works as expected.  Not sure what version 
Jason is using.

Damon


Jeff Hobbs wrote:
> What is the bug?  I tested the bindtags operation, and it returned the 
> "expected" behavior.  Any modification would *introduce* a bug, IMO.  
> Please elaborate with a script.
>
>   Jeff Hobbs, The Tcl Guy, http://www.ActiveState.com/ 
> <http://www.activestate.com/>
>
>     -----Original Message-----
>     *From:* tcl...@li...
>     [mailto:tcl...@li...] *On Behalf Of
>     *Damon Courtney
>
>         This actually was a bug.  I'm not sure it's in CVS like that
>     or not, but I don't think fixing it would break others who are
>     expecting something wrong.  I think you're better off fixing it.
>
>     Damon
>
>
>     Jeff Hobbs wrote:
>>     J. Tang wrote:
>>       
>>>     There is an error in the latest stable version of BWidget 
>>>     NoteBook's bindtabs function.  It purports to append the page 
>>>     identifier to the script to be executed.  Examining the 
>>>     source code, NoteBook makes a call to 
>>>     NoteBook::_get_page_name that returns the tab's name *sans* 
>>>     first two characters.  Clearly something is amiss here.
>>>
>>>     Question: If I were to modify _get_page_name, I could 
>>>     potentially break all sorts of programs that have depended 
>>>     upon this unusual behavior.  Is the correct fix to deprecate 
>>>     bindtabs, introducing a new procedure without this behavior?
>>>         
>>
>>     I believe this is correct, and may relate to this old change:
>>
>>     2003-11-26  Jeff Hobbs  <je...@Ac...>
>>
>>     	* notebook.tcl (NoteBook::bindtabs): correct tab name returned.
>>     (groth)
>>
>>     When I do a test, I see that that the tag found is p:$realPageName, so it's
>>     appropriate to have the first 2 chars stripped.
>>
>>     Jeff
>