From: Jeff H. <je...@ac...> - 2006-05-25 21:23:07
|
What is the bug? I tested the bindtags operation, and it returned the "expected" behavior. Any modification would *introduce* a bug, IMO. = Please elaborate with a script. Jeff Hobbs, The Tcl Guy, http://www.ActiveState.com/=20 -----Original Message----- From: tcl...@li... [mailto:tcl...@li...] On Behalf Of Damon = Courtney This actually was a bug. I'm not sure it's in CVS like that or not, = but I don't think fixing it would break others who are expecting something = wrong. I think you're better off fixing it. Damon Jeff Hobbs wrote:=20 J. Tang wrote: =20 There is an error in the latest stable version of BWidget=20 NoteBook's bindtabs function. It purports to append the page=20 identifier to the script to be executed. Examining the=20 source code, NoteBook makes a call to=20 NoteBook::_get_page_name that returns the tab's name *sans*=20 first two characters. Clearly something is amiss here. Question: If I were to modify _get_page_name, I could=20 potentially break all sorts of programs that have depended=20 upon this unusual behavior. Is the correct fix to deprecate=20 bindtabs, introducing a new procedure without this behavior? =20 I believe this is correct, and may relate to this old change: 2003-11-26 Jeff Hobbs <mailto:je...@Ac...> <je...@Ac...> * notebook.tcl (NoteBook::bindtabs): correct tab name returned. (groth) When I do a test, I see that that the tag found is p:$realPageName, so = it's appropriate to have the first 2 chars stripped. Jeff |