[Tcllib-bugs] [Tcllib] (emiliano) tkt (New): typo in math::combinatorics::permutations

[<no...@tc...>]

Automated mail by fx, on behalf of no...@tc...

Ticket Change [58e772a8908efe2309dc8a3ec0e628575d114dd9d10dda2810aa305aea5e15f6]
  [typo in math::combinatorics::permutations]
  By      emiliano
  For     Tcllib
  On      2025-01-30T01:48:26.638
  Details https://core.tcl-lang.org/tcllib/tinfo?name=58e772a8908efe2309dc8a3ec0e628575d114dd9d10dda2810aa305aea5e15f6
  Ticket  https://core.tcl-lang.org/tcllib/tktview/e99fe133e61b7868a4c2f7d9c2e6cb2f164a7246

Changed Fields
  assignee:        nobody
  closer:          nobody
  comment:         On file modules/math/combinatoricsExt.tcl , line 53

                   https://core.tcl-lang.org/tcllib/file?ci=tip&name=modules/math/combina
                   toricsExt.tcl&ln=53

                   reads

                   set newfactorial [lindex $$factorial end]

                   with two $$ on the "factorial" variable. While the code works because
                   the element 0 (which becomes "$1" instead of "1") is never returned,
                   this code path causes the list of cached factorials shimmer to a
                   string and again to a list on every invocation. The obvious solution
                   is to remove the extra "$".
  foundin:         trunk
  is_private:      0
  login:           emiliano
  priority:        5 Medium
  private_contact: 885ae311f5fce05c2a8d9c31d2d2a1b5638ca9df
  resolution:      None
  severity:        Minor
  status:          Open
  submitter:       emiliano
  subsystem:       math
  title:           typo in math::combinatorics::permutations
  type:            Bug

------------------------------------------------------------
See Tcl/Tk development @ http://core.tcl-lang.org/
------------------------------------------------------------