Re: [Tcllib-devel] would it be possible to extend crc16 in tcllib

[Arjen M. <Arj...@de...>]

HI Andreas, Markus,

Great, that has already been taken care of then 😊.

Regards,

Arjen

-----Original Message-----
From: Andreas Kupries <and...@gm...>
Sent: Wednesday, November 8, 2023 9:42 PM
To: Arjen Markus <Arj...@de...>; mar...@we...; tcl...@li...
Subject: Re: [Tcllib-devel] would it be possible to extend crc16 in tcllib

Caution: This message was sent from outside of Deltares. Please do not click links or open attachments unless you recognize the source of this email and know the content is safe. Please report all suspicious emails to "Ser...@de..." as an attachment.


Hi all.

> Hello Markus,

> We can certainly add this to the Tcl library, but what is lacking is a
> description and test cases. Could you supply these too? (I am not an
> expert on these CRC methods, so I am utterly unable to judge the code or to help out with the specific test cases ????).

I took a look and tests and docs were relatively easy and trivial to add.
I have now done so, and committed the result (pushed also).
The new code is has version 1.1.5.
See:

        https://core.tcl-lang.org/tcllib/info/a061c12325631216

Tempted to make a 1.2 which requires Tcl 8.6 and then looks for possible code simplifications.

Beyond that, definitely agreed with Arjen that patches should come with tests and docs.

> Hi,
> i use a rs485 converter to read serial data from a solar inverters and a electricity meter. crc16 is used to check the transmission.
> these methods are currently available in tcllib:

> however, other crc codes are used. would it be possible to extend crc16 with these codes in tcllib 1.21 and above?
> #   KERMIT:    0x2189
> #   MODBUS:    0x4B37
> #   MCRF4XX:   0x6F91
> #   GENIBUS:   0xD64E
> #   X.25:      0x906E
> #   SDLC:      0x906E
> #   USB:       0xB4C8
> #   BUYPASS:   0xFEE8
> #   UMTS:      0xFEE8
> #   GSM:       0xCE3C
> #   MAXIM:     0x44C2
> #   CMS:       0xAEE7

--
Happy Tcling,
        Andreas Kupries <and...@gm...>
                        <https://core.tcl-lang.org/akupries/>
                        <https://akupries.tclers.tk/>
        Developer @     SUSE Software Solutions Germany GmbH
-------------------------------------------------------------------------------




DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.