Re: [Tcllib-devel] proposal: backwards-incompatible improvements to picoirc

[Leonid B. <cur...@di...>]

March 3, 2021 7:23 PM, "Andreas Kupries" <and...@gm...> wrote:

>> Sorry, I didn't check CC header in web client.
>> 
>> March 3, 2021 5:44 PM, "Gerald Lester" <ger...@gm...> wrote:
>> 
>> What needs to be done to make it "complete"?
>> 
>> Maybe do that and bump to 1.0???
>> 
>> Alright, it's good enough the way it is, I'll bump major version number after I'm done.
> 
> @gerald ... Current version is 0.5.2, so no need to increment major
> for big api changes.
> 
> (version < 1.0 ==> No official/proper release yet, API in flux).
> 
> @leonid That said, if you believe that your changes make the package
> good enough for a proper 1.0 release, go for that.
> 

Yes, I think after these changes all this API needs are internal tests and bugfixes.

Also I've noticed that picoirc internally hides ijchain and wubchain nicks (see line 172), I think this creates confusion because it's not clear who sent a message when nicks in IRC and external chat collide.

Are you ok with me removing that behavior?

>> I hope this won't create conflict with Andreas.
> 
> Nope.
> 
>> On 3/3/21 11:35 AM, Leonid Bobrov wrote:
>> 
>> March 3, 2021 5:20 PM, "Gerald Lester" <ger...@gm...> wrote:
>> 
>> On 3/3/21 7:33 AM, curiousbeaver--- via Tcllib-devel wrote:
>> 
>> Hi everyone!
>> 
>> I develop and use my own IRC client https://hub.darcs.net/gay/chatik and I contribute bugfixes to
>> picoirc and chatwidget, I've also improved picoirc by adding TLS support there.
>> 
>> Here's the list of what I'm planning to do:
>> * make picoirc handle MODE messages from server by sending them to callback as traffic mode, this
>> breaks compatibility because my IRC client expects them in callback as system;
>> * make picoirc handle NOTICE messages from server by sending them to callback as traffic notice,
>> this breaks compatibility because someone's IRC client might expect them in callback as system;
>> * make [spliturl] private because there is no reason to use it outside of picoirc;
>> * remove [send] and make [post] behave like [send] when channel is {}.
>> 
>> Let me know if you have any objections.
>> Sounds reasonable as long as you roll the major version number of the package.
>> 
>> Andreas Kupries thinks I should increase minor version number because this is v0 package (which
>> means incomplete?), so I'm not sure which one should be increased.
> 
> --
> Happy Tcling,
> Andreas Kupries <and...@gm...>
> <https://core.tcl-lang.org/akupries>
> <https://akupries.tclers.tk>
> Developer @ SUSE Software Solutions Germany GmbH
> -------------------------------------------------------------------------------