Re: [Tcllib-devel] [TCLCORE] Tcllib 1.16 RC work, planned release next Friday, looking for test and feeback

[Pietro C. <ga...@ga...>]

On 2014-Feb-03, 10:18, Andreas Kupries wrote:
> On Mon, Feb 3, 2014 at 4:53 AM, Pietro Cerutti <ga...@ga...> wrote:
> > On 2014-Jan-31, 10:19, Andreas Kupries wrote:
> > Hello Andreas,
> >
> > first off, thanks for the effort in getting 1.6 ready!
> 
> You are welcome
> 
> > I have a failing test on FreeBSD:
> >
> > ==== set-tcl-1.0 nothing FAILED
> > ==== Contents of test case:
> >
> >     catch {setop} msg
> >     set msg
> >
> > ---- Result was:
> > wrong # args: should be "::struct::set cmd ?arg ...?"
> > ---- Result should have been (exact matching):
> > wrong # args: should be "setop cmd ?arg ...?"
> > ==== set-tcl-1.0 FAILED
> >
> > I think it's because of the interp alias at line 42 of sets.test:
> >
> > interp alias {} setop {} ::struct::set
> >
> > It works fine with both 8.5 and 8.4.
> 
> By implication, this failure was with 8.6 then ?

Oh yes, sorry, I rephrased a couple of times the email and the
indication that the test failure was with 8.6 got lost.

> I semi-remember that some code regarding alias handling was changed,
> possibly the generation of the error message. I.e. replacing the alias
> command in the error with the alias' target, i.e. the actual command
> getting run.

Yes, I think this is exactly the cause.

While at it, I had the time to test a few more new features, such as
websockets. The example reported in the documentation page at [1] works
with 8.5 but fails with 8.6.

> tclsh8.5 ws.tcl
[Tue Feb 04 09:31:52 CET 2014] [websocket] [debug] 'Removed socket sock5 from internal state of http library'
[Tue Feb 04 09:31:52 CET 2014] [websocket] [debug] 'sock5 has been registered as a client WebSocket'
Connected on sock5
client from sn2000.medacta.locale to ec2-174-129-224-73.compute-1.amazonaws.com
[Tue Feb 04 09:31:52 CET 2014] [websocket] [debug] 'Sent 19 bytes long text final fragment to server'
[Tue Feb 04 09:31:52 CET 2014] [websocket] [debug] 'Received 19 long text final fragment from server'
RECEIVED: Testing, testing...

> tclsh8.6 ws.tcl
[Tue Feb 04 09:32:16 CET 2014] [websocket] [debug] 'Removed socket sock801ee6a90 from internal state of http library'
[Tue Feb 04 09:32:16 CET 2014] [websocket] [debug] 'sock801ee6a90 has been registered as a client WebSocket'
Connected on sock801ee6a90
[Tue Feb 04 09:32:16 CET 2014] [websocket] [debug] 'Received 0 long close final fragment from server'
[Tue Feb 04 09:32:16 CET 2014] [websocket] [warn] 'Cannot send along WS sock801ee6a90, not connected'
[Tue Feb 04 09:32:16 CET 2014] [websocket] [info] 'Closing web socket: 1000 (Normal closure)'
[Tue Feb 04 09:32:16 CET 2014] [websocket] [warn] 'sock801ee6a90 is not a WebSocket connection anymore'
sock801ee6a90 is not a WebSocket
    while executing
"::websocket::conninfo $sock type"
    (procedure "test" line 2)
    invoked from within
"test sock801ee6a90"
    ("after" script)



[1] https://core.tcl.tk/tcllib/doc/trunk/embedded/www/tcllib/files/modules/websocket/websocket.html


-- 
Pietro Cerutti
ga...@ga...

PGP Public Key:
http://gahr.ch/pgp