[Tcllib-devel] Review - Re: Michael Antoniewski committed [45]: Tests, descriptions and some other improvements

[Andreas K. <and...@ac...>]

gra...@al... wrote:
> 
> Tests, descriptions and some other improvements
> Commit from user: Michael Antoniewski
> 
> More details 
> <http://code.assembla.com/graphmanipulations/subversion/changesets/45>

I found that a number of the new tests have resource leaks. I.e. they create a 
temp graph in result, and then overwrite the variable, losing the reference, 
and not destroying the temp graph.

I saw this in
	kcenter.test
	mdst.test
	bfs.test

Example of the problem (taken from kcenter):

	set result [lsort -dict [$result arcs]]

	result hold the name of the temp graph, then overwrites it with the
	list of arcs, and now we cannot destroy the tmep graph any longer.
	Should use a different variable, i.e. not 'result', for to hold
	the temp graph, then we can destroy it as part of the test case cleanup
	code.

Overall looking good however.

Andreas.