Re: [Tcllib-devel] Graph Manip

[Andreas K. <and...@ac...>]

Andreas Kupries wrote:
> Michał Antoniewski wrote:
>> Another update is available at assembla.

I have a question regarding your use of SVN.

I am noticing that you are creating a lot of verX directories,
with X in 1, 2, 3, ...

This feels odd, given that SVN is automatically handling the revisioning of 
files for you when you are commiting changes.

Can you explain the rationale/reason behind that to me ?

>> What's new:
>> - new test cases ( regarding your treatise about tests, I updated some 
>> missing cases )
>> - some of results ( for test cases ) moved into procedures - the bottom 
>> of XOpsSetup file, I wanted to stick with organisation given by XSetup 
>> file for "setup files".
>> - updated description of algorithms and code comments - graphops.tcl.
>> - corrected errors you noticed in last version.
> 
> Ok. Will review sometime today.

Looks good.

>>    -  However, I came up with option -filter ( it is used by other 
>> struct::graph procedures, for limiting the set of returned values e.g. 
>> nodes - this name will assure some logical conformity ), and $param is 
>> now $displaymode.
> 
> Hm. No comments regarding this yet, will have a look at the code first.

Ok, it is option -filter now, without any arguments. I though that you had 
added something which would take an argument, like the graph nodes/arcs methods 
and was confused how that would work.

It feels better than before, but not completely right. It is however a minor 
thing which we can change anytime later, and not worth losing time over now.
(We are getting into bikeshed territory 
(http://en.wikipedia.org/wiki/Color_of_the_bikeshed) I believe)

Andreas