tcljava-dev

[tcljava-dev] [PATCH] Fix for Problem with loading package inside namespace

[Shawn B. <sh...@qc...>]

I took a look at the Tcl sources and Jacl sources.
The Tcl code invokes Tcl_GlobalEval to evaluate package
scripts. The Jacl code invokes Interp.eval with the GLOBAL_ONLY
flag. However this flag is essentially ignored down inside of eval/eval2
To get the same type of functionality as Tcl_GlobalEval, the
EVAL_GLOBAL flag must be set. This fixes the problem.

The one-line patch is attached.

Shawn Boyce wrote:

> I ran into this problem when loading the java package
> inside of a namespace. The java package procedures are
> only visible inside of the namespace. e.g. java::call is
> not visible globally. It must be prefixed by the namespace name.
>
> This does not match the Tcl 8.3 behaviour.
>
> Attached is a test script (and sample package) which exhibits the 
> problem.
>

-- 
Shawn Boyce
QCOM, Inc.   
Quality Software is Our Business
http://www.qcominc.com

Re: [tcljava-dev] [PATCH] Fix for Problem with loading package inside namespace

[Mo D. <su...@ba...>]

On Tue, 09 Apr 2002 10:59:13 -0400
Shawn Boyce <sh...@qc...> wrote:

> I took a look at the Tcl sources and Jacl sources.
> The Tcl code invokes Tcl_GlobalEval to evaluate package
> scripts. The Jacl code invokes Interp.eval with the GLOBAL_ONLY
> flag. However this flag is essentially ignored down inside of eval/eval2
> To get the same type of functionality as Tcl_GlobalEval, the
> EVAL_GLOBAL flag must be set. This fixes the problem.
> 
> The one-line patch is attached.

Ugh, you found quite a nasty bug there. I poked around and found a
couple of additional places where this error shows up. I just checked
in a patch that fixes them all. Thanks for looking into this.

Mo

Re: [tcljava-dev] [PATCH] Fix for Problem with loading package inside namespace

[Shawn B. <sh...@bo...>]

Great.

You can close the bugs I opened
#541613 and 541612


On Fri, 2002-04-12 at 09:07, Mo DeJong wrote:
> On Tue, 09 Apr 2002 10:59:13 -0400
> Shawn Boyce <sh...@qc...> wrote:
> 
> > I took a look at the Tcl sources and Jacl sources.
> > The Tcl code invokes Tcl_GlobalEval to evaluate package
> > scripts. The Jacl code invokes Interp.eval with the GLOBAL_ONLY
> > flag. However this flag is essentially ignored down inside of eval/eval2
> > To get the same type of functionality as Tcl_GlobalEval, the
> > EVAL_GLOBAL flag must be set. This fixes the problem.
> > 
> > The one-line patch is attached.
> 
> Ugh, you found quite a nasty bug there. I poked around and found a
> couple of additional places where this error shows up. I just checked
> in a patch that fixes them all. Thanks for looking into this.
> 
> Mo
> 
> _______________________________________________
> tcljava-dev mailing list
> tcl...@li...
> https://lists.sourceforge.net/lists/listinfo/tcljava-dev