Re: [tcljava-dev] propoed patch for bug exec on MacOSX

[Shawn B. <sh...@bo...>]

Congratulations on your first patch. It appears
that changes were easier than I thought.

isMac() and isUnix() are used in many places in the
code. From a quick look at the jacl code, it appears treating
OSX Macs as UNIX boxes should be ok. Since you are the major
OSX user at the moment, please try out the file and exec commands
(which are the most OS dependent).

I would also add a comment to the isMac() method
to indicate that it only applies to OS9 and earlier.
OS X and later will be treated as UNIX systems.


On Tue, 2002-05-07 at 18:22, Maurice Diamantini wrote:
> 
> As suggested by Mo (on the user tcljava list), I've tried
> to make the first patch in my life!
> 
> This patch allowed me to compile jacl and use
> the "exec" command.
> (for Shawn Boyce : I'm not sure this patch is well
> formated )
> I generate it with
> 	cvs diff -u src/jacl/tcl/lang/Util.java
> But I havn'tried to applay it (and I don't know hot to do
> for the moment)
> 
> 
> 
> ###########################
> 2002-05-07  Maurice Diamantini (or the maintainer ???) <di...@en...>
> 
> 	* src/jacl/tcl/lang/Util.java
> 	Util.isMac() now return false if os is MacOS-X (which is an unix)
> 	so that jacl commands like "exec" works
> 
> ###########################
> 
> cvs diff -u src/jacl/tcl/lang/Util.java
> 
> Index: src/jacl/tcl/lang/Util.java
> ===================================================================
> RCS file: /cvsroot/tcljava/tcljava/src/jacl/tcl/lang/Util.java,v
> retrieving revision 1.9
> diff -u -r1.9 Util.java
> --- src/jacl/tcl/lang/Util.java 12 May 2001 23:13:16 -0000      1.9
> +++ src/jacl/tcl/lang/Util.java 7 May 2002 22:01:32 -0000
> @@ -1595,8 +1595,10 @@
> 
>   final static boolean
>   isMac() {
> -    String os = System.getProperty("os.name");
> -    if (os.toLowerCase().startsWith("mac")) {
> +    String os = System.getProperty("os.name").toLowerCase();
> +    String version = System.getProperty("os.version");
> +    // if os is "Mac OS X" one should return false as for unix
> +    if ( os.startsWith("mac") && !os.endsWith("x") ) {
>          return true;
>       }
>       return false;
> 
> ####################################
> 
> 
> _______________________________________________________________
> 
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: ban...@so...
> _______________________________________________
> tcljava-dev mailing list
> tcl...@li...
> https://lists.sourceforge.net/lists/listinfo/tcljava-dev