RE: [tcljava-dev] Channel drivers and fconfigure command for Jacl

[Johnson, B. A <bru...@me...>]

Hi Mo,

I've been looking over the file code this weekend and thinking about the
changes you suggested.  I'm not sure it would be so easy now to simply
extend a Reader and Writer class  to incorporate the Tcl style stuff.  The
problem comes because Tcl IO requires random access to the files with both
read and write access.  To properly manage a buffer for both the reading and
writing in a way that will pass all the tcl io tests that my current
implementation passes would be difficult.  Since you've already added some
concrete methods to the Channel class, and the end-of-line stuff will only
likely be used with Channels, I'm not sure of the problem with having it as
a concrete implementation in Channel.  At this point it seems easier to
merge the socket stuff and your other changes into my file changes, which
I'm happy to do.  This may involve moving some stuff between my FileChannel
and Channel implementation, in some way to best share it as necessary with
the socket requirements.  I'm certainly open to suggestions as well, part of
the problem is that I don't want to have to deal with breaking to many
things that pass the io tests now, because I'm short of time to fix them.

Bruce


-----Original Message-----
From: Mo DeJong [mailto:su...@ba...]
Sent: Friday, November 23, 2001 2:55 PM
To: tcljava-dev
Subject: [tcljava-dev] Channel drivers and fconfigure command for Jacl


On Fri, 23 Nov 2001 19:56:41 -0500
"Johnson, Bruce A" <bru...@me...> wrote:

> Mo,
> 
> I've uploaded a tar file (modfiles.tar.gz) of the changed java source
files
> and a text file listing the files and summarizing the changes.  You can
find
> them both by 
> ftp'ing to www.nmrview.com and looking in /pub/tcljava.
> 
> cheers,

This looks great, but I am noticing a couple of problems right off the bat.
I just finished up a bunch of work to refactor all of the subclasses of
Channel
as part of adding the socket command. The current CVS has these changes.
Trouble is, your changes are kind of like the ones I made only different.
This means we will have to work out how to merge the two in the best way
we can. Could you take a look at the current CVS and your code and let
me know what you think?

I also noticed that you also turned some methods in the Channel class
into a concrete implementation instead of an abstract method. One thing I
am not sure I like is the way you do the EOL conversion and buffering inside
the Channel class. Don't you think it would be easier to create a pair of
classes that extend Reader and Writer and provide Tcl style buffering,
EOL conversion, and Tcl style encoding names (if needed).

let me know what you think
Mo




_______________________________________________
tcljava-dev mailing list
tcl...@li...
https://lists.sourceforge.net/lists/listinfo/tcljava-dev