[tcljava-dev] Channel drivers and fconfigure command for Jacl

[Mo D. <su...@ba...>]

On Fri, 23 Nov 2001 19:56:41 -0500
"Johnson, Bruce A" <bru...@me...> wrote:

> Mo,
> 
> I've uploaded a tar file (modfiles.tar.gz) of the changed java source files
> and a text file listing the files and summarizing the changes.  You can find
> them both by 
> ftp'ing to www.nmrview.com and looking in /pub/tcljava.
> 
> cheers,

This looks great, but I am noticing a couple of problems right off the bat.
I just finished up a bunch of work to refactor all of the subclasses of Channel
as part of adding the socket command. The current CVS has these changes.
Trouble is, your changes are kind of like the ones I made only different.
This means we will have to work out how to merge the two in the best way
we can. Could you take a look at the current CVS and your code and let
me know what you think?

I also noticed that you also turned some methods in the Channel class
into a concrete implementation instead of an abstract method. One thing I
am not sure I like is the way you do the EOL conversion and buffering inside
the Channel class. Don't you think it would be easier to create a pair of
classes that extend Reader and Writer and provide Tcl style buffering,
EOL conversion, and Tcl style encoding names (if needed).

let me know what you think
Mo