Re: [tcljava-dev] aolserver support patch

[Mo D. <md...@cy...>]

On Sat, 6 Jan 2001, Dan Wickstrom wrote:

> Mo,
> 
> I would like to apply the attached patch to the tclblend source to add
> support for aolserver.  Let me know if it's ok.
> 
> -Dan

In looking at this patch, I am a bit bothered by the
fact that you moved the ThreadSpecificData struct
from javaCmd.c to java.h. I was under the impression
that Tcl needed to have this struct defined only
in the .c file and not the .h file. This is so
that it can be defined as different ways for
different files. It seems you worked around
this merging the TSD data, but I am not
sure that it really "right". Will it
break some other code that might need
to #include java.h?

I am not sure exactly what you want to do
with the data ptr returned by JavaGetDataKey,
can it be cast to a void * so that code
outside of javaCmd.c does not need to
know the type of the TSD ptr?

Also, why do you not call Interp.dispose()
when compiled with -DWITH_AOLSERVER ?
A comment about why that bit was
compiled out might be good. I assume
it has something to do with this
do_cleanup flag. I am a little
fuzzy on what that is needed for.

Also, why did you change the calls
in JavaInterpDeleted? Does adding
that tid variable in
Java_tcl_lang_Notifier_init and
Java_tcl_lang_Notifier_alertNotifier
get rid of a compiler warning or
something?

Mo DeJong
Red Hat Inc