Re: [tcljava-dev] How to submit a code change (was: Patch for bug 121678)

[Christian K. <chr...@so...>]

Hello,

Mo DeJong wrote:
> > This way you would have the following:
> >   % read stdout
> >   channel "file1" wasn't opened for reading
> I don't get it, this already seems to work in Jacl.
> jacl from CVS % read stdout
> channel "stdout" wasn't opened for reading
[...]
> Does this only apply if you use channel name like "file1"?

This applies to all channels which have more than one name.
I believe this are just the standard channels.

Jacl from CVS doesn't have two names for the standard channels.
This is the incompatibiltity to Tcl which I complained about
in my bug report. Therefore the error messages in the Channel
class can give the (one and only) correct name.

My quoting was from a Jacl where the standard channels have
two names, but the error messages are still produced by the
Channel class. If the standard channels have more than one
name, you should have the user specified name available to
generate a nice error message; the Channel class don't have
this name available, thus the calling class should already
throw the error.

> Perhaps we need to move the ioCmd.test over into
> Jacl.

When we use all Tcl tests for Jacl (and I hope this moment
is not too far away in the future), this test will be run
by Jacl anyway :-)

> My point was, I would like to get some regression test
> for this stuff into Jacl. It seems like ioCmd.test
> is what we want.

I don't think that my patch is tested by ioCmd.test:
there are some channel names like file107 used, but only
to generate an error message about an unknown channel name. 

The fact that the first three channel numbers are reserved
for the standard channels really seems to be untested.

Nevertheless I think Jacl should behave the same as Tcl
in this point (especially as it is so easy to achieve *and*
as the incompatibility was introduced only recently as a
side effect of the interp patch).

Greetings, Krischan
-- 
Christian Krone, SQL Datenbanksysteme GmbH
Mail mailto:chr...@so...