Re: [tcljava-dev] How to submit a code change (was: Patch for bug 121678)
Brought to you by:
mdejong
From: Mo D. <md...@cy...> - 2000-11-08 10:25:31
|
On Wed, 8 Nov 2000 tcl...@li... wrote: > Hello, > > Mo wrote: > > What we will do is post the patches to the dev list one at > > a time. > Okay, I've done this with my last mail. About this patch, are there test cases from Tcl 8.3 that fail without this patch? I don't see any failures in the tests Jacl runs, so I am guessing that there must be some test failures in the newer Tcl regression test suite. Perhaps we need to add those failing tests before doing a commit of this patch. It seem like your patch does away with the StdChannel.getChanName() method. Would you not want to call setChanName(String) perhaps in the StdChannel() constructor? I guess I am just not sure what problem(s) your patch fixes. Mo DeJong Red Hat Inc |