TIP #285 perf changes

The Tool Command Language implementation

Brought to you by: andreas_kupries, apnadkarni, bgriffin, das, and 10 others

#631 TIP #285 perf changes

Milestone: TIP Implementation

Status: open

Owner: Joe Mistachkin

Labels: 45. Parsing and Eval (41)

Priority: 5

Updated: 2011-01-30

Created: 2011-01-30

Creator: Joe Mistachkin

Private: No

These changes are designed to optimize (and modularize) the TIP #285 features.

Discussion

Joe Mistachkin - 2011-01-30

TIP 285 rev2-v2

TIP285-rev2.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexandre Ferrieux - 2011-01-30

pstack sampling

sampling.tgz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexandre Ferrieux - 2011-01-30

Attaching pstack sampling results.

pid5971 is 8.6HEAD (Jan25)
pid12410 has your TIP285rev2 patch

both are from a 10-mn run over idiotloop2.tcl

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexandre Ferrieux - 2011-01-31

Timings on NRE:

23:50] ferrieux on one specific test, it is impressive:
head285.res:647968 microseconds per iteration
head285.res:646554 microseconds per iteration
head285.res:626336 microseconds per iteration
head285.res:642746 microseconds per iteration

head.res:733830 microseconds per iteration
head.res:711075 microseconds per iteration
head.res:718664 microseconds per iteration
head.res:702698 microseconds per iteration
[23:50] ferrieux first with patch, second without. 4 runs.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexandre Ferrieux - 2011-01-31

Joe's 2nd patch (ported to non-NRE)

TIP285-rev2-trunk-with-no-nre.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexandre Ferrieux - 2011-01-31

Timings on non-NRE variant.

01:28] ferrieux timing results for 285 patch on 86-without-nre:
sansnre285.res:565905 microseconds per iteration
sansnre285.res:572837 microseconds per iteration
sansnre285.res:569185 microseconds per iteration
sansnre285.res:568799 microseconds per iteration
sansnre.res:618944 microseconds per iteration
sansnre.res:619809 microseconds per iteration
sansnre.res:615293 microseconds per iteration
sansnre.res:622320 microseconds per iteration
[01:28] mistachkin ferrieux : now, it's "real fast"
[01:29] ferrieux have not computed the ratios, but yeah, that sounds orthogonal to nre

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexandre Ferrieux - 2011-01-31

Bottom line: should be confirmed with more extensive tclbench runs, but it superficially looks like Joe's patch are an absolute Good Thing, and are orthogonal to the NRE slowdown.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: