I don't like the whitespace changes (very noisy, moves the code away from the Engineering Manual style - where tabs are used, they must be 8 characters wide) and so far as I can see the only other things are header commenting changes; they're swamped by the whitespace changes so it's hard to tell.
It'd be great if we could have a re-cut of the patch with ws changes excluded. Keeping this issue open to allow for that.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Cleanup and commenting patch (compressed)
I don't like the whitespace changes (very noisy, moves the code away from the Engineering Manual style - where tabs are used, they must be 8 characters wide) and so far as I can see the only other things are header commenting changes; they're swamped by the whitespace changes so it's hard to tell.
It'd be great if we could have a re-cut of the patch with ws changes excluded. Keeping this issue open to allow for that.