Menu

#436 enable static linking when TclX is present

open-remind
7
2007-06-13
2005-08-23
Matt Newman
No

When you statically link the thread extension w/ the
TclX extension you get multiple defines - this patch
addresses this issue in a minimal impact way.

Discussion

  • Matt Newman

    Matt Newman - 2005-08-23

    cvs diff -c output

     
  • Zoran Vasiljevic

    Logged In: YES
    user_id=95086

    Thanks for the update. I will rather declare those as static
    in the tclXkeylist.c because those are only used from
    within that file.
    I will checkin the fix tomorrow in the cvs head branch.

     
  • Zoran Vasiljevic

    • status: open --> closed-accepted
     
  • Zoran Vasiljevic

    Logged In: YES
    user_id=95086

    Checked into CVS head branch. Instead of the proposed patch
    I made those symbols static in the tclXkeylist.c file. This should do.

     
  • Matt Newman

    Matt Newman - 2005-08-24
    • status: closed-accepted --> closed-wont-fix
     
  • Matt Newman

    Matt Newman - 2005-08-24

    Logged In: YES
    user_id=1333796

    Thanks for making this change, however unfortunately I was
    not complete in the list of public symbols that class, the
    complete list - verified by using NM on the resultant objects
    is:

    #define tclXWrongArgs thread_tclXWrongArgs
    #define TclX_WrongArgs thread_TclX_WrongArgs
    #define TclX_AppendObjResult
    thread_TclX_AppendObjResult
    #define TclX_IsNullObj thread_TclX_IsNullObj
    #define TclX_KeyedListDelete thread_TclX_KeyedListDelete
    #define TclX_KeyedListGet thread_TclX_KeyedListGet
    #define TclX_KeyedListGetKeys
    thread_TclX_KeyedListGetKeys
    #define TclX_KeyedListInit thread_TclX_KeyedListInit
    #define TclX_KeyedListSet thread_TclX_KeyedListSet
    #define TclX_NewKeyedListObj
    thread_TclX_NewKeyedListObj

     
  • Zoran Vasiljevic

    Logged In: YES
    user_id=95086

    aha... ok. lets do those as well...

     
  • Zoran Vasiljevic

    • status: closed-wont-fix --> open-remind
     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-08-24

    Logged In: YES
    user_id=72656

    I don't know when tclXkeylist.c was forked, but I updated
    the TclX version with some mods that significantly improve
    performance on large keylists. You might also consider
    those when making changes.

     
  • Zoran Vasiljevic

    Logged In: YES
    user_id=95086

    I took pieces out the TclX for about 2 years ago. I will look
    into your changes and sync them in. Thanks for the hint.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2007-06-13
    • priority: 5 --> 7
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.