Menu
▾
▴
tcl-core
|
From: Donald G P. <don...@ni...> - 2017-12-21 20:08:15
|
On 12/21/2017 02:46 PM, Donald G Porter wrote: > On 12/21/2017 02:14 PM, François Vogel wrote: >> Can you check that you have an image named (iDOT.png) in the same >> tests folder named "tests" that contains the imgPNG.test file? >> >> If the image is missing, that's the cause. > > It is; working on the fix.... > Repaired Tk 8.6.8 RCs now available. -- | Don Porter Applied and Computational Mathematics Division | | don...@ni... Information Technology Laboratory | | http://math.nist.gov/~DPorter/ NIST | |______________________________________________________________________| |
|
From: Jan N. <jan...@gm...> - 2017-12-22 11:09:31
|
2017-12-21 21:07 GMT+01:00 Donald G Porter:
> Repaired Tk 8.6.8 RCs now available.
One more -- .... tiny .... -- thing: In Tk, the files rules-ext.vc
and win/targets.vc were
committed with lf line-ending, while for MSVC it is common to use crlf
for those. I
don't think it really matters, but it's anyway corrected here:
<http://core.tcl.tk/tk/info/9ea691e69d4f185c>
Thanks, Don, for all the work! I think the release is good to go.
Regards,
Jan Nijtmans
|
|
From: Francois V. <fvo...@fr...> - 2017-12-21 21:35:05
|
François Vogel a écrit le 21/12/2017 à 20:14 : > Le 21/12/2017 16:40, Harald Oehlmann a écrit : > >> New failures: >> textTag-18.1 > > Surprising. > > Are you sure this fails repeatably (an event is missing, did you > fiddle with the computer while the tests were running?) ? > > Are you sure it didn't fail with the previous release? Too bad, not easy to check. Looks like you didn't update the wiki page for the recent releases as you did in the past: http://wiki.tcl.tk/37529 However Tk 8.6.4 passed 100% OK for you (Windows Vista Pro 32 bit GER, MSVC6++). Current Tk core-8-6-branch passes 100% OK for me (Win Vista 64 bits, MSVC++ 2008 Express). Francois |
|
From: <apn...@ya...> - 2017-12-22 01:36:50
|
Sigh. After moving to my new laptop, I build with Visual Studio 2017 which has no problems with the inline construct unlike Visual C++ 6 (which is what I suspect Harald was using). I'll install that compiler version (assuming it even installs on Win 10!) and recheck the latest release candidates. Adding to PRJ_DEFINES should be fine, although personally I prefer such defines to be in header files. That probably flies against the autoconf system of figuring out appropriate flags and defining them on the command line. For future releases, we might consider adding it to rules.vc itself so it applies to all extensions. Apologies for the churn /Ashok > -----Original Message----- > From: Donald G Porter [mailto:don...@ni...] > Sent: Thursday, December 21, 2017 11:39 PM > To: tcl...@li... > Subject: Re: [TCLCORE] Tcl / Tk 8.6.8 Release Candidates > > > A search through this checkin > > http://core.tcl.tk/tdbcodbc/info/30d9cacca17c347f > > makes clear that the TIP 477 work resulted in the loss of a > > -Dinline=__inline > > Restoring it in PRJ_DEFINES makes as much sense to me as anything, and has the > benefit of being tested. > > I will make that change. > > If there's a better approach we should use instead, we can move to it in the next > release. > > DGP > > On 12/21/2017 12:59 PM, Harald Oehlmann wrote: > > Sergey, > > thank you for the message. > > > > I have found: > > PRJ_DEFINES = -DTCL_TOMMATH -DMP_PREC=4 -Dinline=__inline - > DHAVE_ZLIB=1 > > -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE in line > 356 of > > win/makefile.vc > > > > if I insert: > > PRJ_DEFINES = -Dinline=__inline > > as line 73 of pkgs/tdbcodbc1.0.6/win/Makefile.vc > > > > all compiles fine. > > > > So, this might be a good patch... > > > > Unfortunately, it is night time in India, so Ashok may only comment in > > some hours... > > > > Thank you, > > Harald > > > > > > > > Am 21.12.2017 um 18:34 schrieb Dipl. Ing. Sergey G. Brester: > >> Hi Harald, > >> > >> in VS "inline" is normally for C++ only, for C it can be defined like: > >> > >> nmake -nologo -f makefile.vc TCLDIR=%TCLDIR% OPTS=... > >> OPTDEFINES="*-Dinline=__inline*" > >> > >> No idea which parameter exactly can be used to extend options from > >> command-line by tdbcodbc (OPTDEFINES, ADDOPTDEFINES, OPTIMIZATIONS, > etc.)... > >> Just take a look in rules.vc resp. makefile.vc for it... > >> > >> Regards, > >> Sergey. > >> > >> Am 21.12.2017 18:16, schrieb Harald Oehlmann: > >> > >>> Dear folks, > >>> > >>> I think I have overlooked an issue. > >>> > >>> Here is a compilation error in tdbcodbc.c > >>> > >>> tdbcodbc.c > >>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1009) : > >>> error C2054: expected '(' to follow 'inline' > >>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) : > >>> error C2082: redefinition of formal parameter 'LookupOdbcType' > >>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) : > >>> error C2143: syntax error : missing ';' before '{' > >>> > >>> This is MSVC 6++ win32 compilation. There is normally a macro which > >>> uses "_inline", as the inline keyword does not exist on MSVC6. > >>> > >>> Thank you, > >>> Harald > >>> > >>> > >>> Am 21.12.2017 um 16:40 schrieb Harald Oehlmann: > >>>> Dear Donald, big christmas present to the community ! Now it > >>>> compiles well. Here are the test differences compared to tcl 8.6.7, > >>>> details > >>>> below: New failures: Tk: imgPNG-3.1, textTag-18.1 Still failing: Tcl: > >>>> cmdAH-25.3.1 fCmd-9.9 fCmd-9.11 iortrans-11.1 iortrans-11.2 > >>>> winFCmd-2.8 iTCL: sfbug-254 sfbug-257 Tk: winfont-2.7 winfont-2.8 > >>>> winfont-2.9 Thank you, great ! Harald -- Details -- ==== imgPNG-3.1 > >>>> reading image with unknown ancillary chunk - bug [1c659ef0f1] > >>>> FAILED ==== Contents of test case: # the image contains an unknown > >>>> chunk iDOT # since the name of this chunk starts with a lowercase > >>>> letter, # it's an ancillary chunk that shall not trigger an error > >>>> catch {set i [image create photo -file $fileName]} ---- Result was: > >>>> 1 ---- Result should have been (exact matching): 0 ---- Test > >>>> cleanup failed: image "image19" doesn't exist ---- errorInfo(cleanup): > image "image19" > >>>> doesn't exist while executing "image delete $i" ("uplevel" body > >>>> line > >>>> 2) invoked from within "uplevel 1 $cleanup" ---- errorCode(cleanup): > >>>> TK LOOKUP IMAGE image19 ==== imgPNG-3.1 FAILED ==== textTag-18.1 > >>>> TkTextPickCurrent tag bindings FAILED ==== Contents of test case: > >>>> text .t -width 30 -height 4 -relief sunken -borderwidth 10 > >>>> -highlightthickness 10 -pady 2 pack .t .t insert end " Tag here " > >>>> TAG " no tag here" .t tag configure TAG -borderwidth 4 -relief > >>>> raised .t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"} .t > >>>> tag bind TAG <Leave> {lappend res "%x %y tag-Leave"} bind .t > >>>> <Enter> {lappend res Enter} bind .t <Leave> {lappend res Leave} set > >>>> res {} # Bindings must not trigger on the widget border, only over > >>>> # the actual tagged characters themselves. event gen .t <Motion> > >>>> -warp 1 -x 0 -y 0 ; update event gen .t <Motion> -warp 1 -x 10 -y > >>>> 10 ; update event gen .t <Motion> -warp 1 -x 25 -y 25 ; update > >>>> event gen .t <Motion> -warp > >>>> 1 -x 20 -y 20 ; update event gen .t <Motion> -warp 1 -x 10 -y 10 ; > >>>> update event gen .t <Motion> -warp 1 -x 25 -y 25 ; update return > >>>> $res > >>>> ---- Result was: {25 25 tag-Enter} {20 20 tag-Leave} {25 25 > >>>> tag-Enter} ---- Result should have been (exact matching): Enter {25 > >>>> 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter} ==== textTag-18.1 > >>>> FAILED > >>>> ------------------------------------------------------------------- > >>>> ----------- Check out the vibrant tech community on one of the > >>>> world's most engaging tech sites, Slashdot.org! > >>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm > >>>> > .link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681 > >>>> > 419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7 > C1 > >>>> > %7C636494760553682109&sdata=Bb%2BDHvUgoVmWSCQidc6%2BayUmZnHT > AbowyKz > >>>> gzanNtYY%3D&reserved=0 > >>>> _______________________________________________ Tcl-Core mailing > >>>> list Tcl...@li... > >>>> <mailto:Tcl...@li...> > >>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fli > >>>> sts.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7Cdo > >>>> > nald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82 > >>>> > fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=CHU > MRt > >>>> snIZpKdybs5u1xmnnRFRgLKY5zOM7n3%2FUBRmU%3D&reserved=0 > >>> -- > >>> ELMICRON Dr. Harald Oehlmann GmbH > >>> Koesener Str. 85 > >>> 06618 NAUMBURG - Germany > >>> Phone: +49 (0)3445 78112-0 > >>> Fax: +49 (0)3445 78112-19 > >>> https://na01.safelinks.protection.outlook.com/?url=www.Elmicron.de&d > >>> > ata=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d548 > 9 > >>> > cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C6364947605536 > 8210 > >>> > 9&sdata=hWyvhioMCUHW2KK20f78HRq19RgS1ea9sXGwma%2FdUQ0%3D&res > erved=0 > >>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww > >>> > .Elmicron.de&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e4 > >>> > 12c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7 > C636 > >>> > 494760553682109&sdata=xHokt3rwVaLuP%2F1QzUOonxB%2Bu24eH518pQTyU > qQc2t > >>> k%3D&reserved=0> > >>> German legal references: > >>> Geschaeftsfuehrer: Dr. Harald Oehlmann, Jens Oehlmann UST Nr. / VAT > >>> ID No.: DE206105272 HRB 212803 Stendal > >>> > >>> -------------------------------------------------------------------- > >>> ---------- Check out the vibrant tech community on one of the > >>> world's most engaging tech sites, Slashdot.org! > >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm. > >>> > link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d68141 > >>> > 9e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C > 1%7C > >>> > 636494760553682109&sdata=Bb%2BDHvUgoVmWSCQidc6%2BayUmZnHTAbo > wyKzgzan > >>> NtYY%3D&reserved=0 > _______________________________________________ > >>> Tcl-Core mailing list > >>> Tcl...@li... > >>> <mailto:Tcl...@li...> > >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis > >>> ts.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7Cdona > >>> > ld.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd > 8 > >>> > fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=CHUMR > tsnIZ > >>> pKdybs5u1xmnnRFRgLKY5zOM7n3%2FUBRmU%3D&reserved=0 > > > > > > > -- > | Don Porter Applied and Computational Mathematics Division | > | don...@ni... Information Technology Laboratory | > | http://math.nist.gov/~DPorter/ NIST | > |________________________________________________________________ > ______| > > ---------------------------------------------------------------------------- -- > Check out the vibrant tech community on one of the world's most engaging tech > sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Tcl-Core mailing list > Tcl...@li... > https://lists.sourceforge.net/lists/listinfo/tcl-core |
|
From: <apn...@ya...> - 2017-12-22 09:54:29
|
I verified that the tcl 8.6.8rc3 and tk rc2 distributions build, install and load when compiled with Visual C++ 6 (32-bits) and Visual Studio 2017 (64-bits). However, sqlite3 does not build with the 64-bit 2003 SDK compiler (equivalent of VC 6 for 64-bits) due to an attempt to include the non-existent intrinsic.h header. The 32-bit version does not have this problem as it does not include that header. The good news, if one can call it that, is that the sqlite shipped with 8.6.7 does not build with that compiler either. So from that point of view this is not a regression and imho should not hold up the release. Just to note, the intrinsic.h header is included by sqlite3.c itself, not an issue with Tcl or the tdbc sqlite3 adapter. /Ashok > -----Original Message----- > From: apnmbx-public--- via Tcl-Core [mailto:tcl...@li...] > Sent: Friday, December 22, 2017 7:07 AM > To: tcl...@li... > Subject: Re: [TCLCORE] Tcl / Tk 8.6.8 Release Candidates > > Sigh. After moving to my new laptop, I build with Visual Studio 2017 which has > no problems with the inline construct unlike Visual C++ 6 (which is what I suspect > Harald was using). I'll install that compiler version (assuming it even installs on > Win 10!) and recheck the latest release candidates. > > Adding to PRJ_DEFINES should be fine, although personally I prefer such defines > to be in header files. That probably flies against the autoconf system of figuring > out appropriate flags and defining them on the command line. For future > releases, we might consider adding it to rules.vc itself so it applies to all > extensions. > > Apologies for the churn > > /Ashok > > > -----Original Message----- > > From: Donald G Porter [mailto:don...@ni...] > > Sent: Thursday, December 21, 2017 11:39 PM > > To: tcl...@li... > > Subject: Re: [TCLCORE] Tcl / Tk 8.6.8 Release Candidates > > > > > > A search through this checkin > > > > http://core.tcl.tk/tdbcodbc/info/30d9cacca17c347f > > > > makes clear that the TIP 477 work resulted in the loss of a > > > > -Dinline=__inline > > > > Restoring it in PRJ_DEFINES makes as much sense to me as anything, and > > has > the > > benefit of being tested. > > > > I will make that change. > > > > If there's a better approach we should use instead, we can move to it > > in > the next > > release. > > > > DGP > > > > On 12/21/2017 12:59 PM, Harald Oehlmann wrote: > > > Sergey, > > > thank you for the message. > > > > > > I have found: > > > PRJ_DEFINES = -DTCL_TOMMATH -DMP_PREC=4 -Dinline=__inline - > > DHAVE_ZLIB=1 > > > -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE in > line > > 356 of > > > win/makefile.vc > > > > > > if I insert: > > > PRJ_DEFINES = -Dinline=__inline > > > as line 73 of pkgs/tdbcodbc1.0.6/win/Makefile.vc > > > > > > all compiles fine. > > > > > > So, this might be a good patch... > > > > > > Unfortunately, it is night time in India, so Ashok may only comment > > > in some hours... > > > > > > Thank you, > > > Harald > > > > > > > > > > > > Am 21.12.2017 um 18:34 schrieb Dipl. Ing. Sergey G. Brester: > > >> Hi Harald, > > >> > > >> in VS "inline" is normally for C++ only, for C it can be defined like: > > >> > > >> nmake -nologo -f makefile.vc TCLDIR=%TCLDIR% OPTS=... > > >> OPTDEFINES="*-Dinline=__inline*" > > >> > > >> No idea which parameter exactly can be used to extend options from > > >> command-line by tdbcodbc (OPTDEFINES, ADDOPTDEFINES, > OPTIMIZATIONS, > > etc.)... > > >> Just take a look in rules.vc resp. makefile.vc for it... > > >> > > >> Regards, > > >> Sergey. > > >> > > >> Am 21.12.2017 18:16, schrieb Harald Oehlmann: > > >> > > >>> Dear folks, > > >>> > > >>> I think I have overlooked an issue. > > >>> > > >>> Here is a compilation error in tdbcodbc.c > > >>> > > >>> tdbcodbc.c > > >>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1009) : > > >>> error C2054: expected '(' to follow 'inline' > > >>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) : > > >>> error C2082: redefinition of formal parameter 'LookupOdbcType' > > >>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) : > > >>> error C2143: syntax error : missing ';' before '{' > > >>> > > >>> This is MSVC 6++ win32 compilation. There is normally a macro > > >>> which uses "_inline", as the inline keyword does not exist on MSVC6. > > >>> > > >>> Thank you, > > >>> Harald > > >>> > > >>> > > >>> Am 21.12.2017 um 16:40 schrieb Harald Oehlmann: > > >>>> Dear Donald, big christmas present to the community ! Now it > > >>>> compiles well. Here are the test differences compared to tcl > > >>>> 8.6.7, details > > >>>> below: New failures: Tk: imgPNG-3.1, textTag-18.1 Still failing: Tcl: > > >>>> cmdAH-25.3.1 fCmd-9.9 fCmd-9.11 iortrans-11.1 iortrans-11.2 > > >>>> winFCmd-2.8 iTCL: sfbug-254 sfbug-257 Tk: winfont-2.7 winfont-2.8 > > >>>> winfont-2.9 Thank you, great ! Harald -- Details -- ==== > > >>>> imgPNG-3.1 reading image with unknown ancillary chunk - bug > > >>>> [1c659ef0f1] FAILED ==== Contents of test case: # the image > > >>>> contains an unknown chunk iDOT # since the name of this chunk > > >>>> starts with a lowercase letter, # it's an ancillary chunk that > > >>>> shall not trigger an error catch {set i [image create photo -file > $fileName]} ---- Result was: > > >>>> 1 ---- Result should have been (exact matching): 0 ---- Test > > >>>> cleanup failed: image "image19" doesn't exist ---- > errorInfo(cleanup): > > image "image19" > > >>>> doesn't exist while executing "image delete $i" ("uplevel" body > > >>>> line > > >>>> 2) invoked from within "uplevel 1 $cleanup" ---- errorCode(cleanup): > > >>>> TK LOOKUP IMAGE image19 ==== imgPNG-3.1 FAILED ==== textTag-18.1 > > >>>> TkTextPickCurrent tag bindings FAILED ==== Contents of test case: > > >>>> text .t -width 30 -height 4 -relief sunken -borderwidth 10 > > >>>> -highlightthickness 10 -pady 2 pack .t .t insert end " Tag here " > > >>>> TAG " no tag here" .t tag configure TAG -borderwidth 4 -relief > > >>>> raised .t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"} .t > > >>>> tag bind TAG <Leave> {lappend res "%x %y tag-Leave"} bind .t > > >>>> <Enter> {lappend res Enter} bind .t <Leave> {lappend res Leave} > > >>>> set res {} # Bindings must not trigger on the widget border, only > > >>>> over # the actual tagged characters themselves. event gen .t > > >>>> <Motion> -warp 1 -x 0 -y 0 ; update event gen .t <Motion> -warp 1 > > >>>> -x 10 -y > > >>>> 10 ; update event gen .t <Motion> -warp 1 -x 25 -y 25 ; update > > >>>> event gen .t <Motion> -warp > > >>>> 1 -x 20 -y 20 ; update event gen .t <Motion> -warp 1 -x 10 -y 10 > > >>>> ; update event gen .t <Motion> -warp 1 -x 25 -y 25 ; update > > >>>> return $res > > >>>> ---- Result was: {25 25 tag-Enter} {20 20 tag-Leave} {25 25 > > >>>> tag-Enter} ---- Result should have been (exact matching): Enter > > >>>> {25 > > >>>> 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter} ==== > > >>>> textTag-18.1 FAILED > > >>>> ----------------------------------------------------------------- > > >>>> -- > > >>>> ----------- Check out the vibrant tech community on one of the > > >>>> world's most engaging tech sites, Slashdot.org! > > >>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fs > > >>>> dm > > >>>> > > .link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681 > > >>>> > > > 419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7 > > C1 > > >>>> > > > %7C636494760553682109&sdata=Bb%2BDHvUgoVmWSCQidc6%2BayUmZnHT > > AbowyKz > > >>>> gzanNtYY%3D&reserved=0 > > >>>> _______________________________________________ Tcl-Core > mailing > > >>>> list Tcl...@li... > > >>>> <mailto:Tcl...@li...> > > >>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > > >>>> li > > >>>> sts.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7C > > >>>> do > > >>>> > > > nald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82 > > >>>> > > > fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=CHU > > MRt > > >>>> snIZpKdybs5u1xmnnRFRgLKY5zOM7n3%2FUBRmU%3D&reserved=0 > > >>> -- > > >>> ELMICRON Dr. Harald Oehlmann GmbH > > >>> Koesener Str. 85 > > >>> 06618 NAUMBURG - Germany > > >>> Phone: +49 (0)3445 78112-0 > > >>> Fax: +49 (0)3445 78112-19 > > >>> https://na01.safelinks.protection.outlook.com/?url=www.Elmicron.de > > >>> &d > > >>> > > > ata=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d548 > > 9 > > >>> > > > cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C6364947605536 > > 8210 > > >>> > > > 9&sdata=hWyvhioMCUHW2KK20f78HRq19RgS1ea9sXGwma%2FdUQ0%3D&res > > erved=0 > > >>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fw > > >>> ww > > >>> > > > .Elmicron.de&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e4 > > >>> > > > 12c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7 > > C636 > > >>> > > > 494760553682109&sdata=xHokt3rwVaLuP%2F1QzUOonxB%2Bu24eH518pQTyU > > qQc2t > > >>> k%3D&reserved=0> > > >>> German legal references: > > >>> Geschaeftsfuehrer: Dr. Harald Oehlmann, Jens Oehlmann UST Nr. / > > >>> VAT ID No.: DE206105272 HRB 212803 Stendal > > >>> > > >>> ------------------------------------------------------------------ > > >>> -- > > >>> ---------- Check out the vibrant tech community on one of the > > >>> world's most engaging tech sites, Slashdot.org! > > >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm. > > >>> > > > link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d68141 > > >>> > > > 9e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C > > 1%7C > > >>> > > > 636494760553682109&sdata=Bb%2BDHvUgoVmWSCQidc6%2BayUmZnHTAbo > > wyKzgzan > > >>> NtYY%3D&reserved=0 > > _______________________________________________ > > >>> Tcl-Core mailing list > > >>> Tcl...@li... > > >>> <mailto:Tcl...@li...> > > >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fl > > >>> is > > >>> ts.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7Cdo > > >>> na > > >>> > > > ld.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd > > 8 > > >>> > > > fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=CHUMR > > tsnIZ > > >>> pKdybs5u1xmnnRFRgLKY5zOM7n3%2FUBRmU%3D&reserved=0 > > > > > > > > > > > > -- > > | Don Porter Applied and Computational Mathematics Division | > > | don...@ni... Information Technology Laboratory | > > | http://math.nist.gov/~DPorter/ NIST | > > > |________________________________________________________________ > > ______| > > > > > ---------------------------------------------------------------------------- > -- > > Check out the vibrant tech community on one of the world's most > > engaging > tech > > sites, Slashdot.org! http://sdm.link/slashdot > > _______________________________________________ > > Tcl-Core mailing list > > Tcl...@li... > > https://lists.sourceforge.net/lists/listinfo/tcl-core > > > ---------------------------------------------------------------------------- -- > Check out the vibrant tech community on one of the world's most engaging tech > sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Tcl-Core mailing list > Tcl...@li... > https://lists.sourceforge.net/lists/listinfo/tcl-core |
|
From: Donald P. <d.g...@co...> - 2017-12-22 11:52:06
|
> On Dec 22, 2017, at 4:54 AM, apnmbx-public--- via Tcl-Core <tcl...@li...> wrote: > Just to note, the intrinsic.h header is included by sqlite3.c itself, not an > issue with Tcl or the tdbc sqlite3 adapter. That’s unfortunate, but it sounds like it’s an upstream bug, so we’ll go with it. Please make sure the notice gets sent upstream. DGP |
|
From: Harald O. <har...@el...> - 2018-01-08 10:00:45
|
François, first of all happy new year and thank you that you care. Am 21.12.2017 um 22:32 schrieb Francois Vogel: > François Vogel a écrit le 21/12/2017 à 20:14 : >> Le 21/12/2017 16:40, Harald Oehlmann a écrit : >> >>> New failures: >>> textTag-18.1 >> >> Surprising. >> >> Are you sure this fails repeatably (an event is missing, did you >> fiddle with the computer while the tests were running?) ? - repeatly: it was one try - fiddle: no I will make additional tests with 8.6.8 in the next days. >> Are you sure it didn't fail with the previous release? - no, it did not. > Too bad, not easy to check. Looks like you didn't update the wiki page > for the recent releases as you did in the past: > > http://wiki.tcl.tk/37529 As I changed the laptop, the results for Tk for 8.6.5-8.6.7 are in an extra table below the Vista table. This table is indeed very small, as only winfont 2.7-2.9 are failing. > However Tk 8.6.4 passed 100% OK for you (Windows Vista Pro 32 bit GER, > MSVC6++). Tk 8.6.5-8.6.7 are in the table below the table you were looking to. It is Win10, not Vista. > > Current Tk core-8-6-branch passes 100% OK for me (Win Vista 64 bits, > MSVC++ 2008 Express). That is great. Thank you, Harald |
|
From: Harald O. <har...@el...> - 2018-01-08 17:17:13
|
François,
I did the usual testing of the tcl/tk8.6.8 today.
Unfortunately, textTag-18.1 failed as with the rc.
Here is the log:
==== textTag-18.1 TkTextPickCurrent tag bindings FAILED
==== Contents of test case:
text .t -width 30 -height 4 -relief sunken -borderwidth 10
-highlightthickness 10 -pady 2
pack .t
.t insert end " Tag here " TAG " no tag here"
.t tag configure TAG -borderwidth 4 -relief raised
.t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"}
.t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"}
bind .t <Enter> {lappend res Enter}
bind .t <Leave> {lappend res Leave}
set res {}
# Bindings must not trigger on the widget border, only over
# the actual tagged characters themselves.
event gen .t <Motion> -warp 1 -x 0 -y 0 ; update
event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
event gen .t <Motion> -warp 1 -x 20 -y 20 ; update
event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
return $res
---- Result was:
{25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
---- Result should have been (exact matching):
Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
==== textTag-18.1 FAILED
I am ready for any action:
- ignore it
- make additional tests
- send you the binaries (tcl and tk build folders as zip)
- start a ticket
For the records:
tcl/tk 8.5.8 dist in folder c:\test
O/S: WIndows 10 64bit GER
Compiler: MS.VC6++ with PSDK 2003SP1
Command line:
nmake -f makefile.vc test TCLDIR=c:\test\tcl8.6.8 TESTFLAGS="-verbose
bte" > testlog_tk8.6.8.txt 2>&1
This test never failed for other Tk versions on my radar (
http://wiki.tcl.tk/37529 )
Thank you,
Harald
|
|
From: Francois V. <fvo...@fr...> - 2018-01-08 21:11:22
|
Le 08/01/2018 à 18:16, Harald Oehlmann a écrit :
> Unfortunately, textTag-18.1 failed as with the rc.
I had a look at the source code: the test itself did not change between
8.6.7 and 8.6.8, nor tkTextTag.c . Besides, I don't see which other
change could make the tags behavior wrong in 8.6.7 if they were OK for
you in 8.6.7, which you already confirmed).
I have just run the Tk tests again again and for me this test stubbornly
refuses to fail, unless I fiddle with the mouse while the tests are
running.I can only make it fail by moving the mouse inside the windows
that open during the test, for instance I can get:
==== textTag-18.1 TkTextPickCurrent tag bindings FAILED
<...snip...>
---- Result was:
Enter {25 25 tag-Enter} {20 20 tag-Leave} {23 24 tag-Enter} {20 20
tag-Leave} {25 25 tag-Enter}
---- Result should have been (exact matching):
Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
==== textTag-18.1 FAILED
But, again, if the mouse is not over the window that opens during the
tests I can get no satisfaction^H^H^H^H^H^H^H^H^H^H^H^Hfailure.
Can you try this on your side: start the tests from a location (icon,
script...) in your screen that has no intersection with the test window
that it opens during the test: doestextTag-18.1 fail?
If that's the cause (i.e. if it fails because your mouse is still at a
"wrong" location after you started the tests, then it means two things:
1. It certainly already failed in prevous releases
2. I should look at ruggedization of this test
Regards,
Francois
|
|
From: Brian G. <bri...@ea...> - 2018-01-08 21:42:04
|
I think this test is suspect. There's no certainty that an Enter event is NOT produced from the action of the first event gen statement since the initial position of the cursor is unknown:
event gen .t <Motion> -warp 1 -x 0 -y 0 ; update
I would try changing the test:
event gen .t <Motion> -warp 1 -x 0 -y 0 ; update ;# Initialize pointer location.
set res {}
# Bindings must not trigger on the widget border, only over
# the actual tagged characters themselves.
event gen .t <Motion> -warp 1 -x 0 -y 0 ; update ;# Should be a no-op now because the previous event will essentially initialize the pointer location.
-Brian
On Jan 8, 2018, at 9:16 AM, Harald Oehlmann <har...@el...<mailto:har...@el...>> wrote:
François,
I did the usual testing of the tcl/tk8.6.8 today.
Unfortunately, textTag-18.1 failed as with the rc.
Here is the log:
==== textTag-18.1 TkTextPickCurrent tag bindings FAILED
==== Contents of test case:
text .t -width 30 -height 4 -relief sunken -borderwidth 10
-highlightthickness 10 -pady 2
pack .t
.t insert end " Tag here " TAG " no tag here"
.t tag configure TAG -borderwidth 4 -relief raised
.t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"}
.t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"}
bind .t <Enter> {lappend res Enter}
bind .t <Leave> {lappend res Leave}
set res {}
# Bindings must not trigger on the widget border, only over
# the actual tagged characters themselves.
event gen .t <Motion> -warp 1 -x 0 -y 0 ; update
event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
event gen .t <Motion> -warp 1 -x 20 -y 20 ; update
event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
return $res
---- Result was:
{25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
---- Result should have been (exact matching):
Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
==== textTag-18.1 FAILED
I am ready for any action:
- ignore it
- make additional tests
- send you the binaries (tcl and tk build folders as zip)
- start a ticket
For the records:
tcl/tk 8.5.8 dist in folder c:\test
O/S: WIndows 10 64bit GER
Compiler: MS.VC6++ with PSDK 2003SP1
Command line:
nmake -f makefile.vc test TCLDIR=c:\test\tcl8.6.8 TESTFLAGS="-verbose
bte" > testlog_tk8.6.8.txt 2>&1
This test never failed for other Tk versions on my radar (
http://wiki.tcl.tk/37529 )
Thank you,
Harald
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org<http://Slashdot.org>! http://sdm.link/slashdot
_______________________________________________
Tcl-Core mailing list
Tcl...@li...<mailto:Tcl...@li...>
https://lists.sourceforge.net/lists/listinfo/tcl-core
|
|
From: Harald O. <har...@el...> - 2018-01-09 14:30:35
|
Brian, Francois, thank you for your contrinutions. A ticket is created with additional tests of a man walking in the dark: https://core.tcl.tk/tk/info/69b48f427e94899a Maybe, we continue the discussion there. Thank you, Harald Am 08.01.2018 um 22:41 schrieb Brian Griffin: > I think this test is suspect. There's no certainty that an Enter event > is NOT produced from the action of the first event gen statement since > the initial position of the cursor is unknown: > > event gen .t <Motion> -warp 1 -x 0 -y 0 ; update > > I would try changing the test: > > event gen .t <Motion> -warp 1 -x 0 -y 0 ; update ;# Initialize pointer > location. > set res {} > # Bindings must not trigger on the widget border, only over > # the actual tagged characters themselves. > event gen .t <Motion> -warp 1 -x 0 -y 0 ; update ;# Should be a no-op > now because the previous event will essentially initialize the pointer > location. |
Thanks for helping keep SourceForge clean.
X