Menu
▾
▴
tcl-core
|
From: Francois V. <fvo...@fr...> - 2018-10-14 16:47:57
|
Le 14/10/2018 à 18:14, Harald Oehlmann a écrit :
> I just rechecked 8.6.8 with my current system (Win 10 1803). The failure
> is still identically there. The test log is identical to (I suppose it
> was Win10 1703).
> So, it should be a Tk change between 8.6.8 and 8.6.9a0.
Very interesting. Can you then, on your Win10 1803, with Tcl/Tk 8.6.9 rc0:
1. remove this checking [745b43440b2cbe03] I already mentioned
(which was suppoed to fix the case of macOS), i.e. apply the following
patch:
Index: tests/textTag.test
==================================================================
--- tests/textTag.test
+++ tests/textTag.test
@@ -1744,10 +1744,11 @@
event generate {} <Motion> -warp 1 -x -1 -y -1; update
} -body {
text .t -width 30 -height 4 -relief sunken -borderwidth 10 \
-highlightthickness 10 -pady 2
pack .t
- update ; # map the window, otherwise -warp can't be done
.t insert end " Tag here " TAG " no tag here"
.t tag configure TAG -borderwidth 4 -relief raised
.t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"}
.t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"}
and
2. Test again textTag-18.1
Does it fail? I bet it does.
If so, the problem I have with this is that it does not fully sleep with
Ashok's analysis.
Thanks,
Francois
|
|
From: Harald O. <har...@el...> - 2018-10-14 18:09:16
|
As far as I remember, we have already tried that at the time before.
The test still fails. Here is the log. I have put a comment mark in
front of the new line.
==== textTag-18.1 TkTextPickCurrent tag bindings FAILED
==== Contents of test case:
text .t -width 30 -height 4 -relief sunken -borderwidth 10
-highlightthickness 10 -pady 2
pack .t
# update ; # map the window, otherwise -warp can't be done
.t insert end " Tag here " TAG " no tag here"
.t tag configure TAG -borderwidth 4 -relief raised
.t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"}
.t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"}
bind .t <Enter> {lappend res Enter}
bind .t <Leave> {lappend res Leave}
set res {}
# Bindings must not trigger on the widget border, only over
# the actual tagged characters themselves.
event gen .t <Motion> -warp 1 -x 0 -y 0 ; update
event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
event gen .t <Motion> -warp 1 -x 20 -y 20 ; update
event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
return $res
---- Result was:
{25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
---- Result should have been (exact matching):
Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
==== textTag-18.1 FAILED
Harald
Am 14.10.2018 um 18:45 schrieb Francois Vogel:
> Le 14/10/2018 à 18:14, Harald Oehlmann a écrit :
>> I just rechecked 8.6.8 with my current system (Win 10 1803). The failure
>> is still identically there. The test log is identical to (I suppose it
>> was Win10 1703).
>> So, it should be a Tk change between 8.6.8 and 8.6.9a0.
>
> Very interesting. Can you then, on your Win10 1803, with Tcl/Tk 8.6.9 rc0:
>
> 1. remove this checking [745b43440b2cbe03] I already mentioned
> (which was suppoed to fix the case of macOS), i.e. apply the following
> patch:
>
> Index: tests/textTag.test
> ==================================================================
> --- tests/textTag.test
> +++ tests/textTag.test
> @@ -1744,10 +1744,11 @@
> event generate {} <Motion> -warp 1 -x -1 -y -1; update
> } -body {
> text .t -width 30 -height 4 -relief sunken -borderwidth 10 \
> -highlightthickness 10 -pady 2
> pack .t
> - update ; # map the window, otherwise -warp can't be done
> .t insert end " Tag here " TAG " no tag here"
> .t tag configure TAG -borderwidth 4 -relief raised
> .t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"}
> .t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"}
>
>
> and
>
> 2. Test again textTag-18.1
>
> Does it fail? I bet it does.
>
> If so, the problem I have with this is that it does not fully sleep with
> Ashok's analysis.
>
> Thanks,
|
|
From: Francois V. <fvo...@fr...> - 2018-10-14 18:13:08
|
Le 14/10/2018 à 20:08, Harald Oehlmann a écrit : > As far as I remember, we have already tried that at the time before. > > The test still fails. I don't understand the "still" you write here. I asked you to try the following: From situation A: Win10 1803 with Tcl/Tk 8.6.9 rc0, which does NOT fail (right?), move to situation B: same thing but comment the "update" line in the test. How can the test *still* fail?It does not fail in situation A. Are you saying it fails in situation B? F. |
|
From: Harald O. <har...@el...> - 2018-10-14 18:17:35
|
Sorry, my wording and own understanding was wrong. The test fails with the patch removed, so it is the curing reason. Sorry, wrong analysis. This update cures the test. Thank you, Harald Am 14.10.2018 um 20:11 schrieb Francois Vogel: > Le 14/10/2018 à 20:08, Harald Oehlmann a écrit : >> As far as I remember, we have already tried that at the time before. >> >> The test still fails. > > I don't understand the "still" you write here. > > I asked you to try the following: From situation A: Win10 1803 with > Tcl/Tk 8.6.9 rc0, which does NOT fail (right?), move to situation B: > same thing but comment the "update" line in the test. > > How can the test *still* fail?It does not fail in situation A. Are you > saying it fails in situation B? > > F. |
|
From: <apn...@ya...> - 2018-10-17 13:33:37
|
I am still getting this test failure on my system. Win 10 OS Build 17134.345 I tried with the core-8-6-branch which I happened to have handy. Will build and check the RC a bit later. /Ashok > -----Original Message----- > From: Harald Oehlmann <har...@el...> > Sent: Sunday, October 14, 2018 9:44 PM > To: Francois Vogel <fvo...@fr...>; tcl...@li... > Subject: Re: [TCLCORE] Tcl 8.6.9 Release Candidate > >>> https://core.tcl.tk/tk/info/69b48f427e94899a > >> I double-checked: textTag-18.1 is successfully tested. > >> It is Windows 10 1803 > > > > How strange. I remember that Ashok confirmed in the above ticket that > > Win10 1803 (so the April 2018 version) did NOT fix this. Could Ashok > > perhaps confirm again his findings? |
|
From: Francois V. <fvo...@fr...> - 2018-10-17 21:01:09
|
Le 17/10/2018 à 15:33, apnmbx-public--- via Tcl-Core a écrit : > I am still getting this test failure on my system. Win 10 OS Build 17134.345 > > I tried with the core-8-6-branch which I happened to have handy. Will build and check the RC a bit later. > > /Ashok Thank you for your confirmation. We now have conflicting reports. Not sure what's the way ahead here. Francois |
|
From: Donald G P. <don...@ni...> - 2017-12-15 19:11:40
|
You can probably guess that I failed to update the subject line on the last message. Here's the correction. On 12/15/2017 02:07 PM, Donald G Porter wrote: > Now available at https://sourceforge.net/projects/tcl/files/Tcl/8.6.8/ > are the candidate files making up a release of Tcl/Tk 8.6.8. > > New release candidates of all bundled packages are also included. > > These files will not be the actual releases. At a minimum, the Tcl > and Tk changes files are not yet up to date and release notes need > to be completed. > > Please report any new troubles you encounter, particularly any that seem > severe enough they should prevent release. -- | Don Porter Applied and Computational Mathematics Division | | don...@ni... Information Technology Laboratory | | http://math.nist.gov/~DPorter/ NIST | |______________________________________________________________________| |
|
From: Paul O. <pa...@po...> - 2017-12-17 12:48:09
|
Builds and works on Windows and Linux. The only problem are missing files "win/rules-ext.vc" and "win/targets.vc" in the distribution tk8.6.8rc0-src.tar.gz <https://sourceforge.net/projects/tcl/files/Tcl/8.6.8/tk8.6.8rc0-src.tar.gz/download>, when compiling with nmake/VisualStudio. Regards, Paul Am 15.12.2017 um 20:10 schrieb Donald G Porter: > > You can probably guess that I failed to update the subject line on the > last message. Here's the correction. > > On 12/15/2017 02:07 PM, Donald G Porter wrote: >> Now available at > > https://sourceforge.net/projects/tcl/files/Tcl/8.6.8/ > >> are the candidate files making up a release of Tcl/Tk 8.6.8. >> >> New release candidates of all bundled packages are also included. >> >> These files will not be the actual releases. At a minimum, the Tcl >> and Tk changes files are not yet up to date and release notes need >> to be completed. >> >> Please report any new troubles you encounter, particularly any that seem >> severe enough they should prevent release. > |
|
From: Jan N. <jan...@gm...> - 2017-12-18 12:20:29
|
2017-12-17 13:31 GMT+01:00 Paul Obermeier:
> Builds and works on Windows and Linux.
> The only problem are missing files "win/rules-ext.vc" and "win/targets.vc"
> in the distribution tk8.6.8rc0-src.tar.gz,
> when compiling with nmake/VisualStudio.
Should be fixed now. Thanks for the report!
<http://core.tcl.tk/tcl/info/09c31fe30f37df8e>
Regards,
Jan Nijtmans
|
|
From: Donald G P. <don...@ni...> - 2017-12-20 17:42:50
|
>> Now available at > > https://sourceforge.net/projects/tcl/files/Tcl/8.6.8/ > >> are the candidate files making up a release of Tcl/Tk 8.6.8. Also available at ftp://ftp.tcl.tk/pub/tcl/tcl8_6/ These are the RC1 candidates. They may become the actual release on Friday, December 22. Let me know of any reason you uncover why they should not be released. Release notes coming soon. -- | Don Porter Applied and Computational Mathematics Division | | don...@ni... Information Technology Laboratory | | http://math.nist.gov/~DPorter/ NIST | |______________________________________________________________________| |
|
From: Donald G P. <don...@ni...> - 2017-12-20 19:07:01
|
On 12/20/2017 12:42 PM, Donald G Porter wrote: > Release notes coming soon. Draft release notes are now also posted at https://sourceforge.net/projects/tcl/files/Tcl/8.6.8/ Send me any needed corrections or additions. -- | Don Porter Applied and Computational Mathematics Division | | don...@ni... Information Technology Laboratory | | http://math.nist.gov/~DPorter/ NIST | |______________________________________________________________________| |
|
From: Dipl. I. S. G. B. <se...@us...> - 2017-12-20 18:19:38
|
Hi Don, > Let me know of any reason you uncover why they should not be released. 1. Not about specially this release, but IMHO the BUG [578155d5a1] [3] could be clarified before we release it. 2. I've the almost ready solution for BUG [fec0c17d39] [4], thus I would like to see it still in this release (I'm too busy at the moment, but if I'll accomplish it, I'll push to fossil as soon as possible). 3. I would like to know when we can plan the "release" of my newest clock-engine (interim available as tclclockmod-module on github). I though, we wanted to merge it with next 8.6th release? Or I missed some points there? What I could do to push it further? Flightaware use it already several time (as module). @Flightaware, @Peter Could you share your experience about it, please? Possibly it will help to release this clock-engine within tcl-core... Regards, Sergey. Am 20.12.2017 18:42, schrieb Donald G Porter: > Now available at https://sourceforge.net/projects/tcl/files/Tcl/8.6.8/ [1] are the candidate files making up a release of Tcl/Tk 8.6.8. Also available at ftp://ftp.tcl.tk/pub/tcl/tcl8_6/ [2] These are the RC1 candidates. They may become the actual release on Friday, December 22. Let me know of any reason you uncover why they should not be released. Release notes coming soon. Links: ------ [1] https://sourceforge.net/projects/tcl/files/Tcl/8.6.8/ [2] ftp://ftp.tcl.tk/pub/tcl/tcl8_6/ [3] https://core.tcl.tk/tcl/tktview?name=578155d5a1 [4] https://core.tcl.tk/tcl/tktview?name=fec0c17d39 |
|
From: Donald G P. <d.g...@co...> - 2017-12-20 19:05:48
|
On 12/20/2017 01:19 PM, Dipl. Ing. Sergey G. Brester via Tcl-Core wrote: > 1. [578155d5a1] - Issues with refcounts when C API used to set variables. > 2. [fec0c17d39] - C stack exhaustion compiling deeply nested [catch]. > 3. clock-engine - performance-improving re-write. I'm interested in making progress on all three of these things, but not holding the 8.6.8 release for any of them. They are all long-standing things of significant complexity that need attention and care to address. I think I will be available to do what I can to tackle them in January. Others are of course welcome to dive in as well. DGP |
|
From: Harald O. <har...@el...> - 2017-12-20 21:03:22
|
Am 20.12.2017 um 18:42 schrieb Donald G Porter: > >>> Now available at >> >> https://sourceforge.net/projects/tcl/files/Tcl/8.6.8/ >> >>> are the candidate files making up a release of Tcl/Tk 8.6.8. > > Also available at > > ftp://ftp.tcl.tk/pub/tcl/tcl8_6/ > > These are the RC1 candidates. They may become the actual release > on Friday, December 22. Let me know of any reason you uncover why > they should not be released. > > Release notes coming soon. > Maybe I am wrong, but I still get the error: makefile.vc(26) : fatal error U1052: file 'rules-ext.vc' not found I think, this happens when sqlite is compiled. cd win nmake -f makefile.vc with MS-VC6+PSDK2003SP1 on Win10 GER Thank you, Harald |
|
From: <apn...@ya...> - 2017-12-21 08:03:12
|
The rules-ext.vc and targets.vc files are missing from all extensions in pkgs except itcl. I had not realized that files had to be explicitly added to the distribution, presuming the source directories for the bundled packages were directly copied (which is what itcl does). I have fixed this for tdbc* and thread, modifying Makefile.in in trunk for those repositories to copy targets.vc and rules-ext.vc as part of make dist. Itcl already copied all files and should not have this problem. Sqlite3/cyqlite I have not modified because looking at Makefile.in in the cyqlite repository, it appears to me all files should already be copied but targets.vc and rules-ext.vc do not appear in the distribution. I'm not sure where the source for the distributed sqlite3 comes from. I cannot actually test creating a distribution to ensure above fixes work as the autoconf files do not support a make dist target on Windows. /Ashok > -----Original Message----- > From: Harald Oehlmann [mailto:har...@el...] > Sent: Thursday, December 21, 2017 2:28 AM > To: tcl...@li... > Subject: Re: [TCLCORE] Tcl / Tk 8.6.8 Release Candidates > > Am 20.12.2017 um 18:42 schrieb Donald G Porter: > > > >>> Now available at > >> > >> https://sourceforge.net/projects/tcl/files/Tcl/8.6.8/ > >> > >>> are the candidate files making up a release of Tcl/Tk 8.6.8. > > > > Also available at > > > > ftp://ftp.tcl.tk/pub/tcl/tcl8_6/ > > > > These are the RC1 candidates. They may become the actual release on > > Friday, December 22. Let me know of any reason you uncover why they > > should not be released. > > > > Release notes coming soon. > > > > Maybe I am wrong, but I still get the error: > makefile.vc(26) : fatal error U1052: file 'rules-ext.vc' not found > > I think, this happens when sqlite is compiled. > > cd win > nmake -f makefile.vc > > with MS-VC6+PSDK2003SP1 on Win10 GER > > Thank you, > Harald > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most engaging tech > sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Tcl-Core mailing list > Tcl...@li... > https://lists.sourceforge.net/lists/listinfo/tcl-core |
|
From: Donald G P. <don...@ni...> - 2017-12-21 14:31:58
|
Thank you all for the reports and fixes. Updated candidates of the bundled packages are now in place that should correct these issues. On 12/21/2017 03:02 AM, apnmbx-public--- via Tcl-Core wrote: > The rules-ext.vc and targets.vc files are missing from all extensions in pkgs except itcl. > > I had not realized that files had to be explicitly added to the distribution, presuming the source directories for the bundled packages were directly copied (which is what itcl does). > > I have fixed this for tdbc* and thread, modifying Makefile.in in trunk for those repositories to copy targets.vc and rules-ext.vc as part of make dist. > > Itcl already copied all files and should not have this problem. > > Sqlite3/cyqlite I have not modified because looking at Makefile.in in the cyqlite repository, it appears to me all files should already be copied but targets.vc and rules-ext.vc do not appear in the distribution. I'm not sure where the source for the distributed sqlite3 comes from. > > I cannot actually test creating a distribution to ensure above fixes work as the autoconf files do not support a make dist target on Windows. > > /Ashok > >> -----Original Message----- >> From: Harald Oehlmann [mailto:har...@el...] >> Sent: Thursday, December 21, 2017 2:28 AM >> To: tcl...@li... >> Subject: Re: [TCLCORE] Tcl / Tk 8.6.8 Release Candidates >> >> Am 20.12.2017 um 18:42 schrieb Donald G Porter: >>> >>>>> Now available at >>>> >>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsourceforge.net%2Fprojects%2Ftcl%2Ffiles%2FTcl%2F8.6.8%2F&data=02%7C01%7Cdonald.porter%40nist.gov%7C31c34e991237412fc6bc08d548496a2c%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494402506247302&sdata=wLAv%2Bnmcdm8qj1W%2Fjs8GDMk2KwlabspJWThHhzNl0k8%3D&reserved=0 >>>> >>>>> are the candidate files making up a release of Tcl/Tk 8.6.8. >>> >>> Also available at >>> >>> ftp://ftp.tcl.tk/pub/tcl/tcl8_6/ >>> >>> These are the RC1 candidates. They may become the actual release on >>> Friday, December 22. Let me know of any reason you uncover why they >>> should not be released. >>> >>> Release notes coming soon. >>> >> >> Maybe I am wrong, but I still get the error: >> makefile.vc(26) : fatal error U1052: file 'rules-ext.vc' not found >> >> I think, this happens when sqlite is compiled. >> >> cd win >> nmake -f makefile.vc >> >> with MS-VC6+PSDK2003SP1 on Win10 GER >> >> Thank you, >> Harald >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most engaging tech >> sites, Slashdot.org! https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm.link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7C31c34e991237412fc6bc08d548496a2c%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494402506247302&sdata=QiP1MuOV4Hcwg391au5G0ovn2eaRM4yQkA9ST5FLwss%3D&reserved=0 >> _______________________________________________ >> Tcl-Core mailing list >> Tcl...@li... >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7Cdonald.porter%40nist.gov%7C31c34e991237412fc6bc08d548496a2c%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494402506247302&sdata=%2BOt5%2FPVreSFg0uB%2FJtsFnfk9dfXe8R3UEOsCLC%2FihrU%3D&reserved=0 > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm.link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7C31c34e991237412fc6bc08d548496a2c%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494402506247302&sdata=QiP1MuOV4Hcwg391au5G0ovn2eaRM4yQkA9ST5FLwss%3D&reserved=0 > _______________________________________________ > Tcl-Core mailing list > Tcl...@li... > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7Cdonald.porter%40nist.gov%7C31c34e991237412fc6bc08d548496a2c%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494402506247302&sdata=%2BOt5%2FPVreSFg0uB%2FJtsFnfk9dfXe8R3UEOsCLC%2FihrU%3D&reserved=0 > -- | Don Porter Applied and Computational Mathematics Division | | don...@ni... Information Technology Laboratory | | http://math.nist.gov/~DPorter/ NIST | |______________________________________________________________________| |
|
From: Harald O. <har...@el...> - 2017-12-21 16:15:54
|
Dear Donald,
big christmas present to the community ! Now it compiles well.
Here are the test differences compared to tcl 8.6.7, details below:
New failures:
Tk: imgPNG-3.1, textTag-18.1
Still failing:
Tcl: cmdAH-25.3.1 fCmd-9.9 fCmd-9.11 iortrans-11.1 iortrans-11.2 winFCmd-2.8
iTCL: sfbug-254 sfbug-257
Tk: winfont-2.7 winfont-2.8 winfont-2.9
Thank you, great !
Harald
-- Details --
==== imgPNG-3.1 reading image with unknown ancillary chunk - bug
[1c659ef0f1] FAILED
==== Contents of test case:
# the image contains an unknown chunk iDOT
# since the name of this chunk starts with a lowercase letter,
# it's an ancillary chunk that shall not trigger an error
catch {set i [image create photo -file $fileName]}
---- Result was:
1
---- Result should have been (exact matching):
0
---- Test cleanup failed:
image "image19" doesn't exist
---- errorInfo(cleanup): image "image19" doesn't exist
while executing
"image delete $i"
("uplevel" body line 2)
invoked from within
"uplevel 1 $cleanup"
---- errorCode(cleanup): TK LOOKUP IMAGE image19
==== imgPNG-3.1 FAILED
==== textTag-18.1 TkTextPickCurrent tag bindings FAILED
==== Contents of test case:
text .t -width 30 -height 4 -relief sunken -borderwidth 10
-highlightthickness 10 -pady 2
pack .t
.t insert end " Tag here " TAG " no tag here"
.t tag configure TAG -borderwidth 4 -relief raised
.t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"}
.t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"}
bind .t <Enter> {lappend res Enter}
bind .t <Leave> {lappend res Leave}
set res {}
# Bindings must not trigger on the widget border, only over
# the actual tagged characters themselves.
event gen .t <Motion> -warp 1 -x 0 -y 0 ; update
event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
event gen .t <Motion> -warp 1 -x 20 -y 20 ; update
event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
return $res
---- Result was:
{25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
---- Result should have been (exact matching):
Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
==== textTag-18.1 FAILED
|
|
From: Harald O. <har...@el...> - 2017-12-21 17:16:34
|
Dear folks,
I think I have overlooked an issue.
Here is a compilation error in tdbcodbc.c
tdbcodbc.c
C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1009) :
error C2054: expected '(' to follow 'inline'
C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) :
error C2082: redefinition of formal parameter 'LookupOdbcType'
C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) :
error C2143: syntax error : missing ';' before '{'
This is MSVC 6++ win32 compilation. There is normally a macro which uses
"_inline", as the inline keyword does not exist on MSVC6.
Thank you,
Harald
Am 21.12.2017 um 16:40 schrieb Harald Oehlmann:
> Dear Donald,
>
> big christmas present to the community ! Now it compiles well.
>
> Here are the test differences compared to tcl 8.6.7, details below:
>
> New failures:
>
> Tk: imgPNG-3.1, textTag-18.1
>
> Still failing:
> Tcl: cmdAH-25.3.1 fCmd-9.9 fCmd-9.11 iortrans-11.1 iortrans-11.2 winFCmd-2.8
> iTCL: sfbug-254 sfbug-257
> Tk: winfont-2.7 winfont-2.8 winfont-2.9
>
> Thank you, great !
>
> Harald
>
> -- Details --
>
> ==== imgPNG-3.1 reading image with unknown ancillary chunk - bug
> [1c659ef0f1] FAILED
> ==== Contents of test case:
>
> # the image contains an unknown chunk iDOT
> # since the name of this chunk starts with a lowercase letter,
> # it's an ancillary chunk that shall not trigger an error
> catch {set i [image create photo -file $fileName]}
>
> ---- Result was:
> 1
> ---- Result should have been (exact matching):
> 0
> ---- Test cleanup failed:
> image "image19" doesn't exist
> ---- errorInfo(cleanup): image "image19" doesn't exist
> while executing
> "image delete $i"
> ("uplevel" body line 2)
> invoked from within
> "uplevel 1 $cleanup"
> ---- errorCode(cleanup): TK LOOKUP IMAGE image19
> ==== imgPNG-3.1 FAILED
>
> ==== textTag-18.1 TkTextPickCurrent tag bindings FAILED
> ==== Contents of test case:
>
> text .t -width 30 -height 4 -relief sunken -borderwidth 10
> -highlightthickness 10 -pady 2
> pack .t
>
> .t insert end " Tag here " TAG " no tag here"
> .t tag configure TAG -borderwidth 4 -relief raised
> .t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"}
> .t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"}
> bind .t <Enter> {lappend res Enter}
> bind .t <Leave> {lappend res Leave}
>
> set res {}
> # Bindings must not trigger on the widget border, only over
> # the actual tagged characters themselves.
> event gen .t <Motion> -warp 1 -x 0 -y 0 ; update
> event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
> event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
> event gen .t <Motion> -warp 1 -x 20 -y 20 ; update
> event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
> event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
> return $res
>
> ---- Result was:
> {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
> ---- Result should have been (exact matching):
> Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
> ==== textTag-18.1 FAILED
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Tcl-Core mailing list
> Tcl...@li...
> https://lists.sourceforge.net/lists/listinfo/tcl-core
>
--
ELMICRON Dr. Harald Oehlmann GmbH
Koesener Str. 85
06618 NAUMBURG - Germany
Phone: +49 (0)3445 78112-0
Fax: +49 (0)3445 78112-19
www.Elmicron.de
German legal references:
Geschaeftsfuehrer: Dr. Harald Oehlmann, Jens Oehlmann
UST Nr. / VAT ID No.: DE206105272
HRB 212803 Stendal
|
|
From: Harald O. <har...@el...> - 2017-12-21 17:29:10
|
If I replace in the source "inline" by _inline" all compiles fine and
the package is install- and loadable.
Thank you,
Harald
Am 21.12.2017 um 18:16 schrieb Harald Oehlmann:
> Dear folks,
>
> I think I have overlooked an issue.
>
> Here is a compilation error in tdbcodbc.c
>
> tdbcodbc.c
> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1009) :
> error C2054: expected '(' to follow 'inline'
> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) :
> error C2082: redefinition of formal parameter 'LookupOdbcType'
> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) :
> error C2143: syntax error : missing ';' before '{'
>
> This is MSVC 6++ win32 compilation. There is normally a macro which uses
> "_inline", as the inline keyword does not exist on MSVC6.
>
> Thank you,
> Harald
>
>
> Am 21.12.2017 um 16:40 schrieb Harald Oehlmann:
>> Dear Donald,
>>
>> big christmas present to the community ! Now it compiles well.
>>
>> Here are the test differences compared to tcl 8.6.7, details below:
>>
>> New failures:
>>
>> Tk: imgPNG-3.1, textTag-18.1
>>
>> Still failing:
>> Tcl: cmdAH-25.3.1 fCmd-9.9 fCmd-9.11 iortrans-11.1 iortrans-11.2 winFCmd-2.8
>> iTCL: sfbug-254 sfbug-257
>> Tk: winfont-2.7 winfont-2.8 winfont-2.9
>>
>> Thank you, great !
>>
>> Harald
>>
>> -- Details --
>>
>> ==== imgPNG-3.1 reading image with unknown ancillary chunk - bug
>> [1c659ef0f1] FAILED
>> ==== Contents of test case:
>>
>> # the image contains an unknown chunk iDOT
>> # since the name of this chunk starts with a lowercase letter,
>> # it's an ancillary chunk that shall not trigger an error
>> catch {set i [image create photo -file $fileName]}
>>
>> ---- Result was:
>> 1
>> ---- Result should have been (exact matching):
>> 0
>> ---- Test cleanup failed:
>> image "image19" doesn't exist
>> ---- errorInfo(cleanup): image "image19" doesn't exist
>> while executing
>> "image delete $i"
>> ("uplevel" body line 2)
>> invoked from within
>> "uplevel 1 $cleanup"
>> ---- errorCode(cleanup): TK LOOKUP IMAGE image19
>> ==== imgPNG-3.1 FAILED
>>
>> ==== textTag-18.1 TkTextPickCurrent tag bindings FAILED
>> ==== Contents of test case:
>>
>> text .t -width 30 -height 4 -relief sunken -borderwidth 10
>> -highlightthickness 10 -pady 2
>> pack .t
>>
>> .t insert end " Tag here " TAG " no tag here"
>> .t tag configure TAG -borderwidth 4 -relief raised
>> .t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"}
>> .t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"}
>> bind .t <Enter> {lappend res Enter}
>> bind .t <Leave> {lappend res Leave}
>>
>> set res {}
>> # Bindings must not trigger on the widget border, only over
>> # the actual tagged characters themselves.
>> event gen .t <Motion> -warp 1 -x 0 -y 0 ; update
>> event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
>> event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
>> event gen .t <Motion> -warp 1 -x 20 -y 20 ; update
>> event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
>> event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
>> return $res
>>
>> ---- Result was:
>> {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
>> ---- Result should have been (exact matching):
>> Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
>> ==== textTag-18.1 FAILED
|
|
From: Dipl. I. S. G. B. <se...@us...> - 2017-12-21 17:34:26
|
Hi Harald,
in VS "inline" is normally for C++ only, for C it can be defined like:
nmake -nologo -f makefile.vc TCLDIR=%TCLDIR% OPTS=...
OPTDEFINES="-DINLINE=__INLINE"
No idea which parameter exactly can be used to extend options from
command-line by tdbcodbc (OPTDEFINES, ADDOPTDEFINES, OPTIMIZATIONS,
etc.)...
Just take a look in rules.vc resp. makefile.vc for it...
Regards,
Sergey.
Am 21.12.2017 18:16, schrieb Harald Oehlmann:
> Dear folks,
>
> I think I have overlooked an issue.
>
> Here is a compilation error in tdbcodbc.c
>
> tdbcodbc.c
> C:testtcl8.6.8pkgstdbcodbc1.0.6win..generictdbcodbc.c(1009) :
> error C2054: expected '(' to follow 'inline'
> C:testtcl8.6.8pkgstdbcodbc1.0.6win..generictdbcodbc.c(1013) :
> error C2082: redefinition of formal parameter 'LookupOdbcType'
> C:testtcl8.6.8pkgstdbcodbc1.0.6win..generictdbcodbc.c(1013) :
> error C2143: syntax error : missing ';' before '{'
>
> This is MSVC 6++ win32 compilation. There is normally a macro which uses
> "_inline", as the inline keyword does not exist on MSVC6.
>
> Thank you,
> Harald
>
> Am 21.12.2017 um 16:40 schrieb Harald Oehlmann:
>
>> Dear Donald, big christmas present to the community ! Now it compiles well. Here are the test differences compared to tcl 8.6.7, details below: New failures: Tk: imgPNG-3.1, textTag-18.1 Still failing: Tcl: cmdAH-25.3.1 fCmd-9.9 fCmd-9.11 iortrans-11.1 iortrans-11.2 winFCmd-2.8 iTCL: sfbug-254 sfbug-257 Tk: winfont-2.7 winfont-2.8 winfont-2.9 Thank you, great ! Harald -- Details -- ==== imgPNG-3.1 reading image with unknown ancillary chunk - bug [1c659ef0f1] FAILED ==== Contents of test case: # the image contains an unknown chunk iDOT # since the name of this chunk starts with a lowercase letter, # it's an ancillary chunk that shall not trigger an error catch {set i [image create photo -file $fileName]} ---- Result was: 1 ---- Result should have been (exact matching): 0 ---- Test cleanup failed: image "image19" doesn't exist ---- errorInfo(cleanup): image "image19" doesn't exist while executing "image delete $i" ("uplevel" body line 2) invoked from within "uplevel 1 $cleanup" ----
errorCode(cleanup): TK LOOKUP IMAGE image19 ==== imgPNG-3.1 FAILED ==== textTag-18.1 TkTextPickCurrent tag bindings FAILED ==== Contents of test case: text .t -width 30 -height 4 -relief sunken -borderwidth 10 -highlightthickness 10 -pady 2 pack .t .t insert end " Tag here " TAG " no tag here" .t tag configure TAG -borderwidth 4 -relief raised .t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"} .t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"} bind .t <Enter> {lappend res Enter} bind .t <Leave> {lappend res Leave} set res {} # Bindings must not trigger on the widget border, only over # the actual tagged characters themselves. event gen .t <Motion> -warp 1 -x 0 -y 0 ; update event gen .t <Motion> -warp 1 -x 10 -y 10 ; update event gen .t <Motion> -warp 1 -x 25 -y 25 ; update event gen .t <Motion> -warp 1 -x 20 -y 20 ; update event gen .t <Motion> -warp 1 -x 10 -y 10 ; update event gen .t <Motion> -warp 1 -x 25 -y 25 ; update return $res ---- Result was: {25 25 tag-Enter} {20
20 tag-Leave} {25 25 tag-Enter} ---- Result should have been (exact matching): Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter} ==== textTag-18.1 FAILED ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot [1] _______________________________________________ Tcl-Core mailing list Tcl...@li... https://lists.sourceforge.net/lists/listinfo/tcl-core [2]
>
> --
> ELMICRON Dr. Harald Oehlmann GmbH
> Koesener Str. 85
> 06618 NAUMBURG - Germany
> Phone: +49 (0)3445 78112-0
> Fax: +49 (0)3445 78112-19
> www.Elmicron.de [3]
> German legal references:
> Geschaeftsfuehrer: Dr. Harald Oehlmann, Jens Oehlmann
> UST Nr. / VAT ID No.: DE206105272
> HRB 212803 Stendal
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot [1]
> _______________________________________________
> Tcl-Core mailing list
> Tcl...@li...
> https://lists.sourceforge.net/lists/listinfo/tcl-core [2]
Links:
------
[1] http://sdm.link/slashdot
[2] https://lists.sourceforge.net/lists/listinfo/tcl-core
[3] http://www.Elmicron.de
|
|
From: Harald O. <har...@el...> - 2017-12-21 18:00:14
|
Sergey,
thank you for the message.
I have found:
PRJ_DEFINES = -DTCL_TOMMATH -DMP_PREC=4 -Dinline=__inline -DHAVE_ZLIB=1
-D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE
in line 356 of win/makefile.vc
if I insert:
PRJ_DEFINES = -Dinline=__inline
as line 73 of pkgs/tdbcodbc1.0.6/win/Makefile.vc
all compiles fine.
So, this might be a good patch...
Unfortunately, it is night time in India, so Ashok may only comment in
some hours...
Thank you,
Harald
Am 21.12.2017 um 18:34 schrieb Dipl. Ing. Sergey G. Brester:
> Hi Harald,
>
> in VS "inline" is normally for C++ only, for C it can be defined like:
>
> nmake -nologo -f makefile.vc TCLDIR=%TCLDIR% OPTS=...
> OPTDEFINES="*-Dinline=__inline*"
>
> No idea which parameter exactly can be used to extend options from
> command-line by tdbcodbc (OPTDEFINES, ADDOPTDEFINES, OPTIMIZATIONS, etc.)...
> Just take a look in rules.vc resp. makefile.vc for it...
>
> Regards,
> Sergey.
>
> Am 21.12.2017 18:16, schrieb Harald Oehlmann:
>
>> Dear folks,
>>
>> I think I have overlooked an issue.
>>
>> Here is a compilation error in tdbcodbc.c
>>
>> tdbcodbc.c
>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1009) :
>> error C2054: expected '(' to follow 'inline'
>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) :
>> error C2082: redefinition of formal parameter 'LookupOdbcType'
>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) :
>> error C2143: syntax error : missing ';' before '{'
>>
>> This is MSVC 6++ win32 compilation. There is normally a macro which uses
>> "_inline", as the inline keyword does not exist on MSVC6.
>>
>> Thank you,
>> Harald
>>
>>
>> Am 21.12.2017 um 16:40 schrieb Harald Oehlmann:
>>> Dear Donald, big christmas present to the community ! Now it compiles
>>> well. Here are the test differences compared to tcl 8.6.7, details
>>> below: New failures: Tk: imgPNG-3.1, textTag-18.1 Still failing: Tcl:
>>> cmdAH-25.3.1 fCmd-9.9 fCmd-9.11 iortrans-11.1 iortrans-11.2
>>> winFCmd-2.8 iTCL: sfbug-254 sfbug-257 Tk: winfont-2.7 winfont-2.8
>>> winfont-2.9 Thank you, great ! Harald -- Details -- ==== imgPNG-3.1
>>> reading image with unknown ancillary chunk - bug [1c659ef0f1] FAILED
>>> ==== Contents of test case: # the image contains an unknown chunk
>>> iDOT # since the name of this chunk starts with a lowercase letter, #
>>> it's an ancillary chunk that shall not trigger an error catch {set i
>>> [image create photo -file $fileName]} ---- Result was: 1 ---- Result
>>> should have been (exact matching): 0 ---- Test cleanup failed: image
>>> "image19" doesn't exist ---- errorInfo(cleanup): image "image19"
>>> doesn't exist while executing "image delete $i" ("uplevel" body line
>>> 2) invoked from within "uplevel 1 $cleanup" ---- errorCode(cleanup):
>>> TK LOOKUP IMAGE image19 ==== imgPNG-3.1 FAILED ==== textTag-18.1
>>> TkTextPickCurrent tag bindings FAILED ==== Contents of test case:
>>> text .t -width 30 -height 4 -relief sunken -borderwidth 10
>>> -highlightthickness 10 -pady 2 pack .t .t insert end " Tag here " TAG
>>> " no tag here" .t tag configure TAG -borderwidth 4 -relief raised .t
>>> tag bind TAG <Enter> {lappend res "%x %y tag-Enter"} .t tag bind TAG
>>> <Leave> {lappend res "%x %y tag-Leave"} bind .t <Enter> {lappend res
>>> Enter} bind .t <Leave> {lappend res Leave} set res {} # Bindings must
>>> not trigger on the widget border, only over # the actual tagged
>>> characters themselves. event gen .t <Motion> -warp 1 -x 0 -y 0 ;
>>> update event gen .t <Motion> -warp 1 -x 10 -y 10 ; update event gen
>>> .t <Motion> -warp 1 -x 25 -y 25 ; update event gen .t <Motion> -warp
>>> 1 -x 20 -y 20 ; update event gen .t <Motion> -warp 1 -x 10 -y 10 ;
>>> update event gen .t <Motion> -warp 1 -x 25 -y 25 ; update return $res
>>> ---- Result was: {25 25 tag-Enter} {20 20 tag-Leave} {25 25
>>> tag-Enter} ---- Result should have been (exact matching): Enter {25
>>> 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter} ==== textTag-18.1
>>> FAILED
>>> ------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________ Tcl-Core mailing list
>>> Tcl...@li...
>>> <mailto:Tcl...@li...>
>>> https://lists.sourceforge.net/lists/listinfo/tcl-core
>> --
>> ELMICRON Dr. Harald Oehlmann GmbH
>> Koesener Str. 85
>> 06618 NAUMBURG - Germany
>> Phone: +49 (0)3445 78112-0
>> Fax: +49 (0)3445 78112-19
>> www.Elmicron.de <http://www.Elmicron.de>
>> German legal references:
>> Geschaeftsfuehrer: Dr. Harald Oehlmann, Jens Oehlmann
>> UST Nr. / VAT ID No.: DE206105272
>> HRB 212803 Stendal
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Tcl-Core mailing list
>> Tcl...@li... <mailto:Tcl...@li...>
>> https://lists.sourceforge.net/lists/listinfo/tcl-core
--
ELMICRON Dr. Harald Oehlmann GmbH
Koesener Str. 85
06618 NAUMBURG - Germany
Phone: +49 (0)3445 78112-0
Fax: +49 (0)3445 78112-19
www.Elmicron.de
German legal references:
Geschaeftsfuehrer: Dr. Harald Oehlmann, Jens Oehlmann
UST Nr. / VAT ID No.: DE206105272
HRB 212803 Stendal
|
|
From: Donald G P. <don...@ni...> - 2017-12-21 18:09:34
|
A search through this checkin http://core.tcl.tk/tdbcodbc/info/30d9cacca17c347f makes clear that the TIP 477 work resulted in the loss of a -Dinline=__inline Restoring it in PRJ_DEFINES makes as much sense to me as anything, and has the benefit of being tested. I will make that change. If there's a better approach we should use instead, we can move to it in the next release. DGP On 12/21/2017 12:59 PM, Harald Oehlmann wrote: > Sergey, > thank you for the message. > > I have found: > PRJ_DEFINES = -DTCL_TOMMATH -DMP_PREC=4 -Dinline=__inline -DHAVE_ZLIB=1 > -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE > in line 356 of win/makefile.vc > > if I insert: > PRJ_DEFINES = -Dinline=__inline > as line 73 of pkgs/tdbcodbc1.0.6/win/Makefile.vc > > all compiles fine. > > So, this might be a good patch... > > Unfortunately, it is night time in India, so Ashok may only comment in > some hours... > > Thank you, > Harald > > > > Am 21.12.2017 um 18:34 schrieb Dipl. Ing. Sergey G. Brester: >> Hi Harald, >> >> in VS "inline" is normally for C++ only, for C it can be defined like: >> >> nmake -nologo -f makefile.vc TCLDIR=%TCLDIR% OPTS=... >> OPTDEFINES="*-Dinline=__inline*" >> >> No idea which parameter exactly can be used to extend options from >> command-line by tdbcodbc (OPTDEFINES, ADDOPTDEFINES, OPTIMIZATIONS, etc.)... >> Just take a look in rules.vc resp. makefile.vc for it... >> >> Regards, >> Sergey. >> >> Am 21.12.2017 18:16, schrieb Harald Oehlmann: >> >>> Dear folks, >>> >>> I think I have overlooked an issue. >>> >>> Here is a compilation error in tdbcodbc.c >>> >>> tdbcodbc.c >>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1009) : >>> error C2054: expected '(' to follow 'inline' >>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) : >>> error C2082: redefinition of formal parameter 'LookupOdbcType' >>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) : >>> error C2143: syntax error : missing ';' before '{' >>> >>> This is MSVC 6++ win32 compilation. There is normally a macro which uses >>> "_inline", as the inline keyword does not exist on MSVC6. >>> >>> Thank you, >>> Harald >>> >>> >>> Am 21.12.2017 um 16:40 schrieb Harald Oehlmann: >>>> Dear Donald, big christmas present to the community ! Now it compiles >>>> well. Here are the test differences compared to tcl 8.6.7, details >>>> below: New failures: Tk: imgPNG-3.1, textTag-18.1 Still failing: Tcl: >>>> cmdAH-25.3.1 fCmd-9.9 fCmd-9.11 iortrans-11.1 iortrans-11.2 >>>> winFCmd-2.8 iTCL: sfbug-254 sfbug-257 Tk: winfont-2.7 winfont-2.8 >>>> winfont-2.9 Thank you, great ! Harald -- Details -- ==== imgPNG-3.1 >>>> reading image with unknown ancillary chunk - bug [1c659ef0f1] FAILED >>>> ==== Contents of test case: # the image contains an unknown chunk >>>> iDOT # since the name of this chunk starts with a lowercase letter, # >>>> it's an ancillary chunk that shall not trigger an error catch {set i >>>> [image create photo -file $fileName]} ---- Result was: 1 ---- Result >>>> should have been (exact matching): 0 ---- Test cleanup failed: image >>>> "image19" doesn't exist ---- errorInfo(cleanup): image "image19" >>>> doesn't exist while executing "image delete $i" ("uplevel" body line >>>> 2) invoked from within "uplevel 1 $cleanup" ---- errorCode(cleanup): >>>> TK LOOKUP IMAGE image19 ==== imgPNG-3.1 FAILED ==== textTag-18.1 >>>> TkTextPickCurrent tag bindings FAILED ==== Contents of test case: >>>> text .t -width 30 -height 4 -relief sunken -borderwidth 10 >>>> -highlightthickness 10 -pady 2 pack .t .t insert end " Tag here " TAG >>>> " no tag here" .t tag configure TAG -borderwidth 4 -relief raised .t >>>> tag bind TAG <Enter> {lappend res "%x %y tag-Enter"} .t tag bind TAG >>>> <Leave> {lappend res "%x %y tag-Leave"} bind .t <Enter> {lappend res >>>> Enter} bind .t <Leave> {lappend res Leave} set res {} # Bindings must >>>> not trigger on the widget border, only over # the actual tagged >>>> characters themselves. event gen .t <Motion> -warp 1 -x 0 -y 0 ; >>>> update event gen .t <Motion> -warp 1 -x 10 -y 10 ; update event gen >>>> .t <Motion> -warp 1 -x 25 -y 25 ; update event gen .t <Motion> -warp >>>> 1 -x 20 -y 20 ; update event gen .t <Motion> -warp 1 -x 10 -y 10 ; >>>> update event gen .t <Motion> -warp 1 -x 25 -y 25 ; update return $res >>>> ---- Result was: {25 25 tag-Enter} {20 20 tag-Leave} {25 25 >>>> tag-Enter} ---- Result should have been (exact matching): Enter {25 >>>> 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter} ==== textTag-18.1 >>>> FAILED >>>> ------------------------------------------------------------------------------ >>>> Check out the vibrant tech community on one of the world's most >>>> engaging tech sites, Slashdot.org! https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm.link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=Bb%2BDHvUgoVmWSCQidc6%2BayUmZnHTAbowyKzgzanNtYY%3D&reserved=0 >>>> _______________________________________________ Tcl-Core mailing list >>>> Tcl...@li... >>>> <mailto:Tcl...@li...> >>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=CHUMRtsnIZpKdybs5u1xmnnRFRgLKY5zOM7n3%2FUBRmU%3D&reserved=0 >>> -- >>> ELMICRON Dr. Harald Oehlmann GmbH >>> Koesener Str. 85 >>> 06618 NAUMBURG - Germany >>> Phone: +49 (0)3445 78112-0 >>> Fax: +49 (0)3445 78112-19 >>> https://na01.safelinks.protection.outlook.com/?url=www.Elmicron.de&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=hWyvhioMCUHW2KK20f78HRq19RgS1ea9sXGwma%2FdUQ0%3D&reserved=0 <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.Elmicron.de&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=xHokt3rwVaLuP%2F1QzUOonxB%2Bu24eH518pQTyUqQc2tk%3D&reserved=0> >>> German legal references: >>> Geschaeftsfuehrer: Dr. Harald Oehlmann, Jens Oehlmann >>> UST Nr. / VAT ID No.: DE206105272 >>> HRB 212803 Stendal >>> >>> ------------------------------------------------------------------------------ >>> Check out the vibrant tech community on one of the world's most >>> engaging tech sites, Slashdot.org! https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm.link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=Bb%2BDHvUgoVmWSCQidc6%2BayUmZnHTAbowyKzgzanNtYY%3D&reserved=0 >>> _______________________________________________ >>> Tcl-Core mailing list >>> Tcl...@li... <mailto:Tcl...@li...> >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=CHUMRtsnIZpKdybs5u1xmnnRFRgLKY5zOM7n3%2FUBRmU%3D&reserved=0 > > -- | Don Porter Applied and Computational Mathematics Division | | don...@ni... Information Technology Laboratory | | http://math.nist.gov/~DPorter/ NIST | |______________________________________________________________________| |
|
From: Donald G P. <don...@ni...> - 2017-12-21 18:23:15
|
On 12/21/2017 01:09 PM, Donald G Porter wrote: > I will make that change. Relevant RCs updated. -- | Don Porter Applied and Computational Mathematics Division | | don...@ni... Information Technology Laboratory | | http://math.nist.gov/~DPorter/ NIST | |______________________________________________________________________| |
|
From: François V. <fvo...@fr...> - 2017-12-21 19:14:46
|
Le 21/12/2017 16:40, Harald Oehlmann a écrit :
> New failures:
>
> Tk: imgPNG-3.1
This is a test newly added. It uses a newly added image. Suspect this
image file could be missing from the distribution or installation?
Can you check that you have an image named (iDOT.png) in the same tests
folder named "tests" that contains the imgPNG.test file?
If the image is missing, that's the cause.
If it's present then please provide the output of:
set filename XXXXX ; # replace XXXXX by full pathname of file iDOT.png
image create photo -file $fileName ; # what is the error triggered
here?
> textTag-18.1
> ==== textTag-18.1 TkTextPickCurrent tag bindings FAILED
> ==== Contents of test case:
>
> text .t -width 30 -height 4 -relief sunken -borderwidth 10
> -highlightthickness 10 -pady 2
> pack .t
>
> .t insert end " Tag here " TAG " no tag here"
> .t tag configure TAG -borderwidth 4 -relief raised
> .t tag bind TAG <Enter> {lappend res "%x %y tag-Enter"}
> .t tag bind TAG <Leave> {lappend res "%x %y tag-Leave"}
> bind .t <Enter> {lappend res Enter}
> bind .t <Leave> {lappend res Leave}
>
> set res {}
> # Bindings must not trigger on the widget border, only over
> # the actual tagged characters themselves.
> event gen .t <Motion> -warp 1 -x 0 -y 0 ; update
> event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
> event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
> event gen .t <Motion> -warp 1 -x 20 -y 20 ; update
> event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
> event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
> return $res
>
> ---- Result was:
> {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
> ---- Result should have been (exact matching):
> Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
> ==== textTag-18.1 FAILED
Surprising.
Are you sure this fails repeatably (an event is missing, did you fiddle
with the computer while the tests were running?) ?
Are you sure it didn't fail with the previous release?
Thanks,
Francois
|
|
From: Donald G P. <don...@ni...> - 2017-12-21 19:46:47
|
On 12/21/2017 02:14 PM, François Vogel wrote: > Can you check that you have an image named (iDOT.png) in the same tests > folder named "tests" that contains the imgPNG.test file? > > If the image is missing, that's the cause. It is; working on the fix.... -- | Don Porter Applied and Computational Mathematics Division | | don...@ni... Information Technology Laboratory | | http://math.nist.gov/~DPorter/ NIST | |______________________________________________________________________| |
Thanks for helping keep SourceForge clean.
X