From: SourceForge.net <no...@so...> - 2006-06-30 16:41:47
|
Patches item #1515234, was opened at 2006-06-30 16:41 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1515234&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: afredd (afredd) Assigned to: Nobody/Anonymous (nobody) Summary: Removing commas is slimming! Initial Comment: There are a large number of cases where string literals passsed to vararg functions are split over multiple lines but with a comma separating them. The most common are in calls to Tcl_AppendResult. By removing the comma separating the string literals, you save all round: * smaller object code (one less function argument to push) * one less '\0' in the strings table * faster run time (one less time round the varargs handling code) * smaller source code! Attached is a file containing all the occurences i could grep out of the Tcl source (there are more in Tk too) plus a patch for the first file in the list. I'll submit patches for the rest if someone's willing to apply them... although the changes are absurdly trivial :-) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1515234&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-08-05 23:26:28
|
Patches item #1515234, was opened at 2006-06-30 17:41 Message generated for change (Settings changed) made by dkf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1515234&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: afredd (afredd) >Assigned to: Don Porter (dgp) Summary: Removing commas is slimming! Initial Comment: There are a large number of cases where string literals passsed to vararg functions are split over multiple lines but with a comma separating them. The most common are in calls to Tcl_AppendResult. By removing the comma separating the string literals, you save all round: * smaller object code (one less function argument to push) * one less '\0' in the strings table * faster run time (one less time round the varargs handling code) * smaller source code! Attached is a file containing all the occurences i could grep out of the Tcl source (there are more in Tk too) plus a patch for the first file in the list. I'll submit patches for the rest if someone's willing to apply them... although the changes are absurdly trivial :-) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1515234&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-08-09 17:54:20
|
Patches item #1515234, was opened at 2006-06-30 12:41 Message generated for change (Settings changed) made by dgp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1515234&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None >Priority: 3 Submitted By: afredd (afredd) >Assigned to: Kevin B KENNY (kennykb) Summary: Removing commas is slimming! Initial Comment: There are a large number of cases where string literals passsed to vararg functions are split over multiple lines but with a comma separating them. The most common are in calls to Tcl_AppendResult. By removing the comma separating the string literals, you save all round: * smaller object code (one less function argument to push) * one less '\0' in the strings table * faster run time (one less time round the varargs handling code) * smaller source code! Attached is a file containing all the occurences i could grep out of the Tcl source (there are more in Tk too) plus a patch for the first file in the list. I'll submit patches for the rest if someone's willing to apply them... although the changes are absurdly trivial :-) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1515234&group_id=10894 |
From: SourceForge.net <no...@so...> - 2007-04-20 06:12:29
|
Patches item #1515234, was opened at 2006-06-30 12:41 Message generated for change (Comment added) made by kennykb You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1515234&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 3 Private: No Submitted By: afredd (afredd) Assigned to: Kevin B KENNY (kennykb) Summary: Removing commas is slimming! Initial Comment: There are a large number of cases where string literals passsed to vararg functions are split over multiple lines but with a comma separating them. The most common are in calls to Tcl_AppendResult. By removing the comma separating the string literals, you save all round: * smaller object code (one less function argument to push) * one less '\0' in the strings table * faster run time (one less time round the varargs handling code) * smaller source code! Attached is a file containing all the occurences i could grep out of the Tcl source (there are more in Tk too) plus a patch for the first file in the list. I'll submit patches for the rest if someone's willing to apply them... although the changes are absurdly trivial :-) ---------------------------------------------------------------------- >Comment By: Kevin B KENNY (kennykb) Date: 2007-04-20 02:12 Message: Logged In: YES user_id=99768 Originator: NO Sure, couldn't hurt. Unlikely to help much, but might as well put it in. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1515234&group_id=10894 |