From: SourceForge.net <no...@so...> - 2006-06-25 14:25:49
|
Feature Requests item #1512138, was opened at 2006-06-25 11:25 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 10. Objects Group: None Status: Open Resolution: None Priority: 5 Submitted By: miguel sofer (msofer) Assigned to: Donal K. Fellows (dkf) Summary: Signal obj deletion vs. shimmering Initial Comment: In a discussion on TCLCORE, jcw requested the possibility to determine if the obj is being deleted or shimmered when he receives a cal to its freeIntRepProc (a link to the discussion will be added here when the tclcore archives return online). This patch implements this possibility by insuring that on deletion the string rep is invalidated first, and indicating the fact that the string rep is invalid by a negative length. Note that a NULL string rep cannot be used to signal this fact, as the bytes field is currently used to implement the deletion stack. A negative length will always indicate that the object is being freed: - if the obj is being freed, the stringrep is always invalidated and the length set to -1 before calling the freeIntRepProc - if the obj is being shimmered, the setFromAnyProc of the new type will have insured that a string rep is available before freeing the old intrep. This looks pretty safe and cheap to me; requesting review by dkf before commit. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-06-30 08:14:37
|
Feature Requests item #1512138, was opened at 2006-06-25 15:25 Message generated for change (Comment added) made by dkf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 10. Objects Group: None Status: Open Resolution: None Priority: 5 Submitted By: miguel sofer (msofer) >Assigned to: miguel sofer (msofer) Summary: Signal obj deletion vs. shimmering Initial Comment: In a discussion on TCLCORE, jcw requested the possibility to determine if the obj is being deleted or shimmered when he receives a cal to its freeIntRepProc (a link to the discussion will be added here when the tclcore archives return online). This patch implements this possibility by insuring that on deletion the string rep is invalidated first, and indicating the fact that the string rep is invalid by a negative length. Note that a NULL string rep cannot be used to signal this fact, as the bytes field is currently used to implement the deletion stack. A negative length will always indicate that the object is being freed: - if the obj is being freed, the stringrep is always invalidated and the length set to -1 before calling the freeIntRepProc - if the obj is being shimmered, the setFromAnyProc of the new type will have insured that a string rep is available before freeing the old intrep. This looks pretty safe and cheap to me; requesting review by dkf before commit. ---------------------------------------------------------------------- >Comment By: Donal K. Fellows (dkf) Date: 2006-06-30 09:14 Message: Logged In: YES user_id=79902 Patch looks OK modulo one or two comment-formatting points, but please add a function (exported through tclInt.decls) for checking whether an object is being deleted. This will help to ensure that extensions do not encode the information that length==-1 is magical, and should prevent pain later on. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-09-29 18:04:44
|
Feature Requests item #1512138, was opened at 2006-06-25 11:25 Message generated for change (Settings changed) made by msofer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 10. Objects Group: None Status: Open Resolution: None >Priority: 8 Submitted By: miguel sofer (msofer) Assigned to: miguel sofer (msofer) Summary: Signal obj deletion vs. shimmering Initial Comment: In a discussion on TCLCORE, jcw requested the possibility to determine if the obj is being deleted or shimmered when he receives a cal to its freeIntRepProc (a link to the discussion will be added here when the tclcore archives return online). This patch implements this possibility by insuring that on deletion the string rep is invalidated first, and indicating the fact that the string rep is invalid by a negative length. Note that a NULL string rep cannot be used to signal this fact, as the bytes field is currently used to implement the deletion stack. A negative length will always indicate that the object is being freed: - if the obj is being freed, the stringrep is always invalidated and the length set to -1 before calling the freeIntRepProc - if the obj is being shimmered, the setFromAnyProc of the new type will have insured that a string rep is available before freeing the old intrep. This looks pretty safe and cheap to me; requesting review by dkf before commit. ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2006-06-30 05:14 Message: Logged In: YES user_id=79902 Patch looks OK modulo one or two comment-formatting points, but please add a function (exported through tclInt.decls) for checking whether an object is being deleted. This will help to ensure that extensions do not encode the information that length==-1 is magical, and should prevent pain later on. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-09-30 14:28:10
|
Feature Requests item #1512138, was opened at 2006-06-25 11:25 Message generated for change (Comment added) made by msofer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 10. Objects Group: None Status: Open Resolution: None Priority: 8 Submitted By: miguel sofer (msofer) Assigned to: miguel sofer (msofer) Summary: Signal obj deletion vs. shimmering Initial Comment: In a discussion on TCLCORE, jcw requested the possibility to determine if the obj is being deleted or shimmered when he receives a cal to its freeIntRepProc (a link to the discussion will be added here when the tclcore archives return online). This patch implements this possibility by insuring that on deletion the string rep is invalidated first, and indicating the fact that the string rep is invalid by a negative length. Note that a NULL string rep cannot be used to signal this fact, as the bytes field is currently used to implement the deletion stack. A negative length will always indicate that the object is being freed: - if the obj is being freed, the stringrep is always invalidated and the length set to -1 before calling the freeIntRepProc - if the obj is being shimmered, the setFromAnyProc of the new type will have insured that a string rep is available before freeing the old intrep. This looks pretty safe and cheap to me; requesting review by dkf before commit. ---------------------------------------------------------------------- >Comment By: miguel sofer (msofer) Date: 2006-09-30 11:28 Message: Logged In: YES user_id=148712 The tclcore thread is at http://aspn.activestate.com/ASPN/Mail/Message/3168511 ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2006-06-30 05:14 Message: Logged In: YES user_id=79902 Patch looks OK modulo one or two comment-formatting points, but please add a function (exported through tclInt.decls) for checking whether an object is being deleted. This will help to ensure that extensions do not encode the information that length==-1 is magical, and should prevent pain later on. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-09-30 19:01:57
|
Feature Requests item #1512138, was opened at 2006-06-25 11:25 Message generated for change (Comment added) made by msofer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 10. Objects Group: None >Status: Closed >Resolution: Accepted Priority: 8 Submitted By: miguel sofer (msofer) Assigned to: miguel sofer (msofer) Summary: Signal obj deletion vs. shimmering Initial Comment: In a discussion on TCLCORE, jcw requested the possibility to determine if the obj is being deleted or shimmered when he receives a cal to its freeIntRepProc (a link to the discussion will be added here when the tclcore archives return online). This patch implements this possibility by insuring that on deletion the string rep is invalidated first, and indicating the fact that the string rep is invalid by a negative length. Note that a NULL string rep cannot be used to signal this fact, as the bytes field is currently used to implement the deletion stack. A negative length will always indicate that the object is being freed: - if the obj is being freed, the stringrep is always invalidated and the length set to -1 before calling the freeIntRepProc - if the obj is being shimmered, the setFromAnyProc of the new type will have insured that a string rep is available before freeing the old intrep. This looks pretty safe and cheap to me; requesting review by dkf before commit. ---------------------------------------------------------------------- >Comment By: miguel sofer (msofer) Date: 2006-09-30 16:01 Message: Logged In: YES user_id=148712 Revised patch committed, provides the new function int TclObjBeingDeleted(Tcl_Obj *objPtr) in the internal stubs table. ---------------------------------------------------------------------- Comment By: miguel sofer (msofer) Date: 2006-09-30 11:28 Message: Logged In: YES user_id=148712 The tclcore thread is at http://aspn.activestate.com/ASPN/Mail/Message/3168511 ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2006-06-30 05:14 Message: Logged In: YES user_id=79902 Patch looks OK modulo one or two comment-formatting points, but please add a function (exported through tclInt.decls) for checking whether an object is being deleted. This will help to ensure that extensions do not encode the information that length==-1 is magical, and should prevent pain later on. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-10-02 10:46:50
|
Feature Requests item #1512138, was opened at 2006-06-25 11:25 Message generated for change (Comment added) made by msofer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 10. Objects Group: None >Status: Open Resolution: Accepted Priority: 8 Submitted By: miguel sofer (msofer) Assigned to: miguel sofer (msofer) Summary: Signal obj deletion vs. shimmering Initial Comment: In a discussion on TCLCORE, jcw requested the possibility to determine if the obj is being deleted or shimmered when he receives a cal to its freeIntRepProc (a link to the discussion will be added here when the tclcore archives return online). This patch implements this possibility by insuring that on deletion the string rep is invalidated first, and indicating the fact that the string rep is invalid by a negative length. Note that a NULL string rep cannot be used to signal this fact, as the bytes field is currently used to implement the deletion stack. A negative length will always indicate that the object is being freed: - if the obj is being freed, the stringrep is always invalidated and the length set to -1 before calling the freeIntRepProc - if the obj is being shimmered, the setFromAnyProc of the new type will have insured that a string rep is available before freeing the old intrep. This looks pretty safe and cheap to me; requesting review by dkf before commit. ---------------------------------------------------------------------- >Comment By: miguel sofer (msofer) Date: 2006-10-02 07:46 Message: Logged In: YES user_id=148712 Missing tests in the testsuite! ---------------------------------------------------------------------- Comment By: miguel sofer (msofer) Date: 2006-09-30 16:01 Message: Logged In: YES user_id=148712 Revised patch committed, provides the new function int TclObjBeingDeleted(Tcl_Obj *objPtr) in the internal stubs table. ---------------------------------------------------------------------- Comment By: miguel sofer (msofer) Date: 2006-09-30 11:28 Message: Logged In: YES user_id=148712 The tclcore thread is at http://aspn.activestate.com/ASPN/Mail/Message/3168511 ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2006-06-30 05:14 Message: Logged In: YES user_id=79902 Patch looks OK modulo one or two comment-formatting points, but please add a function (exported through tclInt.decls) for checking whether an object is being deleted. This will help to ensure that extensions do not encode the information that length==-1 is magical, and should prevent pain later on. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1512138&group_id=10894 |