From: SourceForge.net <no...@so...> - 2005-08-11 16:34:25
|
Patches item #1256872, was opened at 2005-08-11 20:34 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None Status: Open Resolution: None Priority: 5 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Andreas Kupries (andreas_kupries) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2005-08-11 17:51:54
|
Patches item #1256872, was opened at 2005-08-11 12:34 Message generated for change (Comment added) made by dgp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None Status: Open Resolution: None Priority: 5 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Andreas Kupries (andreas_kupries) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Don Porter (dgp) Date: 2005-08-11 13:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2005-08-11 18:19:32
|
Patches item #1256872, was opened at 2005-08-11 20:34 Message generated for change (Comment added) made by a_kovalenko You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None Status: Open Resolution: None Priority: 5 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Andreas Kupries (andreas_kupries) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 22:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 21:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2005-08-11 21:16:59
|
Patches item #1256872, was opened at 2005-08-11 09:34 Message generated for change (Comment added) made by hobbs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None Status: Open Resolution: None >Priority: 7 Submitted By: Anton Kovalenko (a_kovalenko) >Assigned to: David Gravereaux (davygrvy) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-11 14:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 11:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 10:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2005-08-16 04:46:32
|
Patches item #1256872, was opened at 2005-08-11 09:34 Message generated for change (Comment added) made by davygrvy You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None Status: Open Resolution: None Priority: 7 Submitted By: Anton Kovalenko (a_kovalenko) >Assigned to: Jeffrey Hobbs (hobbs) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: David Gravereaux (davygrvy) Date: 2005-08-15 21:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-11 14:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 11:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 10:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2005-08-23 22:43:29
|
Patches item #1256872, was opened at 2005-08-11 20:34 Message generated for change (Comment added) made by a_kovalenko You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None Status: Open Resolution: None Priority: 7 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Jeffrey Hobbs (hobbs) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-24 02:43 Message: Logged In: YES user_id=241496 Sorry to all, There was a typo in the first variant of this patch (ReadConsoleW and WriteConsoleW were mistakenly used on non-unicode systems). Fixed (new variant attached). ---------------------------------------------------------------------- Comment By: David Gravereaux (davygrvy) Date: 2005-08-16 08:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-12 01:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 22:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 21:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2005-11-03 01:18:45
|
Patches item #1256872, was opened at 2005-08-11 17:34 Message generated for change (Comment added) made by patthoyts You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None >Status: Closed >Resolution: Accepted Priority: 7 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Jeffrey Hobbs (hobbs) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Pat Thoyts (patthoyts) Date: 2005-11-03 01:18 Message: Logged In: YES user_id=202636 Works fine for me. Test suite passes and now the console can output cyrillic chars and so on. Seeing the positive comments from david - applied. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-23 23:43 Message: Logged In: YES user_id=241496 Sorry to all, There was a typo in the first variant of this patch (ReadConsoleW and WriteConsoleW were mistakenly used on non-unicode systems). Fixed (new variant attached). ---------------------------------------------------------------------- Comment By: David Gravereaux (davygrvy) Date: 2005-08-16 05:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-11 22:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 19:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 18:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2005-11-03 09:09:01
|
Patches item #1256872, was opened at 2005-08-11 17:34 Message generated for change (Comment added) made by dkf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None >Status: Open Resolution: Accepted >Priority: 8 Submitted By: Anton Kovalenko (a_kovalenko) >Assigned to: Pat Thoyts (patthoyts) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Donal K. Fellows (dkf) Date: 2005-11-03 09:08 Message: Logged In: YES user_id=79902 Backport to 8.4 needed ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-03 01:18 Message: Logged In: YES user_id=202636 Works fine for me. Test suite passes and now the console can output cyrillic chars and so on. Seeing the positive comments from david - applied. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-23 23:43 Message: Logged In: YES user_id=241496 Sorry to all, There was a typo in the first variant of this patch (ReadConsoleW and WriteConsoleW were mistakenly used on non-unicode systems). Fixed (new variant attached). ---------------------------------------------------------------------- Comment By: David Gravereaux (davygrvy) Date: 2005-08-16 05:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-11 22:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 19:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 18:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2005-11-03 10:10:10
|
Patches item #1256872, was opened at 2005-08-11 20:34 Message generated for change (Comment added) made by a_kovalenko You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None Status: Open Resolution: Accepted Priority: 8 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Pat Thoyts (patthoyts) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-11-03 13:10 Message: Logged In: YES user_id=241496 Backport done (tcl-winunicon2-8-4.patch). ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2005-11-03 12:08 Message: Logged In: YES user_id=79902 Backport to 8.4 needed ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-03 04:18 Message: Logged In: YES user_id=202636 Works fine for me. Test suite passes and now the console can output cyrillic chars and so on. Seeing the positive comments from david - applied. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-24 02:43 Message: Logged In: YES user_id=241496 Sorry to all, There was a typo in the first variant of this patch (ReadConsoleW and WriteConsoleW were mistakenly used on non-unicode systems). Fixed (new variant attached). ---------------------------------------------------------------------- Comment By: David Gravereaux (davygrvy) Date: 2005-08-16 08:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-12 01:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 22:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 21:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2005-11-03 11:58:27
|
Patches item #1256872, was opened at 2005-08-11 17:34 Message generated for change (Comment added) made by patthoyts You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None >Status: Closed Resolution: Accepted Priority: 8 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Pat Thoyts (patthoyts) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Pat Thoyts (patthoyts) Date: 2005-11-03 11:58 Message: Logged In: YES user_id=202636 Oh - well I just committed a backport already :) Thank you anyway. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-11-03 10:10 Message: Logged In: YES user_id=241496 Backport done (tcl-winunicon2-8-4.patch). ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2005-11-03 09:08 Message: Logged In: YES user_id=79902 Backport to 8.4 needed ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-03 01:18 Message: Logged In: YES user_id=202636 Works fine for me. Test suite passes and now the console can output cyrillic chars and so on. Seeing the positive comments from david - applied. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-23 23:43 Message: Logged In: YES user_id=241496 Sorry to all, There was a typo in the first variant of this patch (ReadConsoleW and WriteConsoleW were mistakenly used on non-unicode systems). Fixed (new variant attached). ---------------------------------------------------------------------- Comment By: David Gravereaux (davygrvy) Date: 2005-08-16 05:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-11 22:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 19:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 18:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-01-24 17:22:11
|
Patches item #1256872, was opened at 2005-08-11 09:34 Message generated for change (Settings changed) made by hobbs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None >Status: Open Resolution: Accepted Priority: 8 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Pat Thoyts (patthoyts) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Jeffrey Hobbs (hobbs) Date: 2006-01-24 09:22 Message: Logged In: YES user_id=72656 Reopening - this caused Expect for Windows to break. We need to revisit whether this is a core issue that may effect other extensions, or whether Expect for Windows must adapt. ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-03 03:58 Message: Logged In: YES user_id=202636 Oh - well I just committed a backport already :) Thank you anyway. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-11-03 02:10 Message: Logged In: YES user_id=241496 Backport done (tcl-winunicon2-8-4.patch). ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2005-11-03 01:08 Message: Logged In: YES user_id=79902 Backport to 8.4 needed ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-02 17:18 Message: Logged In: YES user_id=202636 Works fine for me. Test suite passes and now the console can output cyrillic chars and so on. Seeing the positive comments from david - applied. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-23 15:43 Message: Logged In: YES user_id=241496 Sorry to all, There was a typo in the first variant of this patch (ReadConsoleW and WriteConsoleW were mistakenly used on non-unicode systems). Fixed (new variant attached). ---------------------------------------------------------------------- Comment By: David Gravereaux (davygrvy) Date: 2005-08-15 21:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-11 14:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 11:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 10:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-02-28 21:59:25
|
Patches item #1256872, was opened at 2005-08-11 09:34 Message generated for change (Comment added) made by hobbs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None >Status: Closed >Resolution: Fixed Priority: 8 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Pat Thoyts (patthoyts) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Jeffrey Hobbs (hobbs) Date: 2006-02-28 13:59 Message: Logged In: YES user_id=72656 This was addressed in Expect, updated to track channel encodings. ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2006-01-24 09:22 Message: Logged In: YES user_id=72656 Reopening - this caused Expect for Windows to break. We need to revisit whether this is a core issue that may effect other extensions, or whether Expect for Windows must adapt. ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-03 03:58 Message: Logged In: YES user_id=202636 Oh - well I just committed a backport already :) Thank you anyway. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-11-03 02:10 Message: Logged In: YES user_id=241496 Backport done (tcl-winunicon2-8-4.patch). ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2005-11-03 01:08 Message: Logged In: YES user_id=79902 Backport to 8.4 needed ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-02 17:18 Message: Logged In: YES user_id=202636 Works fine for me. Test suite passes and now the console can output cyrillic chars and so on. Seeing the positive comments from david - applied. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-23 15:43 Message: Logged In: YES user_id=241496 Sorry to all, There was a typo in the first variant of this patch (ReadConsoleW and WriteConsoleW were mistakenly used on non-unicode systems). Fixed (new variant attached). ---------------------------------------------------------------------- Comment By: David Gravereaux (davygrvy) Date: 2005-08-15 21:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-11 14:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 11:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 10:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-03-28 21:01:57
|
Patches item #1256872, was opened at 2005-08-11 09:34 Message generated for change (Comment added) made by hobbs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None >Status: Open >Resolution: Rejected Priority: 8 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Pat Thoyts (patthoyts) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Jeffrey Hobbs (hobbs) Date: 2006-03-28 13:01 Message: Logged In: YES user_id=72656 This is being reopened because it was not a complete implementation after all. You will see the problem by running tclsh in XP and doing 'fconfigure stdin -encoding utf-8'. This should output correctly (it used to), but hangs with this patch. I have reverted for 8.4.13, but it should be reverted or corrected for 8.5. I left in the read|writeConsoleProc bits in case a corrected solution is presented that handles the internal channel encoding changes. ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2006-02-28 13:59 Message: Logged In: YES user_id=72656 This was addressed in Expect, updated to track channel encodings. ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2006-01-24 09:22 Message: Logged In: YES user_id=72656 Reopening - this caused Expect for Windows to break. We need to revisit whether this is a core issue that may effect other extensions, or whether Expect for Windows must adapt. ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-03 03:58 Message: Logged In: YES user_id=202636 Oh - well I just committed a backport already :) Thank you anyway. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-11-03 02:10 Message: Logged In: YES user_id=241496 Backport done (tcl-winunicon2-8-4.patch). ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2005-11-03 01:08 Message: Logged In: YES user_id=79902 Backport to 8.4 needed ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-02 17:18 Message: Logged In: YES user_id=202636 Works fine for me. Test suite passes and now the console can output cyrillic chars and so on. Seeing the positive comments from david - applied. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-23 15:43 Message: Logged In: YES user_id=241496 Sorry to all, There was a typo in the first variant of this patch (ReadConsoleW and WriteConsoleW were mistakenly used on non-unicode systems). Fixed (new variant attached). ---------------------------------------------------------------------- Comment By: David Gravereaux (davygrvy) Date: 2005-08-15 21:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-11 14:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 11:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 10:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |
From: SourceForge.net <no...@so...> - 2006-03-28 22:40:50
|
Patches item #1256872, was opened at 2005-08-11 09:34 Message generated for change (Comment added) made by hobbs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 27. Channel Types Group: None Status: Open Resolution: Rejected Priority: 8 Submitted By: Anton Kovalenko (a_kovalenko) Assigned to: Pat Thoyts (patthoyts) Summary: Unicode support for Win32 (NT) console channels Initial Comment: This patch, prepared agains the recent TCL8.5 CVS, makes the Win32 console channel driver use ReadConsoleW and WriteConsoleW where these functions are available (NT/2k/XP/2003), without (hopefully) breaking anything on other systems. TclWinOpenConsoleChannel will set the channel encoding to unicode when appropriate; thus all the applications that do gets/puts on the console, without resetting its options, will not notice any difference. Please let me know if such a change requires a TIP to be included. ---------------------------------------------------------------------- >Comment By: Jeffrey Hobbs (hobbs) Date: 2006-03-28 14:40 Message: Logged In: YES user_id=72656 See also comments in bug 1442305. ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2006-03-28 13:01 Message: Logged In: YES user_id=72656 This is being reopened because it was not a complete implementation after all. You will see the problem by running tclsh in XP and doing 'fconfigure stdin -encoding utf-8'. This should output correctly (it used to), but hangs with this patch. I have reverted for 8.4.13, but it should be reverted or corrected for 8.5. I left in the read|writeConsoleProc bits in case a corrected solution is presented that handles the internal channel encoding changes. ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2006-02-28 13:59 Message: Logged In: YES user_id=72656 This was addressed in Expect, updated to track channel encodings. ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2006-01-24 09:22 Message: Logged In: YES user_id=72656 Reopening - this caused Expect for Windows to break. We need to revisit whether this is a core issue that may effect other extensions, or whether Expect for Windows must adapt. ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-03 03:58 Message: Logged In: YES user_id=202636 Oh - well I just committed a backport already :) Thank you anyway. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-11-03 02:10 Message: Logged In: YES user_id=241496 Backport done (tcl-winunicon2-8-4.patch). ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2005-11-03 01:08 Message: Logged In: YES user_id=79902 Backport to 8.4 needed ---------------------------------------------------------------------- Comment By: Pat Thoyts (patthoyts) Date: 2005-11-02 17:18 Message: Logged In: YES user_id=202636 Works fine for me. Test suite passes and now the console can output cyrillic chars and so on. Seeing the positive comments from david - applied. ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-23 15:43 Message: Logged In: YES user_id=241496 Sorry to all, There was a typo in the first variant of this patch (ReadConsoleW and WriteConsoleW were mistakenly used on non-unicode systems). Fixed (new variant attached). ---------------------------------------------------------------------- Comment By: David Gravereaux (davygrvy) Date: 2005-08-15 21:46 Message: Logged In: YES user_id=7549 I haven't seen the guts of the patch yet, but this gets my vote of approval. I can't do the work of the test/commit due to my lack of dev tools on this new computer of mine.. passing to JH ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-11 14:16 Message: Logged In: YES user_id=72656 I think this is a candidate for 8.4 and 8.5 (no compat issues). ---------------------------------------------------------------------- Comment By: Anton Kovalenko (a_kovalenko) Date: 2005-08-11 11:19 Message: Logged In: YES user_id=241496 Tcl RFE 491789 is unrelated to this patch (though I was thinking, while submitting this patch, about GetCommandLineW as a next step to better unicode support). This patch is not about command-line parameters, it's about console I/O (i.e stdin, stdout, and stderr of tclsh.exe). As TCL already has a separate channel driver for Win32 console, the required changes are minimal and they don't affect neither TCL API nor signature of Tcl_Main. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-08-11 10:51 Message: Logged In: YES user_id=80530 How does is this patch related to Tcl RFE 491789 ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1256872&group_id=10894 |