Re: [TCLCORE] New TIP #740 Enhanced Treeview Widget

[Brian O'H. <bri...@co...>]

It''s good to hear you haven't had any crashes. It's been stable for me too.

I incorporated the disabled state changes. The existing bindings only 
used -selectmode none instead of the disabled state. So to properly use 
the disabled state will take some work. For #2, I incorporated it but 
changed it to check if the font exists and if not then create it. For 
#3, I went with the 4 pixel wide version. It can always be changed 
later. Thanks for the help getting this in shape.


Something else you may want to look at is the zoom function seems to 
trigger adding extra ns padding to the entry-type widgets, but doesn't 
always remove it when its set back to 100%. Either that or the text is 
drawn at the wrong offset so it's shifted up or down (ie at top or 
bottom of entry-area instead centered) and sometimes cut-off. It's most 
noticeable in the status message area, but others do it occasionally 
too. Also the character positions don't line up with the font characters 
while zoomed. You can see it by selecting text in the entry or by moving 
the cursor to the end. Hopefully it's just me and not a larger issue.


On 12/7/25 1:00 PM, Csaba Nemethi wrote:
> Hi Brian,
>
> First off a good news: I haven't experienced any crashes for several 
> days!
>
> A few further improvement proposals:
>
> 1. In the disabled state the checkbutton indicators of the 
> CheckTreeview style should have different colors, just like the 
> ttk::checkbutton indicators.  Please find attached the "diff -u" 
> outputs showing the necessary changes in three files contained in the 
> folder library/ttk.
>
> Apropos disabled state:  In this state several interactive operations 
> (e.g., changing the selection) should be disabled.
>
> 2. Line #647 of the file library/demos/treeview.tcl should be enclosed 
> in "catch {...}", to enable a clean restart of the enhanced treeview 
> demo.
>
> 3. For consistency, line #785 of the file library/demos/treeview.tcl 
> should read
>
>         <svg width="16" height="8" version="1.1" 
> xmlns="http://www.w3.org/2000/svg">
>
> Or, if the arrowBlank image shall only create a *small* gap between 
> the text and the right edge of the heading:
>
>         <svg width="4" height="8" version="1.1" 
> xmlns="http://www.w3.org/2000/svg">
>
> I am not sure which variant is better.
>
> Best regards,
>
> Csaba
>
>
> Am 06.12.25 um 23:51 schrieb Brian O'Hagan:
>> Thanks. I've incorporated #1 and #3. The sort arrows are much nicer now.
>>
>> For #2, no it's not intentional but instead a side effect of the 
>> button states. The Check and Radio buttons use the alternate state to 
>> denote the no value (aka tri-state or no on/off value is defined) 
>> state. Since we don't set a value (we only use the selection state), 
>> then all items get the alternate state. The current logic in 
>> ttkButton.c (see CheckbuttonVariableChanged) doesn't allow a bypass 
>> for this without setting an on/off value or defining a variable. It's 
>> open work to see if there is another option.
>
>