[Tcl-bugs] [Tk] (oscarfv) tkt (Open): Fix crash on exit due to faulty asm code in DllMain

[<no...@tc...>]

Automated mail by fx, on behalf of no...@tc...

Ticket Change [2bb22b97d9035ac629fb5dbb36a2ed3b65fe015e21910529137f5f8afc49355f]
  [Fix crash on exit due to faulty asm code in DllMain]
  By      oscarfv
  For     Tk
  On      2025-11-17T16:07:56.461
  Details https://core.tcl-lang.org/tk/tinfo?name=2bb22b97d9035ac629fb5dbb36a2ed3b65fe015e21910529137f5f8afc49355f
  Ticket  https://core.tcl-lang.org/tk/tktview/44b34c61529e5cedae54e204da71af4fcfcbab5b

Changed Fields
  icomment: > The reason for this code is unknown.

            What transpires from the bug report and the commit logs is that
            sometimes an exception was thrown from TkFinalize and, instead of
            investigating its cause and fixing it, the SEH handling code was added
            to hide the exception.

            Maybe fixing the source of the exception was hard and the consequences
            of a half-done TkFinalize were considered as mild.

            My POV is that an exception in TkFinalize would be a bug on Tk and we
            should fix it. Sadly, now we are on a scenario were there is a
            suspicion of something being wrong in TkFinalize but not observing the
            problem is no proof of its nonexistence.

            I also think that SEH was used without fully understanding its
            implications. See the occurrences in Tcl, where they make no sense in
            two cases and very little sense on the third, as I mentioned on a
            previous comment. All those can be removed with confidence.
  login:    oscarfv

------------------------------------------------------------
See Tcl/Tk development @ http://core.tcl-lang.org/
------------------------------------------------------------