Re: [TCLCORE] Tcl/Tk 9.0.3 Release Candidate

[Christian W. <Chr...@t-...>]

On 11/06/2025 12:18 AM, Jan Nijtmans wrote:
> Op wo 5 nov 2025 om 21:06 schreef Paul Obermeier <pa...@po...>:
>> 1 warning during Tk compilation:
>>      Tk/generic/ttk/ttkCache.c: In function 'InitCacheWindow':
>>      Tk/generic/ttk/ttkCache.c:256:64: warning: unused parameter 'tkwin' [-Wunused-parameter]
>>      static void InitCacheWindow(Ttk_ResourceCache cache, Tk_Window tkwin)
>
> There are two ways to solve this:
> 1) change line 259 from
>         cache->tkwin = Tk_MainWindow(cache->interp);
>     to
>         cache->tkwin = tkwin;
>     this was how the line looked like originally.
>
> 2)  Replace separate 'tkwin' arguments with 'cache->tkwin' in more places.
>      Experiment:
>             https://core.tcl-lang.org/tk/info/ed67b8e0980fd5af
>
> Does anyone (Christian???) have any advice here?

Both ways are contradictory to the objective, which is to support multiple
displays plus weird combinations of visuals and colormaps. So what about
just using the much-loved TCL_UNUSED macro there? Or even strip off that
parameter in InitCacheWindow()?

Regards,
Christian