Re: [TCLCORE] TIP 732 ready for comments

[<apn...@ya...>]

Now having looked at the unixInit-3.2 test, reason for failure is obvious. As the constraints on the test show, the test expects init.tcl in either ../../library or ../../../library and since TIP 732 explicitly disallows those for reasons detailed in the TIP, the test fails. Note the test would also fail in 9.0 were it not for the constraints which disable it if the build directory is not one or two levels under the source root.

The test itself is flawed / limited. It spawns a new process after unsetting the TCL_LIBRARY env variable. The purpose is ostensibly to ensure Tcl correctly finds the tcl_library location (and encodings) even without TCL_LIBRARY being set. However, while what it *should* be testing is whether tcl does this correctly as per the build configure setting, what it actually does is test if it does this correctly when built from within the source tree. Which is somewhat pointless in my opinion. (No platform has ../../library as its default configure setting).  The constraints on the test to prevent failures under xcode builds, builds outside the source tree itself etc. are an indication of its limited utility.

(Aside - this mostly pertains to non-zipfs builds. zipfs builds pick up from the zipfs archive anyways.)

I therefore don't plan on making any 732 changes other than modifying the constraints to only run the test on zipfs builds (this is already partially present).

-----Original Message-----
From: Jan Nijtmans <jan...@gm...> 

Well, I like this TIP, but there is a test failure on MacOS:
    <https://github.com/tcltk/tcl/actions/runs/18965835171/job/54162420957>

==== unixInit-3.2 TclpSetInitialEncodings FAILED