Re: [TCLCORE] Fwd: TIP 672 Implementation Complete - Ready for Sponsorship

[EricT <tw...@gm...>]

Hi Jan,

Thank you for the extensive refactoring work! I've downloaded the latest
from the tip-672 branch and can see you picked up my latest changes
including the 3-way configuration.

I haven't made any new changes since then, so you should be working with my
most recent code. I'll review your refactoring and provide feedback.

The creation of TclParseExprSubst() as an internal function and the interp
exprsubst knob make good sense. I appreciate you taking this on!

Eric


On Fri, Oct 24, 2025 at 3:22 AM Jan Nijtmans <jan...@gm...> wrote:

> Op do 23 okt 2025 om 20:17 schreef EricT <tw...@gm...>:
> > For my sections: would converting to spaces-only work for the community?
> I hesitate to change the entire file.
>
> No problem. Three things are - in my opinion - important to be done
> 1) The $() is only acceptable if there is a knob to switch it off. I
>     implemented this knob now (interp exprsubst). If another change
>     is made than $(), we can always decide to remove this.
> 2) Integrating the expr parsing in Tcl_ParseVarName() is not a good
>     idea: It's a public function, which behavior would change. Therefore
>     I refactored it into a new internal function TclParseExprSubst().
> 3) The "subst" command (and the Tcl_SubstObj() function) need
>     new options/flags to handle the new "expression" substitution,
>     separate to "variable" substitution and "command" substitution.
>     That solves the discussion, whether this substitution belongs
>     to "variable" or "command" substitution. I think it is neither ;-)
>
> All of this is available now in the tip-672 branch
>       https://core.tcl-lang.org/tcl/timeline?r=tip-672
>
> Eric, if you make further changes, can you please take the
> files in this branch as your starting point? It's quite a big
> effort to merge the two versions, if I take over your changes,
> but you never take over mine.
>
> Please review!
>
> Thanks!
>         Jan Nijtmans
>
>
> _______________________________________________
> Tcl-Core mailing list
> Tcl...@li...
> https://lists.sourceforge.net/lists/listinfo/tcl-core
>