Re: [TCLCORE] Verge of Merge Warning

[Donal F. <don...@ma...>]

In all of these things, you start by doing the bits you can see how to do. I suggest writing some "happy path" tests first to check for a lack of surprises for users using things simply and as they are intended to be used. Then check for syntax errors in the command(s) and other basic bits, and then try to characterise known bugs or places you suspect tricky callbacks might cause trouble. The very energetic can try to get code coverage up... but that's generally quite hard to do, especially full path coverage, and I don't know of good tooling for that in either Tcl or C.

Donal.

-------- Original message --------
From: Erik Leunissen via Tcl-Core <tcl...@li...>
Date: 04/09/2025 08:19 (GMT+00:00)
To: Marc Culler <cul...@gm...>, Tcl Core List <tcl...@li...>
Subject: Re: [TCLCORE] Verge of Merge Warning

What concerns me is that someone has to be responsible for:
* deciding what tests are appropriate/necessary to test the functionality of the
   mac_send branch in general. That is, regardless of any existing tests (flawed or
   not). IMO that includes a test for the bug in ticket #ff2ca8b34c .
* create new tests and modify existing ones, and exercise them specifically on macOS
* making the necessary changes to the test suite in fossil

I'm not in a position to do that [*].

    (I understand very well that it's sometimes difficult to see through the
     workings/purpose of existing tests. I experience that regularly. Maybe
     others can help?)

My contribution:
* I can provide straightforward versions for the tests winfo-5.4 and winfo-5.5.
* In ticket #ff2ca8b34c, I already supplied a test script that exercises the
   bug reported there. That script can be used as a basis for a test.

If you take the lead (insofar as you have opportunity of course), I'm happy to
proceed and provide you with the straightforward versions of tests winfo-5.4 and
winfo-5.5.

Do you think that we could proceed in a useful way along these lines?

Erik.
--
[*] I'm not familiar with the code in branch mac_send, and no dev environment
     (yet) for macOS, I can run stand-alone scripts on macOS for Tk8.6.16)

      B.t.w. sorry for screwing up your last name below. I just found out that that's
      the result of an overly ambitious spell-checker :-(