Menu
▾
▴
Re: [TCLCORE] Crash with fossil pull
|
From: Kevin W. <kw...@co...> - 2025-08-28 15:30:12
|
<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr"></div><div dir="ltr">Thanks Marc. I will definitely be more careful about this. </div><div dir="ltr"><br><blockquote type="cite">On Aug 28, 2025, at 9:22 AM, Marc Culler <cul...@gm...> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><div dir="ltr"><div>The time warp which got fixed is not the only time warp in the Tk timeline. For example, commit <span class="gmail-timelineModernDetail"> <a href="https://core.tcl-lang.org/tk-timewarp/info/c79d493f5ad704cd">c79d493f</a> is also older than its parent. Do we need to worry about the other time warps?</span></div><div><span class="gmail-timelineModernDetail"><br></span></div><div><span class="gmail-timelineModernDetail">- Marc</span></div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Thu, Aug 28, 2025 at 2:35 AM Richard Hipp <<a href="mailto:dr...@sq...">dr...@sq...</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I have fixed the problem on the main Tk repository now, by resolving the timewarp using tags to changes the timestamp on the two out-of-order check-ins. The sync of Tk is working now.<br> <br> For completeness, before the timestamp fix: <<a href="https://core.tcl-lang.org/tk-timewarp/timeline?y=ci&b=20250828&n=20" rel="noreferrer" target="_blank">https://core.tcl-lang.org/tk-timewarp/timeline?y=ci&b=20250828&n=20</a>>. After applying the timestamp fixes: <<a href="https://core.tcl-lang.org/tk/timeline?y=ci&b=20250828&n=20" rel="noreferrer" target="_blank">https://core.tcl-lang.org/tk/timeline?y=ci&b=20250828&n=20</a>><br> <br> I tried this fix before, but it didn't take. I don't know why. Perhaps I changed the timestamps on my local copy (by mistake) rather than on the server. I'm not sure.<br> <br> The bug in Fossil that was causing this sync failure due to a timewarp remains unfixed. I have capture both server-side and client-side copies of the tk.fossil databases that won't sync, so that the Fossil devs can repro the problem, and hopefully fix it. We can do this at a more civilized hour now that the sync problem with Tk has been resolved.<br> <br> <br> --<br> D. Richard Hipp<br> <a href="mailto:dr...@sq..." target="_blank">dr...@sq...</a><br> <br> <br> On Thursday, August 28th, 2025 at 3:18 AM, Richard Hipp <<a href="mailto:dr...@sq..." target="_blank">dr...@sq...</a>> wrote:<br> <br> > Here I have captured a read-only snapshot of the timewarp: <a href="https://core.tcl-lang.org/tk-timewarp/timeline" rel="noreferrer" target="_blank">https://core.tcl-lang.org/tk-timewarp/timeline</a>.<br> > <br> > <br> > I'm trying to fix it now...<br> > <br> > --<br> > D. Richard Hipp<br> > <a href="mailto:dr...@sq..." target="_blank">dr...@sq...</a><br> > <br> > <br> > <br> > <br> > On Thursday, August 28th, 2025 at 3:04 AM, Richard Hipp <a href="mailto:dr...@sq..." target="_blank">dr...@sq...</a> wrote:<br> > <br> > > Check-in 33d1d57acabba44f has a timestamp of 2025-08-26T13:44. It's parent, check-in cd3c8209bd20941f, has a timestamp of 2025-08-27T02:02 So the child was born more than 12 hours before the parent.<br> > > <br> > > See the graph: <a href="https://core.tcl-lang.org/tk/timeline?y=ci" rel="noreferrer" target="_blank">https://core.tcl-lang.org/tk/timeline?y=ci</a><br> > > <br> > > The problem is the unix/tkUnixAccessibility.c file: <<a href="https://core.tcl-lang.org/tk/finfo?name=unix/tkUnixAccessibility.c" rel="noreferrer" target="_blank">https://core.tcl-lang.org/tk/finfo?name=unix/tkUnixAccessibility.c</a><br> > > <br> > > --<br> > > D. Richard Hipp<br> > > <a href="mailto:dr...@sq..." target="_blank">dr...@sq...</a><br> > > <br> > > On Thursday, August 28th, 2025 at 12:07 AM, Kevin Walzer <a href="mailto:kw...@co..." target="_blank">kw...@co...</a> wrote:<br> > > <br> > > > I’m sorry - time warp?<br> > > > <br> > > > > On Aug 27, 2025, at 10:52 PM, Richard Hipp <a href="mailto:dr...@sq..." target="_blank">dr...@sq...</a> wrote:<br> > > > > <br> > > > > I'm sorry - I do not yet know what is wrong. I suspect that it has something to do with the massive time-warp that Kevin Waltzer checked in. I tried fixing the time-warp, but that does not cure the problem.<br> > > > > <br> > > > > There is nothing wrong with the repo on the server. You can clone a new copy and the new clone will work fine. That is your work-around until the problem is resolved. No work has been lost.<br> > > > > <br> > > > > I suspect that the time-warp is tricking the server into sending a delta loop when it tries to sync. Probably somebody (maybe me) made an optimization to the sync protocol that has an implicit assumption that child check-ins occur later in time than their parents. Such an assumption would result in a delta loop in the sync following a time-warp like the one Kevin made. Fossil shouldn't malfunction that way. It is clearly a bug. But I can't find it yet.<br> > > > > <br> > > > > I seem to recall that I had a way to force a sync that used not deltas, just for this kind of problem. But I can't find that mechanism right now.<br> > > > > --<br> > > > > D. Richard Hipp<br> > > > > <a href="mailto:dr...@sq..." target="_blank">dr...@sq...</a><br> > > > > <br> > > > > _______________________________________________<br> > > > > Tcl-Core mailing list<br> > > > > <a href="mailto:Tcl...@li..." target="_blank">Tcl...@li...</a><br> > > > > <a href="https://lists.sourceforge.net/lists/listinfo/tcl-core" rel="noreferrer" target="_blank">https://lists.sourceforge.net/lists/listinfo/tcl-core</a><br> <br> <br> _______________________________________________<br> Tcl-Core mailing list<br> <a href="mailto:Tcl...@li..." target="_blank">Tcl...@li...</a><br> <a href="https://lists.sourceforge.net/lists/listinfo/tcl-core" rel="noreferrer" target="_blank">https://lists.sourceforge.net/lists/listinfo/tcl-core</a><br> </blockquote></div> </div></blockquote></body></html> |
